When the site or institution has disabled public views, there's a
notice on the view access page to that effect, but the user can
happily create new secret urls with no indication that they won't
work.  This patch removes the generate new secret url button, and adds
a notice to the secret url page to inform the user when they're not
allowed to create public pages.  Also adds a sentence to the site
setting to make it clearer that disabling public pages also disables
secret urls.

Change-Id: I93a36df425bf06c4748cfdbfaf62613017518872
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Urls stored in the url field of notification_internal_activity contain
the site's wwwroot.  This leads to broken links when the wwwroot is
changed.  It also dangerously turns what should be local links into
remote ones when for example a production database is copied into a
test Mahara instance.

This patch does three things:
- Removes the wwwroot from urls passed to ActivityType constructors
- Adds the wwwroot back on the url when sending email and emaildigest
  notifications, and when displaying them on the site.
- Removes the wwwroot from the url in all existing rows of
  notification_internal_activity.

Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This has already been done for the main menu

Change-Id: I3141f2c1c43967e7ff88a5b71dce62b122182840
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This has been unnecessary for some time now, because the same count
appears next to the envelope in the top right of the header.

Change-Id: I14581f8edff19ee5111eba4ff4ec8f564ad2443a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

As a result of profile view access changes in bug #807278, profile
views are displayed on the share page.  So the 'editing' version
of view titles needs to be displayed in two places (my views/
group views etc., and on the share page).  It makes sense to use
the same View methods in both cases, and remove the old logic to
get the view title and url from the template.

Change-Id: Ifa36651dc3358acd71ca63407df79799ddd47299
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

The profile view title is now displayed on the share page, due to
recent changes in profile view access (see bug #807278).  However
the view title from the database is now displayed on the share page
instead of the translatable string.

Change-Id: Ic691469731923faa0cef0c204b1207a9152e9fe2
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When configuring a textbox that includes an html artefact owned by
someone other than the view owner, it must be made clear to the user
that the textbox cannot be edited within the current view.

In this case, the sanitised html from the artefactchooser is
displayed inside a grey box in the config form, and the tinymce editor
is hidden.

A help file has been added to explain why the user cannot edit the
selected artefact.

(When tinymce includes an toggle for its read-only mode, this can be
simplified)

Change-Id: I81b44928b7ac83ffaebba04d4ab34d3964743bf4
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Removes some duplication, and also ensures the appropriate forms are
created on submission to invoke the error message display.

Change-Id: I792381eec98ef3aaa9fb9558302e5183cd1a375f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When you tag an artefact with 'profile', it appears in your profile
sideblock. The 'Artefacts:' heading above this list has an icon that
overlaps the text.

Change-Id: Ifb03a5e5e49f7c8bfa996dae619d5fd1699fd29d
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

New blocktype icons were introduced in commit e6fe5d86

, but
hardcoded width & height properties in the blocktypelist template
(used by the drag & drop javascript) were never updated to match the
new icons.

Change-Id: I8321945450a502dc91df05aa39f067713fd5e90d
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

If the tags page was visited with "tags.php" via, say,
the sidebar heading, the urls made with the template
were broken; the query string was joined to the baseurl
with a & rather than a ?. This patch checks if the last
8 characters are tags.php and sets a queryprefix value
based on the result.

Change-Id: I56f87b76e9fb82472fda2c6cb2c5315bb3f79c05
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

This set of changes attempts to handle missing plugins in a better fashion.
Rather than throwing an uncaught error which causes a unrecoverable site
error, which in turn means that no user can use any other plugin; this
patch disables the problem plugin and informs administrators of the issue.

To handle the case where core plugins, which under normal circumstances
cannot be disabled, are missing and disabled; the plugins.tpl template is
also changed to test for the contents of the activateform, instead of
whether the plugin can ordinarily be disabled. This means that if the issue
is then fixed, the plugin can once again be re-enabled, at which point the
[ hide ] link will no longer appear.

Change-Id: I6f9fa73ae0ac307b5f5f8f30b8205690926f54fc
Signed-off-by: Andrew Robert Nicols <andrew.nicols@luns.net.uk>

When the logged-in user can't get to the member listing for a group
(bug #845287, bug #504830), it seems like a good idea to also hide
the number of members.

Member counts are hidden in the group info block and copy a view page
by moving member & view counting into the group_get_groupinfo_data
function, and performing the permission check in one place for both
pages.

Member counts are hidden on My Groups and Find Groups inside the
group_prepare_usergroups_for_display function.

Change-Id: Ibe5675861040cedf67c2ddff7647117cd155722a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When editing access for group and institution views, this link went
to the share page for the individual logged-in user.  It should go
to the group's share page, or the institutions share page instead.

Change-Id: I1af2b645fb2fcbee6cbb67306605dca5215256f2
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When 'invitefriends' is enabled, all members of the group get a
button on the group homepage which allows them to send membership
invitations to anyone on their friends list.  The 'suggestfriends'
setting allows group members to spam their friends with suggestions
that they join the group.

Part of https://wiki.mahara.org/index.php/Developer_Area/Specifications_in_Development/Groups_revamp



Change-Id: Ifaf91ea59d569255de861efdcab97745f3feaa3a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This creates groups in which members can't search for each other.
Group admins can get to the member listing, but tutors cannot: the
stated use case is anonymous reviewer groups.

Change-Id: Id2550e574b55ceeb43958475340e967de16850f1
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Admins can set the 'locked' property on a group view, and this will
stop non-admin members from editing the view, regardless of the view
editing permissions given to roles within the group.

Change-Id: I56c113a9d4e8fcab5463fa1c54bf456f7fc2364b
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These two pages both display the same data, so it makes sense to
fetch it in a single function.  This also reduces the number of
display_name queries and thumb.php requests for group admins.

Change-Id: Ie10caa60d560337fe0302690e629d1ac8196db6f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This will reduce the number of queries required by display_name calls
over group admins on the find groups and my groups pages.  Moving this
into a separate function will also enable the same query to be used in
other places such as the groupinfo block.

Change-Id: I3ca81dbce87f42e00ed57caeaa4ba6aed0230009
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Changes to templates and css for: Forums list, Site statistics,
Admin user search, Group members, Search boxes, My Views.

Adds a few extra DIVs to make it possible to customize the layout
further in themes that inherit from the raw theme.

Change-Id: Ib534b2949f93277fd48c9168797c852f12801b7d
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When the view acl screen was changed to streamline the setting of
access permissions to multiple views/collections at once, secreturls
moved out of this screen. As it is still in the share tab, it is not
obvious to users that they should return to the list of views and
collections to find the secreturl screen. This text guides them there
with a handy link and explanation of the screens.

Change-Id: I47406747a374d5d210c46473a0b4c28134f829aa
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Bug #825595.

Add "Friends" search functionality to "Share with other users and
groups" section. The Friends search view is also the new default now,
instead of Users.

Change-Id: Id2c278a64e1c8d921cb8bea8179a8c39e6a47a50
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

This replaces the template form with a pieform. Due to pieform name convention,
the css style for 'language-select' has been renamed to 'languageselect'.

Change-Id: Ifd1aae9a81d7900113452b277199219998a4d80f
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

Change-Id: Ie13b7255462bb550024155a9c1fb0528fd88a95c
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

The four existing jointypes, 'open', 'controlled', 'request' and
'invite' are mutually exclusive, but they don't need to be so strict.
This patch introduces more flexibility in the way groups allow new
members to join.

* Group admins can always send membership invitations to a group, even
  if it's open or controlled
* Membership requests can be enabled for any group unless it has open
  membership.
* The grouptype now determines the set of roles available to a group,
  but no longer restricts the available join types.

The db upgrade will preserve existing behaviour apart from enabling
invitations on open, request, and controlled groups.

Change-Id: I8bb0940a37f3c0c36366c1d5b8d27e8b9914a7e3
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This reduces duplication, but will also make it easier to do the major
upcoming group type update.

Change-Id: Ie2e5b81c412106af2fe0d1da6b7a595c79caf081
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I7e72a77375cff65dd20189ba1b93cf9dbda3be42
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Part of bug #807278

Profile page now behaves more like a normal page/view, with the
following exceptions:
- Not removable
- Title, description and tags not editable
- No advanced sharing options
- Cannot be part of a collection
- Not available in bulk access update options

Change-Id: Ia42cdaee7978fe2e737a89cd79b043feb02ceb0d
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Part of bug #807278

Make it possible to indicate and 'lock' a view access record item (in
code)

Change-Id: If8c6e574e7d40606269035a598586ff2a49bbe48
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Part of bug #807278

Enable the ability for users to share their views/collections with
the institutions they are members of.

Change-Id: Id647672141610cced579dbf199690292a249e7b7
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Allow administrators to provide their own links for the following
links in the footer:

terms.php
privacy.php
about.php
contact.php
Signed-off-by: Carson Tam <carson.tam@ucsf.edu>
Change-Id: I90d2eba97bede9eca55799b1af21ae11cb4444e9

Change-Id: Ia6df631512795b68e1eba7906220803ca3a7f500
Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>

Change-Id: I8f0c4793c629875d36eb28e33a8dadd665cb4957
Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>

Change-Id: Ib9f6cea3607b6b7b6c50188ce353b70cd1869087
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Adds a new dwoo function to json-encode strings for inclusion in
template javascript, and uses the function in the viewacl template.

Change-Id: Ie632061fe94a2adc2943a3d830695a44650847af
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This is a useful feature that alows to make less mouse moves to move a single
user from one box to another in userlist interface (Institution
admins/staff/members). It does not affect any existing functionality (i.e.
actions with multiple users).

Change-Id: Ibe2ba524cb74ad4dc9d7abfc5879a884cbade39f
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

In the feedback list, and in some blocks with multiple pages such
as the blog blocktypes, this fixes a display bug in which the page
numbers were too tall for the containing pagination bar.

Also adds a couple of minor theming fixes for the drop-down menus,
and buttons in the ultima theme.

Change-Id: I75da7c86115753bdc914e7fccbbf6b552b11e8ab
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When an institutional admin selects the "Configurable theme" in the
institution settings, a set of colour pickers are displayed.  When
the form is saved, css is generated from the customcss.tpl template,
and saved in the database.

Change-Id: I8583459ac9c06c8292796bb943ba64456f8e0723
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This change adds css and images for the custom theme, and a template
which can be used to generate the additional css to override the base
colours of the custom theme.

Change-Id: Icf6be5bac60a3b54bb6ef5cad234fcf0ad5686f7
Author: Evonne Cheung <evonne@catalyst.net.nz>
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Adds new wrapper divs to the main column and tabs for more flexibility
in child themes.
Styling of new blocktype panel (see bug #808601)
Many other miscellaneous fixes, including to the dropdown menus
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Ie1de1861d967bb6e954bdb41c792c268245f6bb8
Author:    Evonne Cheung <evonne@catalyst.net.nz>