GitLab

Bug 1252101

1. New users get 2 "new user points" on their user record

2. While they have these, they're on probation and can't post
links in public places, or make public pages.

3. "new user points" are decreased each time a non-probationary
user responds to a forum post by the user

4. Admins & Staff are automatically non-probationary

Change-Id: Ibccd2e330945f66b07aac062c4f51b67a0c0dba2

Bug 1067724

Change-Id: Ie3f6b1136307e4c715929e94d6892e43636c7baf

Robert Boloc authored Mar 03, 2014 and Robert Lyon committed Mar 03, 2014

The only place that calls the get_view_from_token() does nothing with
the output. It is left over code from version 1.2 where the token was
checked to see if an anonymous user could add feedback to a view or
artefact.

The code changed completely in v1.3 where things like tutors came into
play so I've removed the legacy old code from view/artefact.php

Change-Id: Id1bf9732d87d4ac50ab2d12d1279b400d5f6ee30
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Pieforms now adds a global error message if there are any validation errors
in a form, in addition to the messages beside each element. This is
modified from the existing jserrormessage

Change-Id: I15b9f4238ec3e5b1e6cb7fcff0514855565f0364
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Bug 1266320

Change-Id: I24f72049f13e145f46145df2d248a02e2a3af8ba

The get_configs_user_institutions() method used the global $CFG variable
without declaring it, causing warnings when trying to set a property of it

Change-Id: Id02edcf735ffc3c8a779dc787715a6ba20626af1
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Bug 1264429: This patch creates the table, refactors the get_institution_config() method,
the Institution class, and the institution editing page, to use the new table.

Henceforth columns should only be added to the main "institution" table if they represent
a required setting (like name and displayname), or they need to be accessed frequently by
direct SQL queries.

Change-Id: I4564240d2c55ec2b6ec90868290a61cf4321460a

Compressing array of tags to unique case insensitive values if needed

Eg
array('Test','cat','test','TEST','Cat');

will become
array('Test','cat');

for mysql sites that have case insensitive tables

Change-Id: Idf0b8a4440ef0f9273d5be685cf7ad22fecc746a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Jono Mingard authored Dec 31, 2013 and Robert Lyon committed Dec 31, 2013

If TinyMCE is enabled/disabled in the site settings it should always be
enabled/disabled for Feedback. 

If TinyMCE is set to User-defined, it will only be enabled if the
logged-in user has enabled it in their user settings. This means it will
be disabled for anonymous users and people who've turned the HTML editor
off.

Change-Id: I5565e69574c65296067f7883b2e66c50a8f15919
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Change-Id: Id8b24afcd7dcfc315b1f62cf70e57de289ba784f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1250256

Change-Id: Iefd489adb4f7d458d1e8b45727fab5509c61398b

- have updated copyright for the pages that had existing copyright
notices (except for the lib/pieforms/ section as i'm not too sure if
that needs changing as it is a different Catalyst IT product)

Change-Id: I11c65ad26cb9cd856cf16b1dccbd4223ba086645
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Upgrade our ADODB driver from the long-obsolete mysql driver to the actively developed mysqli driver

Bug 1187964: The biggest improvement is that the ADODB mysqli driver actually supports transactions!

Change-Id: I8e55ea28cd6e6b8ed5c883646c1172d318af5554

Bug1168213

Change-Id: Id23b2d6c163def4365d17e26b6c701a4cdadc948

see also https://mahara.org/interaction/forum/topic.php?id=4404



Change-Id: Iab8524b3f1f86ceacb9854d57cdd00e62aa5e32f
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

- Bugs #1201258, #1181010, #1199563

As these are all integrated together it is easier to test them as
one patchset.

Change-Id: I5ce68a4ea2de1de8b9deeb7d95380fcdcae095a0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug #1196781
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>
Change-Id: Ibc6740f45e59804720823b5cc34e80ca33b3c621

Bug1183612

Change-Id: I458cfd08a0326f3e21aefe656e00bcdeb6c85bbc
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Evonne Cheung authored Jul 10, 2013 and Robert Lyon committed Jul 19, 2013

Here are all the UI changes that were made by Evonne

Change-Id: I08d98d759a701deaf0a332af9e9392b7270704a5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I33ce7dc6e6c14917c9632afc672c0faf5718647b

Add a new function Artefact::artefact_get_tags($artefactid)
to return a list of sorted tags associated to an artefact

Display tags of plans

Change-Id: I3720b4954be2e928539e75362dab8059fbe35169

Change the help text handling so that when a help text is not found for a
specific form/element combination, it also looks for a wildcard ANY/element
help text.

This is used by the license metadata feature to provide uniform help text for
the license fields on all forms where they appear.

Change-Id: I4c3f1a38d81ae54081e555b2296d28955329cf77
Signed-off-by: Jiri Baum <jiri@catalyst-au.net>

Log events, including both user IDs when masquerading is in progress. The log
can be configured to log all events or only those while masquerading is in
progress or none. The log is expired after a configurable delay.

Note that this logs all events (or all masquerading events) even though this
feature only includes one report of one type of event.

Change-Id: I7a59d98b84b0527a55363b4d01448b9b1809aa9e
Signed-off-by: Jiri Baum <jiri@catalyst-au.net>

Was broken by commit 544c62b7 for
(Bug #941551)

Change-Id: I5ef546564677927e96541791ca3bbee1869e544b

split() will be replaced by explode() if using a string as a delimiter
and by preg_split() if using regular expression

Change-Id: I93a84150197fb290f89a04f10d5f0fd1e380f0da
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Also add a few theme changes that allow some more
features on small devices.
- Printing links
- Settings link in top right corner
- Create/copy page/collection link
- Edit/delete buttons
- Remove group members button
- Help icons
- Administration link

Also made the admin link show in full

The items that are disabled when device detection is on
and user is on a mobile device are:
- TinyMCE editor
- Adding new blocks to pages, this is now a non-js version
- Dropdown menu's
- Export functionality

Bug #1052060

Change-Id: I5a8fe3cf136bb0c3e76e50a2b3bc48179c675b6a
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

as it doesn't work for some devices

Change-Id: I34a72348b7d9c23a5840754a41022e806349c543
Signed-off-by: Liuba Kazakov <liuba@catalyst-au.net>

Change-Id: I10ac8fc0c53a66eabb2a7f558f4111f3a2d5e61a
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

Replace institution name with institution display name.

Change-Id: Id1c358802b22665b300601062056c72f39a71723
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

Change-Id: Ibf300f85cbcea12f6ac6ddb89a1eb5f6ea47216b
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: Ifdc7dbaf2ec7c3ebaa40cb557e0a093423c5c71d
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: Ie0d96d6caa5b6aff66bdb49e14940ab349046147
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Copied from the mahara.org registration table. It stores each registration field
in a local database with a timestamp of when the data was obtained.

This storage is done whether or not the data is actually sent to mahara.org.

Change-Id: Ib8478b0caa97c5cc5f04a7d5b44f2a9ac11f9ce8
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This patch removes some inapproprate uses of the |= and &= operators
on boolean values.  On view/edit.php, &= was also used on the integer
return value from strlen as if it were a boolean, resulting in the
clean url field being uneditable in some instances where it should
have been editable (see bug #1006634).

Change-Id: I96a72c407309ed82a45d3130cffa06418be05fe7
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

This is more efficient on many pages, because the user object has
already been fetched, or is about to be fetched, to run display_name
or profile_icon_url.

However, user object returned by get_user_for_display won't allow
can_view_view to tell whether a user is suspended or not, so
suspendedctime is added to this object (it's less identifying than
suspendedcusr).

Change-Id: Ic9d1e5d437aedbc45f6328a05997812dcf45c8d6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

In order to get the url information for the list of views returned by
get_views(), that function is modified to gather the views in a single
flat list rather than in a structure indexed by user id.  Just before
the view list is returned, the url information is fetched and the user
array is built.

Change-Id: I12dad07c90f8c51614e72c7402c63dc38fccceeb
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

Only affects views that the owner has tagged 'profile'.

Change-Id: Id4a6b641ab46e6cf105d9dbf295fb16f8d343987
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Avoids double queries on view/view.php and view/artefact.php, where a
View object is constructed from an id inside can_view_view, and again
on the page.

Change-Id: I0f034f04765f73d64758b6ff7ec11c5cbdcdb6f7
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

Views and artefacts are pulled from the db together in a UNION query.
We can't simply pass the whole list of records through to a View
method - it's easier to generate the urls one by one in
build_portfolio_search_html.

Change-Id: I59b1ab91e141611d4a41e60b28a0bfdf13167749
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

In many places user urlids are not currently available when the
profile url is generated, but it is trivial to get it, and then change
the user/view.php url to a profile_url call:

- Admin page access report
- Profile links in feedback lists
- My friends block
- Wall posts
- Group members block
- Group members tab
- Recent forum posts block
- Group admin lists on forums page
- Group admin lists on my groups, find groups
- Group admin lists in group info block
- Profile sideblock
- My friends & find friends pages
- Institution landing page
- Online users page

Change-Id: I33e122896982037a887aad8e3362db450e123e3f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>