GitLab

icon-arrows     -> icon-arrows-alt
icon-shield     -> icon-shield-alt
icon-refresh        -> icon-sync-alt
icon-clock-o        -> icon-clock
icon-pie-chart      -> icon-chart-pie
icon-area-chart     -> icon-chart-area
icon-commenting-o   -> icon-comment-dots
icon-arrows     -> icon-arrows-alt
icon-question-circle-o  -> icon-question-circle

behatnotneeded

Change-Id: I4fb3feebc11cc335f5dde05cc6e45c50b29359a6

increased the maxLength property of textfields to 1000000 chars.

behatnotneeded

Change-Id: I7b9307de6f588aa841355500282f24b32c5ede85
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

behatnotneeded

Change-Id: Ie369f5b2433709738fe10563e8200748c06a3896

Forgot to bump the version number for install

behatnotneeded

Change-Id: Ia767da37abc26991ab2dba51f23d9520564b35a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch:
1) adds a button to make new cert/pem without deleting old one on
plugin config page
2) have both certificates listed in metadata
3) allow the deletion of old certificate and moving new one into its
place

behatnotneeded

Change-Id: I12a0f65582a0198cbb5d8b55fcf77cc677088ba0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

W3 speicifications have changed and Mahara code didn't pass the
validator. Issues have been corrected.

behatnotneeded

Change-Id: Ic22cc7cd6df0bddc995ff7f61502a2aa7455810c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

reserved keyword found needing to be fixed:
admin
was set to reserved in mysql 8.0.2 and then changed
back to unreserved in 8.0.12
we need this patch for the version in between them

behatnotneeded
Change-Id: Ife693b3d490ca5fd1112d0a55ff1ae74a9579aa5

behatnotneeded

Change-Id: Ice8e039ed2163e42f062c42ea90c335659cc6926

The issue is that assert() with a string arg is deprecated.
The patch that fixes this is currently a release candidate,
which I have installed here to see if the patch works.

Requiring people to use memcached, not memcache
Removed checks for mcrypt, no longer required

@TODO:
Replace RC version with release version when it comes out.

behatnotneeded

Change-Id: I111b8cedeb3847ce585ebac0eb576107542a93a2

Event
   Breaking change: .load(), .unload(), and .error() removed
   Breaking change: .on("ready", fn) removed
   Breaking change: event.pageX and event.pageY normalization removed
   Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
   Breaking change: Delegated events with bad selectors throw immediately
   Deprecated: .bind() and .delegate()
     no calls to .bind() for events in core.
     Only calls to bind() refer to the js bind of arguments to functions.
     no calls to unbind() for event in core.
     Only calls to unbind refer to the unbind method defined in
     formChangeManager not related to the jQuery method.

    Warnings fix
    JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
    - also applies to the other event shorthands, including:
     blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
     mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
     change, select, submit, keydown, keypress, keyup, and contextmenu.

    JQMIGRATE: jQuery.fn.hover() is deprecated
    JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
	(for FileBrowser we can see this error when editing a block in a page)

behatnotneeded

Change-Id: I1a50050f882b864ad63d273de160e0b441a77705

As an alternative for memcache / redis

behatnotneeded

Change-Id: I8be8894f1cda6d0102db31475025236a5a4b86ca
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I7015e84895533aa3ae338da27c872d0d00b97b84
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And allow deleting of unused ones

behatnotneeded

Change-Id: I1e00cb207b8d5b29711a1301f7a25fed772b8e67
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I221b08af2015712163fcbfca6e0a3962e932615b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

We utilise the simplesamlphp metarefresh plugin, and hook it into the
mahara cron for the auth plugin.

This adds a new field to each instance configuration form that allows
the user to specify a url that metadata should be fetched from.

This information is fed into the metarefresh plugin's config and a cron
hook is run every hour that triggers the plugin.

The simplesamlphp configuration is updated to read both the metarefresh
target location and the normal xml config file location, with the
metarefresh config files taking precedence.

NB: because of the way that the auth/saml plugin stores the idp entity
ids you are still required to present an XML file at least once, with
the metadata refresh config only taking over once it's fetched in the
next run.

This gives a smooth upgrade path for all existing mahara instances,
where they should continue to operate as normal, and then an
administrator can add the metadata refresh url at their leisure and have
it take precedence as soon as the metadata is available

behatnotneeded

Change-Id: Ib5733f7526a1c19d3150b45d90c9b675d4dd7ad2

Also add label field for auth message for both saml and xmlrpc

behatnotneeded

Change-Id: I4f5f887ba48c26dce92b69eda0f03a7fa761c78d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Taking work developed by Matt C and adjusting it to be more of a
session handler option.

behatnotneeded

Change-Id: I443d9e67d2322c995f9277ce1ee835092dc6c218
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To take advantage of the new things plus the bug fixes

behatnotneeded

Change-Id: Id7033f4c1308ecbfbd38a76e018a1a4ca4327dda
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Similar to what xml-rpc does, so allowing admin to set a message about
how to properly login

behatnotneeded

Change-Id: Ib4a85571dccf0fcf719785481645777c506687da
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And avoid direct $_GET and $_POST usage where possible and instead use
param_exists() and the correct param_*() function to fetch the
expected value

behatnotneeded

Change-Id: If2a917360ebf1d198a494907517eb06bb823743c

behatnotneeded

Change-Id: I2dde01166da1a001edfee3b2cc97badfe6ceb2a4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I24895a80f49820212e3708592a4cd4638a8fe2d8

behatnotneeded

Change-Id: Ieea98e63ba9db15613f28ad34b95ed4177aba3e9

behatnotneeded

Change-Id: Iddb57a880675ec6097f19a597cd2e8f1083534ba

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

If there is only one user with email then it will link it up
automatically

Otherwise will allow user to choose

behatnotneeded

Change-Id: I98bdb3f3ade24dbed7326b4b5719d2b23c2e7e9c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The way it worked before, to add a mapping file we
have to edit the saml config.php code

With this patch, to add a mapping file we can set the variable
saml_custommappingfile with the path to the file
in the mahara config.php file

behatnotneeded
Change-Id: I6396930da8dfdbe1904e469f309cdb4e38d46757

Allows you to set the signature algorithm for simplesamlphp from the
Mahara SAML plugin configuration screen.

The default setting is sha256, with sha1 available as a fallback for
those institutions who need it.

For an already existing site the default is set to sha1 as that is what
it would have been previously

behatnotneeded

Change-Id: I3eb628d837bdabbfc7641620e94fc2f127beceb9

behatnotneeded

Change-Id: I353fe7390d6f8fd2bbebc9bec01188428edf786e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch allows the dataroot/metadata/*.xml file to be named after
the idp rather than the Mahara institution.

Also added
- A select dropdown so that institution can pick existing auth to be
paired to
- Upgrade to rename the dataroot/metadata/*.xml file
- Check to stop being able to add blank metadata field
- An alert for user when updating metadata if other institutions are also being effected
- Delete the metadata if deleted institution is only one using it

behatnotneeded

Change-Id: Ie3f5cdc523404b1081352ede67aab591e79b6dbb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To make it easier for admins to know which PHP modules to install

behatnotneeded

Change-Id: Ib58750436426f87b3e6c4fc41c639b930f0a6a56
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Allow the saving of Student ID along with currect things like
firstname, lastname etc when creating a user via SAML login

behatnotneeded

Change-Id: Ib6d8271878247573972c93d84c68698902e34a0f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To match up with what moodle do with xmlrpc
See https://tracker.moodle.org/browse/MDL-52766

And to be consistent with saml

behatnotneeded

Change-Id: I47858cbf5cc9fec04d47e2660ac660604f776280
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I3d961abd70ff4a2f585767a3ece5a8681ef74647
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The pre php5.5 "Can't use method return value in write context" issue

behatnotneeded

Change-Id: Ie5f122d96eddb643b3931eac29e8367323611cf8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is needed specifically for the
module/mobileapi/tokenform.php script

Also adding an anchor "#sso" at the extra login elements,
to allow the app to scroll that part into view.

behatnotneeded: Can't test in Behat (yet)

Change-Id: I4363976522b8339542002535d8ba57fdc70496ac

fixing sql call table not in {}

behatnotneeded

Change-Id: I97c110bbbf68e51d8a3337ce213840869c3dbe77
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded
Change-Id: If88dd9ff55b232a2c6b694d64eeb4231918b0ca7

Change-Id: I07bb4031679fec26ea0535dc9b6604b5d1c42bc8
behatnotneeded: Covered by existing tests