[#3000] quote a string value in a query for 8.3 compliance. Chris Bandy and Piers Harding, patch doctored by me for readability.

[#2227] If we're decrypting a message and the signature doesn't validate, try grabbing a new public key from the remote host and verifying the message again.

This is the last bit of functionality required before all given cases of Moodle/Mahara keyswap work. Yay!

When decrypting responses to our XMLRPC requests, consider an older key to be OK. This fixes keyswap when both hosts have different keys (!)

Modify get_keypair so that it can be called from outside the class, and the regenerate parameter being true actually regenerates a key.

When an CryptException occurs when sending an XMLRPC request (because the response was using an old key for example), fail in a nicer manner.

Update the message for the primary cause of this (old key) so it's more obvious in the logs.

The MNET code uses this a bit.

Bump the default key life to 365 days, up from 28. We will be properly fixing keyswap soon, this is just a stopgap.

The name is largely irrelevant as it's only the creator of the file.

Add a second parameter to get_peer, that will force re-retrieving a peer object rather than using a cached one.

Moodle's XMLRPC API currently makes some calls that Mahara doesn't implement. Implement these calls as no-ops.

Moodle uses it only in the course listing block, to say '4 courses from [othermoodle]'. Mahara doesn't have any courses.

Signed-off-by: Andrew McMillan

Now, table names (and other identifiers that could be confused with SQL kewords), should be put into SQL like this:

SELECT * FROM {artefact}

The braces are matched and expanded by DML now to include the prefix and be properly quoted, which means that tables like 'view' and 'group' don't need renaming (and nor should they, there's little reason why we should rename tables to get around such constraints).

This has removed a whole bunch of $prefix = ... and get_config('dbprefix') stuff, which makes things a little simpler yet again.

code

function

method to api_*

field need be passed to query