Cecilia Vela Gurovic authored Jan 23, 2019 and Robert Lyon committed Jan 31, 2019

behatnotneeded

Change-Id: Ieb19aae05762677e2ce8b27e564d658b0d9f1c24

Robert Lyon authored Jan 24, 2019 and Cecilia Vela Gurovic committed Jan 30, 2019

When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9a827627)

Robert Lyon authored Jan 23, 2019 and Cecilia Vela Gurovic committed Jan 28, 2019

When we are wanting to check if there is an array to foreach loop over
and that array has at least one entry.

Currently we try to loop over entries by checking with just count() and we get error
- count(): Parameter must be an array or an object that implements Countable

behatnotneeded

Change-Id: I9accca2e97f415d5f9a2203b6fd984a41e95a4d0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9b3e36e2)

behatnotneeded

Change-Id: I8334d8f95f1c218f1a264f01a4e62b3e8f3c7ea5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 3042084a)

Lisa Seeto authored Jan 24, 2019 and Cecilia Vela Gurovic committed Jan 24, 2019

When submitting a collection to an external site e.g. Moodle
When viewing Mahara as a site admin

behatnotneeded

Change-Id: I9bcdbedb235c838e87e208b17eee6a71bf1674d8
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>
(cherry picked from commit 30fdf368)

Cecilia Vela Gurovic authored Jan 11, 2019 and Robert Lyon committed Jan 24, 2019

behatnotneeded

Change-Id: I459263cc0468639fd41b669efb750d6ac618cb5a
(cherry picked from commit 8400b75d)

Robert Lyon authored Jan 10, 2019 and Cecilia Vela Gurovic committed Jan 22, 2019

behatnotneeded

Change-Id: I17a2c50f0d6be15a4d00a1917895c3908a60b02c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 20f76ffc)

Forgot to bump the version number for install

behatnotneeded

Change-Id: Ia767da37abc26991ab2dba51f23d9520564b35a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 15e6726a)

Cecilia Vela Gurovic authored Jan 11, 2019 and Robert Lyon committed Jan 11, 2019

behatnotneeded

Change-Id: I9925a6a5265cc768140c41015c63feed163e88ce
(cherry picked from commit 0080525a)

Robert Lyon authored Nov 28, 2018 and Cecilia Vela Gurovic committed Nov 29, 2018

Currently when setting up a dashboard/profile template we can't
add/re-add certain blocks if they have been deleted

behatnotneeded

Change-Id: I2bd95b1fb67357994b2ff43356387b18b0644d97
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6c0d6a84)
(cherry picked from commit 2bddf9ba)

behatnotneeded

Change-Id: I5b59c45ef7b84b947615ed4ccd8a0651aa935fdb
(cherry picked from commit c7dc45bc)
(cherry picked from commit 65a23474)

Robert Lyon authored Nov 14, 2018 and Cecilia Vela Gurovic committed Nov 16, 2018

behatnotneeded

Change-Id: Ia7cd266ab5552e14a14f0ec3412448a249a06af9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b77049b2)
(cherry picked from commit d6d5591b)

Cecilia Vela Gurovic authored Nov 09, 2018 and Robert Lyon committed Nov 13, 2018

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe0)

Ghada El-Zoghbi authored Nov 07, 2018 and Robert Lyon committed Nov 09, 2018

During an upgrade, the clean up should also remove records from
the oauth_server_config table.

behatnotneeded

Change-Id: Ia0ae61ddb7cf7b05241466ec0d6900d2025d662b
(cherry picked from commit 6b06c240)

Robert Lyon authored Nov 07, 2018 and Cecilia Vela Gurovic committed Nov 07, 2018

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
  $cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 07d6e505)
(cherry picked from commit e3fa699b)

So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I0c556a00bfec585dfc6a561ff7f66d9fd7fc7410

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Oct 11, 2018 and Robert Lyon committed Oct 25, 2018

The specification for this attribute has been
changing and is not using the 'camera' value anymore

1. Have the same response in both the image button
in the tinymce editor (text block) and the image block
when selecting the image to upload.
2. Dont assign a value to capture attribute since
'The missing value default is the implementation-specific state'

behatnotneeded
Change-Id: Ib0a6203d6cee1b05968558c2142b7f6d10ffaae1
(cherry picked from commit 49798838)

behatnotneeded

Change-Id: I163cb13a77e03fdbdf21c27bace787e104383a2f
(cherry picked from commit 3ccc3e54)
(cherry picked from commit 69a964a5)

Cecilia Vela Gurovic authored Oct 17, 2018 and Robert Lyon committed Oct 18, 2018

dashboard and profile views are ignored when
importing Leap2A file for an existing user account

behatnotneeded

Change-Id: I47868196714ada1adf45b6aa1d44ac1a473eff57
(cherry picked from commit 92d0b92e)
(cherry picked from commit ace60275)

Cecilia Vela Gurovic authored Oct 11, 2018 and Robert Lyon committed Oct 17, 2018

at the moment we are assuming the string to get
the title of a blocktype is 'title'
but this doesnt have to be the case,
like in the blocktype myviews

behatnotneeded

Change-Id: Ifeaac2731df6f495f00f3e12a806327e65ff63a9
(cherry picked from commit 2b8287dc)
(cherry picked from commit c38a17ef)

Robert Lyon authored Sep 26, 2018 and Cecilia Vela Gurovic committed Sep 28, 2018

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0866ac93)

And also with calling $USER->logout();

And also with showing missing ldap server info for a user

behatnotneeded

Change-Id: I03656d286bbf2e56416151a52b2051235f9364df
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 254103d6)

Cecilia Vela Gurovic authored Sep 07, 2018 and Robert Lyon committed Sep 14, 2018

Also stop showing the copy page button on the collection rows

behatnotneeded
Change-Id: I2cfb78609b37fc56fdbf1f12be2f29c08e63a411

Robert Lyon authored Jun 01, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7c8f5f5b)

Sarah Kirby authored Jul 16, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018

behatnotneeded

Change-Id: I5353e13e4e41bfcf742cb013e5640288e6f03bda
(cherry picked from commit 71f16160)

To allow for using newer PHPUnit version that uses Namespaced clases

behatnotneeded

Change-Id: I9e33c2542dda76691b32df78335ce511b06174c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I8df12c5b2ec35a9c92231de8bfa90f1909af6afc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b44)

So that we now can search by title/description/tag for valid artefacts

behatnotneeded

Change-Id: I9c514f98998b0a97326a8ba7c1de4566453a38aa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This allows to get an element out of been hidden by a topbar menu

Change-Id: Ib6b8f704919ac141e7170e10ad25e247e645b16d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b22a6c43)

Kenneth Hendricks authored Jun 12, 2018 and Robert Lyon committed Jun 19, 2018

This flag will set whether the function should
attempt to create the file if it doesn't exist.

E.g. image resizes.

This allows an external file system to call
get_local_path with this flag set to false to
skip the processing. This allows an external
file system to avoid an infinate loop when calling
get_local_path to check local file availibility.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: Iaade0b06fcc2cd1755467231e0bafea6b90a99ec
(cherry picked from commit 63d04fd1)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

The fix in Bug 1774309 fails to work correctly when the site
is in a subdirectory of the apache root.

To test:
1) Adjust your site's apache file and set the DocumentRoot to be
parent of htdocs
2) Change the 'wwwroot' db value for site to include the 'htdocs/' bit
3) Restart the apache server
4) Go to site, adding 'htdocs/' to url
5) Try logging in

before patch: end up not found page with url containing two 'htdocs/'

after patch: end up at correct place

behatnotneeded

Change-Id: Ic5e1de2c5edaf96bbdd9b2403f0f65e45a4b80c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d9ce7d92)