Skip to content

GitLab

Switch branch/tag
  1. 25 Feb, 2018 2 commits
  3. 23 Feb, 2018 3 commits
  5. 21 Feb, 2018 1 commit
  7. 16 Feb, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1734178: allow user to delete own account · 9837f182
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      added settings

- institution level: reviewselfdeletion
    0 if the institution does not require approval
      from an admin to delete an account
    1 if the institution requires an admin to approve
      account deletion requests from users
    if not set, it takes the value from the site's
    default

- site level: defaultreviewselfdeletion
  (Site options->User Settings -> Review account before self-deletion)
    1 if the site's default is requiring approval
    null otherwise

Account deletion by a user

when a user accesses to the account settings, a
'Delete account' button is displayed.

This will:
- If the user belongs to an institution that requires
  approval (or does not have the settings but the site
  requires approval by default)
    then a notification will be sent to the admins
    of the institutions that require approval that
    the user belongs to
- if the user belongs to institutions and none of them
  require approval (or does not have the setting
  but the site does not require approval by default)
    then the account is deleted
- if the user does not belong to any institution
    then the action will depend on the setting of
    the 'mahara' institution or sites default if
    'mahara' doesn't have the setting

Approval by institution admins

An institution admin can see the pending deletion
requests in Admin menu-> Institution -> Pending deletions
After approving/denying a request, the user
that requested the account deletion will receive
a notification

behatnotneeded
Change-Id: I4ccd9c798cab065ec557eaddf7dfc3a51920b6d0
      9837f182
  9. 13 Dec, 2017 1 commit
  11. 16 Nov, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1572825: added Voki html filter for embed code · 207889a5
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c
      207889a5
  13. 09 Nov, 2017 1 commit
  15. 01 Nov, 2017 1 commit
  17. 24 Oct, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1724797: Creating status headers for SmartEvidence matrix · 1736df85
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      - Make all counts for assessment statuses available in the evidence
  matrix page.
- Select in the site administration area, which statuses you want to make
  available for a particular standard.

Sponsored by: PH Bern for SWITCHportfolio
behatnotneeded

Change-Id: I815e9de6c02b3f503e637c01d0083519b95f09a3
      1736df85
  19. 16 Oct, 2017 1 commit
  21. 12 Oct, 2017 2 commits
    • Cecilia Vela Gurovic's avatar
      Bug 1721623: added plugin's css to be controlled by sass · 80c4b140
      Cecilia Vela Gurovic authored 
      For both raw and raw_old

Not moving files that are only used for styling
html exported static page:

theme/raw/plugintype/export/html/style/style.css
theme/raw/plugintype/export/html/style/print.css

theme/raw/plugintype/artefact/internal/export/html/style/style.css
	used only in exported static page:
	<path-to-static-page>/files/internal/index.html

theme/raw/plugintype/artefact/resume/export/html/style/style.css
	used only in exported static page:
	<path-to-static-page>/files/resume/index.html

the same for raw_old

Change-Id: Ief02aaee3bd86a30c6cae529953500a3a36ca8c9
behatnotneeded: styles
      80c4b140
    • Kristina Hoeppner's avatar
      Bug 1692385: Update lang strings & add help files · 814cbd40
      Kristina Hoeppner authored and Robert Lyon's avatar Robert Lyon committed 
      Update a number of language strings that were either
missing or in the wrong place.

Added help files for the "User activity" report columns.

behatnotneeded

Change-Id: If0758649b749451827eb6f9b426c410776b9c5bb
      814cbd40
  23. 06 Oct, 2017 1 commit
  25. 28 Sep, 2017 2 commits
  27. 27 Sep, 2017 1 commit
  29. 20 Sep, 2017 1 commit
  31. 09 Sep, 2017 4 commits
    • Robert Lyon's avatar
      Bug 1697248: More updates for report navigation and reports · c3d9acba
      Robert Lyon authored 
      

This patch will contain the fixes for:

- Navigation placement
- Collaboration report
- CSV's of reports
- Overview page for the graphs
- Making Institution selector a select2 field
- Moving all configs for reports into the modal and combine 3rd level
menu with submenu choices in select2 field
- Ignore non logged in users from user activity report
- Move more variables for reports into sticky (session) vars
- Allow results to be fetched from elasticsearch

Change-Id: I725b7615ac3cd6b1d9b6352bae9f6be0d5161e1b
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      c3d9acba
    • Robert Lyon's avatar
      Bug 1697248: Update report navigation and reports · 8c08b88b
      Robert Lyon authored 
      

Introduce a new navigation bar to allow going through the different
types of reports:

- Change the page title according to the selected report section and
  report
- Decide which columns to display in a report
- Configure reports via the "Configure reports" button

Add existing reports into the new interface.

Create new and expand existing reports:

- User activity
- Page activity
- Collaboration

Sponsored by the AAIM project with funding from University of
Sussex and Dublin City University.

Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      8c08b88b
    • Robert Lyon's avatar
      Bug 1710710: Placement of public search box vs language selector · 408dcdfb
      Robert Lyon authored 
      

When we have $cfg->publicsearchallowed = true;
and are viewing the site when logged out and have langpacks installed
we get an overlap of the language selector and searc box.

When we don't have langpacks installed the search box doesn't align to
the right.

This patch tries to align things up correctly

behatnotneeded

Change-Id: I6f2175af0aa9e164f4c4302f4c1e7012423d1235
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      408dcdfb
    • Robert Lyon's avatar
      Bug 1694171: Fixing up outstanding issues for v5.0 · 1bbc75e1
      Robert Lyon authored 
      

This patch will sit above Geralds one to sort out last minute things
including:

- upgrade compatibility
-- Will need to compare current elasticsearch version with compatible
version and alert about problems
-- Will allow one to set the shards/replicas as part of config
-- alert the cluster health (non green) status and unallocated replica
shards

- Allow empty search query to return all related results
- Allow collections to record / search on collection tags
- Index group access correctly
- Get correct results to display for each tab rather than all results
bunched together
- Allow highlight on description field

- Add a basic behat test
- removed the built in docs/ and tests/ dirs as well as the phpunit
test files

Change-Id: I09b4eaf502a8400499debde2ff1d2a5316f20fbf
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      1bbc75e1
  33. 10 Jul, 2017 1 commit
  35. 08 Jul, 2017 1 commit
  37. 29 Jun, 2017 3 commits
  39. 27 Jun, 2017 1 commit
  41. 11 Jun, 2017 1 commit
  43. 09 Jun, 2017 1 commit
    • Pat Kira's avatar
      Bug 1689975 - Fixed help icon position on radio button group · 56af966d
      Pat Kira authored 
      - Changed label and wrapper display so the help icon is positioned next
  to radio input group
- Ensured that help icon is next to input field on smaller screen

Change-Id: I4a36ba5523ebceb3fbc736578886d452b62b9133
behatnotneeded: styling only
      56af966d
  45. 06 Jun, 2017 1 commit
  47. 02 Jun, 2017 1 commit
  49. 25 May, 2017 1 commit
    • Pat Kira's avatar
      Bug 1686539 - Fixed pages/collection collection list being cut off · d0805a4f
      Pat Kira authored 
      Added a class to page and collection panels so we can use CSS to select
every second item on smaller screen and 4th item on larger screen then
set collection list and page access dropdown to right align.
Other collection list and page access dropdowns are left align.

Change-Id: If09e7e9d66dc727ee334dc3f9f4311e6a45716e9
behatnotneeded: styling only
      d0805a4f
  51. 15 May, 2017 1 commit
  53. 07 May, 2017 1 commit
  55. 26 Apr, 2017 1 commit
    • Pat Kira's avatar
      Bug 1686259 Refactor pages and collection template and styles · c9cee415
      Pat Kira authored and Robert Lyon's avatar Robert Lyon committed 
      - For both raw and old raw
- Remove extra conditions for adding class
- Remove unused css selectors
- Rename classes for clarity
- Move styles to one file; _panel-quarter.scss
- Consolidate elements and class for maintainability

behatnotneeded

Change-Id: I1e499e697013a16fcfac2b9a73772944619680a4
      c9cee415
  57. 20 Apr, 2017 1 commit
    • Pat Kira's avatar
      Bug 1681579 - Added svg support for mahara logo · 4078c8d5
      Pat Kira authored and Robert Lyon's avatar Robert Lyon committed 
      - Make svg of supported extension.
- Add svg versions of Mahara logo to all core themes including footer
  logo.
- Tidied up upgrade footer styles and templates as well as using
  theme_image_url instead of image path with specific file extension.

Note 1: We are not removing exisiting png version of both logos just
in case someone needs it or want to use it.

Fixed configurable custom logo display
- Check if there is a custom logo if so add to data attribute on the
  template.
- Add a check in js if there's custom logo we won't replace the logo

Note 2: Displaying correct version of Mahara logo based on header
background could be done at the backend (PHP) since the background value
stored in the database (I think).

behatnotneeded

Change-Id: I377401a9477e3b06e9fcee366579bbfc09bc73ea
      4078c8d5
  59. 18 Apr, 2017 1 commit