GitLab

Ends up with username in auth_remote_user being different to the
username in usr table.

behatnotneeded

Change-Id: If6a5a18360ef82da2e3a709899e7d4d1624e8fab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit dc3b3292)

Go from child to parent to grandparent etc.

behatnotneeded

Change-Id: If30d63483f33a50888a590875ddd979d6900c613
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 24407640)

By adding a cancel option to the register site form that clears the
new_registration_policy config setting.

behatnotneeded

Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Testing requires multiple simultaneous users

Change-Id: Icfac83b0ac9ed6ab0c304658550dd0260bd5d7eb
(cherry picked from commit 0eea42ce)

Bug 1496910

behatnotneeded: Has only a visual impact, can't be tested by Behat

Change-Id: I2b531c92ed46ad3b364206161ff6851314749573
(cherry picked from commit caa62e2e)

When the keys are integers

behatnotneeded

Change-Id: I7904f4225e8cf17e2ecd6b54d1fcdbeb7c2b7c77
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Can't behat test CLI scripts

Change-Id: Ic83251491c745bb4375d40510139365a5e004800
(cherry picked from commit 40620910)

Change-Id: Ia70b5c70463bdc409957840b4c04c9a5b3782473

Change-Id: I9292ace11ef78ffab001b82c5f5c480c3a673ebb

Change-Id: I13410ac2494ac8d4891e7a10715467e50ed74ff3

Change-Id: I9ac0135e65452ea60f0a7bf8b5821846230db0e9

The old code passes every value from the form into email_user(), which
has wound up causing problems because email_user() thinks $user->id
refers to the user's ID, but in our case id refers to the usr_registration
record. (There is no user created yet at this point)

behatnotneeded: No infrastructure to test email yet

Change-Id: I0d862c2d1b2fdba5d5a1dc0068ce594207ecace9
(cherry picked from commit 91cc873f)

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

behatnotneeded

Change-Id: I3b0dae6cfb1ebd3af3df5d69eaf252e9299855a0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- Display the registration site page after upgrading
- Show the register box in the admin index page for reminding
- Show data sent after successful registeration

Change-Id: I0b950957a8d451593fd29de5088aac56c6cf5b60

Merge "Bug 1383543: script multirecipientnotification/js/sendmessage.js is redundant" into 1.10_STABLE

I had used the script in the first patches for the new plugin but it got
obsolete when I changed the recipients list to be rendered with the
autocomplete box

Change-Id: Ied74b0cefbaae91fdcb4c9f99420c0f96a433500
Signed-off-by: Tobias Zeuch <tobias.zeuch@rwth-aachen.de>

behatnotneeded: Requires doctoring requests, which Behat can't currently do

Change-Id: I619ab2cf768a4621a77026ed172c01b1c484a99e

Bug 1447865

Change-Id: Ia4b09ff1bf379421f1fc1b77de07d86353569452
(cherry picked from commit 5fa788c0)

Change-Id: I38b6d9f09e13baa4dde1177d8b8d81a722ed7a82
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1464052: Giving it a default of 50000 instead of unlimited.

Change-Id: I30210d3416d70d96bec40ebb578c5302e07ff63f
(cherry picked from commit 0b1d3d68)

When updating the artefact table with new 'path' option

Change-Id: I6f236f53e907cb4f686c8973c9a98502fc0186ed
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Postgres works slightly differently to mysql with the
update .. limit command

behatnotneeded: as this is an upgrde problem

Change-Id: I6ae18e545d9e3ba56ca3a258b02038b3759ea178
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Mostly for Mysql's benefit but won't hurt postgres to do it this way
as well

Change-Id: Icada6c3945db15279d93c30973eaad7bc2507b13
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Id5b2a01d1ac240cdb271bfc952c41691a4bc4287
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Also, displaying the pages in name order during import.

behatnotneeded: Can't test export & re-import of Leap2a files in Behat yet.

Change-Id: Ib387e574356d9d894b9a6f284b09921a5b26d5fc
(cherry picked from commit c10418a1)

Need to have $SESSION available to be able to send error to it

behatnotneeded

Change-Id: Ie298c95a8ef9a4fdc5589a6934110fc86c1e771d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7b212c53)

Bug 1480038 - When the registerallowed is turned off - this is wrong

Change-Id: Ib511a1c372a15cddd9fd7329cfa93cc72dac412f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The group tab in admin section when dropdown navigation was off had a
split in the button when selected due to the 2nd span in markup for that
tab.

The css fix ignores the 2nd span.

Change-Id: I28fd63d929dbfc9f4d7c27bfb8c2d0b46ff00efc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There was a problem with group update where the group quota data was not
getting updated when uploading a file due to caching.

Change-Id: I96ee13b39d815c126f3ff1689f413eb20b0f1c76
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I24d34159e337d7ece6d003b1c42cda01a0fe4e80
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1333424

Change-Id: I6ab58a154513fbe3185be91f251c5c1aa213a7a1
(cherry picked from commit 3658fa88)

Bug 1464477

Change-Id: I016d35f35406f4b1c7bcb298ae2966f1d37fed05
(cherry picked from commit e7779d20)

While the IDs for the radio buttons are of the form "decision_X_X", we're
looking at their names here, not IDs. And the names are just "decision_X".

Change-Id: Id7e0ec1df62cca6cae261b9b7eda9fbe3dbf9431
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>
(cherry picked from commit a61c66ed)