Skip to content
GitLab
Switch branch/tag
  1. 20 Apr, 2016 1 commit
  3. 18 Apr, 2016 2 commits
  5. 15 Apr, 2016 1 commit
  7. 14 Apr, 2016 1 commit
  9. 13 Apr, 2016 1 commit
  11. 07 Apr, 2016 1 commit
  13. 04 Apr, 2016 2 commits
  15. 31 Mar, 2016 7 commits
  17. 29 Mar, 2016 2 commits
    • Robert Lyon's avatar
      Bug 1512147: Allow tag pieform element hook into autocomplete one · 333ccbd6
      Robert Lyon authored 
      

The 'tag' pieform element will now become a wrapper for the
autocomplete one - rather than using the 'autocomplete' element
directly - so that we can centeralise how the tags field is generated and
avoid having to duplicate setup code.

Todo: need to get the select2 behat test to do ajax search

Change-Id: I795969f2411ed5a088103398460e6ac135015319
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      333ccbd6
    • Robert Lyon's avatar
      Bug 1316917: New approach to star rating using bootstrap glyphs · d1bf622a
      Robert Lyon authored 
      

This is a slimmer / stripped down system for doing jquery ratings.

Instead of relying on styling radio buttons it relies on bootstrap
glyphs and a hidden input field.

The code is also controlled by a pieform element

See lib/form/elements/ratings.php for more info about that part

It also has some new settings in the Extensions -> artefact -> comment
config form. They include settign the colour for the star icon, or
using a different icon, eg hearts/thumbs up, and the number of ratings
to show (3 - 12)

behatnotneeded

Change-Id: Ibf529efcb9a665c9f303242ed12d0c7b3dee2356
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      d1bf622a
  19. 23 Mar, 2016 4 commits
  21. 22 Mar, 2016 3 commits
  23. 21 Mar, 2016 2 commits
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored 
      

As they are set to TITLE we can just assign TITLE to PAGEHEADING in
the smarty function call.

We can later override the PAGEHRADING with
$smarty->assign('PAGEHEADING', string); if we need to.

Have also updated a few files where TITLE was not defined.

behatnotneeded - everything should work as before

Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
    • Robert Lyon's avatar
      Bug 1539262: Making constant SUBSECTIONHEADING · 4d6abc2b
      Robert Lyon authored 
      

To make this similar to PAGEHEADING / TITLE for consistency

This allows the for it to display when an AccessDeniedException is
thrown.

Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
the wrong order.

behatnotneeded - existing tests should be fine

Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4d6abc2b
  25. 20 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1544381: Need to move get_homepage_url() out of template · 3df10959
      Robert Lyon authored 
      

Because if we have a latest pages block but no group pages listed then
the template will not initially compile as there has been no call to
require lib/group.php

Actually we should avoid having non basic function calls in the template
so I'll move all instances of group_homepage_url() in templates out
to the php that generates the data.

behatnotneeded

Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      3df10959
  27. 18 Mar, 2016 1 commit
  29. 17 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1537912: Allow the 'login' link to show when sidebars exist · 51910ec5
      Robert Lyon authored 
      

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      51910ec5
  31. 16 Mar, 2016 1 commit
  33. 13 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1545380: Profile images on user list broken for staff · b5bf4d5d
      Robert Lyon authored and Kristina Hoeppner's avatar Kristina Hoeppner committed 
      

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      b5bf4d5d
  35. 08 Mar, 2016 1 commit
  37. 07 Mar, 2016 1 commit
    • Aaron Wells's avatar
      "Tagged journal entries" block shouldn't grant access to whole journal · ada12dba
      Aaron Wells authored and Robert Lyon's avatar Robert Lyon committed 
      Bug 1521818. Making the "Tagged journal entries" block act more like
a collection of "Journal entry" blocks. So, it doesn't add the parent
blog to view_artefacts, only the specific blog entries that are
displayed in the block.

Also removing the title of the parent blog (and the link to it) from
the list of blog entries, like the "Journal entry" block, which
doesn't display the title of the containing journal.

Note the viewer may still have access to the whole blog, if the blog
is also shared on the same page via a "blog" or "recent journal entries"
block.

Change-Id: I33fc7e58b964c03bc8003f1de81a4bf58b6079b7
      ada12dba
  39. 02 Mar, 2016 3 commits
  41. 01 Mar, 2016 2 commits
  43. 29 Feb, 2016 1 commit