Skip to content
GitLab
Switch branch/tag
  1. 20 Apr, 2016 1 commit
  3. 31 Mar, 2016 2 commits
  5. 29 Mar, 2016 2 commits
    • Robert Lyon's avatar
      Bug 1512147: Allow tag pieform element hook into autocomplete one · 333ccbd6
      Robert Lyon authored 
      

The 'tag' pieform element will now become a wrapper for the
autocomplete one - rather than using the 'autocomplete' element
directly - so that we can centeralise how the tags field is generated and
avoid having to duplicate setup code.

Todo: need to get the select2 behat test to do ajax search

Change-Id: I795969f2411ed5a088103398460e6ac135015319
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      333ccbd6
    • Robert Lyon's avatar
      Bug 1316917: New approach to star rating using bootstrap glyphs · d1bf622a
      Robert Lyon authored 
      

This is a slimmer / stripped down system for doing jquery ratings.

Instead of relying on styling radio buttons it relies on bootstrap
glyphs and a hidden input field.

The code is also controlled by a pieform element

See lib/form/elements/ratings.php for more info about that part

It also has some new settings in the Extensions -> artefact -> comment
config form. They include settign the colour for the star icon, or
using a different icon, eg hearts/thumbs up, and the number of ratings
to show (3 - 12)

behatnotneeded

Change-Id: Ibf529efcb9a665c9f303242ed12d0c7b3dee2356
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      d1bf622a
  7. 23 Mar, 2016 3 commits
  9. 22 Mar, 2016 2 commits
  11. 21 Mar, 2016 2 commits
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored 
      

As they are set to TITLE we can just assign TITLE to PAGEHEADING in
the smarty function call.

We can later override the PAGEHRADING with
$smarty->assign('PAGEHEADING', string); if we need to.

Have also updated a few files where TITLE was not defined.

behatnotneeded - everything should work as before

Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
    • Robert Lyon's avatar
      Bug 1539262: Making constant SUBSECTIONHEADING · 4d6abc2b
      Robert Lyon authored 
      

To make this similar to PAGEHEADING / TITLE for consistency

This allows the for it to display when an AccessDeniedException is
thrown.

Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
the wrong order.

behatnotneeded - existing tests should be fine

Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4d6abc2b
  13. 20 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1544381: Need to move get_homepage_url() out of template · 3df10959
      Robert Lyon authored 
      

Because if we have a latest pages block but no group pages listed then
the template will not initially compile as there has been no call to
require lib/group.php

Actually we should avoid having non basic function calls in the template
so I'll move all instances of group_homepage_url() in templates out
to the php that generates the data.

behatnotneeded

Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      3df10959
  15. 18 Mar, 2016 1 commit
  17. 17 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1537912: Allow the 'login' link to show when sidebars exist · 51910ec5
      Robert Lyon authored 
      

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      51910ec5
  19. 13 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1545380: Profile images on user list broken for staff · b5bf4d5d
      Robert Lyon authored and Kristina Hoeppner's avatar Kristina Hoeppner committed 
      

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      b5bf4d5d
  21. 08 Mar, 2016 1 commit
  23. 02 Mar, 2016 2 commits
  25. 01 Mar, 2016 1 commit
  27. 29 Feb, 2016 1 commit
  29. 28 Feb, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1544424: Only load block.js when it's actually needed · 172d0e95
      Aaron Wells authored and Robert Lyon's avatar Robert Lyon committed 
      This prevents an infinite loop caused by an error in a ajax block
causing error.tpl to be rendered, which causes block.js to get loaded,
which causes a new ajax request for all the ajax blocks, which causes
error.tpl to be rendered, etc.

Also moving this JS file out of the theme directory and into the /js
directory, because it's core, not theme.

behatnotneeded: Can't test error state via Behat

Change-Id: Idc83002dbf5cb8af36d9d33e916da2bdfa5a308f
      172d0e95
  31. 24 Feb, 2016 1 commit
  33. 19 Feb, 2016 1 commit
  35. 08 Feb, 2016 1 commit
  37. 03 Feb, 2016 2 commits
  39. 02 Feb, 2016 1 commit
  41. 01 Feb, 2016 4 commits
  43. 26 Jan, 2016 1 commit
    • Liam Sharpe's avatar
      Styled the participation report page - Bug #1529713 · f86ac830
      Liam Sharpe authored 
      NOTE: Does not include the fix for:
"2. All columns should be sortable, but it doesn't
work properly for me. I could only get the first column
under "Pages shared with this group" to sort and that
sorted also "Pages owned by this group"."

behatnotneeded

Change-Id: If043d94dab3d52fea7c8d1e70910d6e5bd45a41b
      f86ac830
  45. 25 Jan, 2016 1 commit
  47. 20 Jan, 2016 2 commits
  49. 08 Jan, 2016 1 commit
  51. 29 Dec, 2015 1 commit
  53. 16 Dec, 2015 2 commits