1. 20 Oct, 2016 1 commit
  2. 19 Oct, 2016 1 commit
  3. 18 Oct, 2016 4 commits
  4. 04 Oct, 2016 1 commit
  5. 21 Sep, 2016 1 commit
  6. 12 Sep, 2016 1 commit
  7. 08 Sep, 2016 1 commit
  8. 30 Aug, 2016 1 commit
  9. 25 Aug, 2016 2 commits
    • Aaron Wells's avatar
      CLI upgrader, better handling of out-of-sequence plugin upgrades · af5e7ae3
      Aaron Wells authored
      Bug 1614805. When a plugin is installed "out of sequence" by a
      call to plugin_upgrade in the core lib/db/upgrade.php file, the
      AJAX-based web upgrader handles it gracefully, because it does
      check_upgrade() before upgrading each plugin, detects the change
      in status, and doesn't run the upgrade for that plugin a second
      time.
      
      The CLI upgrader, on the other hand, uses the same cached data
      from check_upgrades() all the way through, causing it to re-run
      upgrades for such plugins.
      
      This patch makes it behave the same as the AJAX plugin, running
      check_upgrade() again immediately before each component gets
      upgraded. This does cause some redundancy in code execution,
      but it shouldn't be enough to cause a noticeable performance hit.
      
      Change-Id: Id5c431fc9e636df2cab05d22e6cc424271ce9f3d
      behatnotneeded: Covered by existing tests
      (cherry picked from commit 0e1704c1)
      af5e7ae3
    • Robert Lyon's avatar
      Bug 1594642: Problem where global $sessionpath not set · 5455e881
      Robert Lyon authored
      
      
      When I tried closing my site I got DirectoryIterator error
      
      behatnotneeded - the patch 6609 will test this
      
      Change-Id: I35024f8e6a558ee9d009e7c2754a0026e8042b2f
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      (cherry picked from commit 4a4ba694)
      5455e881
  10. 22 Aug, 2016 1 commit
  11. 21 Aug, 2016 1 commit
  12. 14 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1612451: Graceful handling of invalid embedded artefact id · 2327631a
      Aaron Wells authored
      Adds a try/catch block so that the code doesn't crash if
      you've put in an invalid image ID in an embedded image tag.
      Also tweaks the embed code so that it will skip invalid
      images but continue processing the rest of the text block.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I573adc7d29a0c1a4289f1b0a0b402d308a739be9
      (cherry picked from commit f7470234)
      2327631a
  13. 11 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1611995: Remove redundant file · b2049df3
      Aaron Wells authored
      This file was accidentally left in place when profileicons
      were moved from internal artefacts to file artefacts. It's
      now redundant with artefact/file/profileicons.json.php
      
      Change-Id: I544cda768e636a0076595ed64f49425fe1607e41
      behatnotneeded: Covered by existing tests
      (cherry picked from commit 9d7a9302)
      b2049df3
  14. 08 Aug, 2016 7 commits
  15. 04 Aug, 2016 1 commit
  16. 03 Aug, 2016 1 commit
  17. 02 Aug, 2016 7 commits
  18. 01 Aug, 2016 6 commits
    • Robert Lyon's avatar
    • Robert Lyon's avatar
      Merge "bug#1607669: Validate the results of ldap_search() and ldap_list() when... · 1c229ae8
      Robert Lyon authored
      Merge "bug#1607669: Validate the results of ldap_search() and ldap_list() when syncing users." into 15.04_STABLE
      1c229ae8
    • Aaron Wells's avatar
      Bug 1605127: Method signature mismatch in Activity::update_url() · 3b1580d9
      Aaron Wells authored
      The abstract Activity class defines the function update_url()
      with no parameters, but the two subclasses that override it
      define it with one parameter. This will cause problems in PHP 7.
      
      It's always called with one parameter, (even in the Activity
      class itself) so the best option is to add one parameter to the
      implementation in Activity.
      
      Change-Id: I810061ed6f8c55101327e2e907bb68ebf9870380
      behatnotneeded: Covered by existing tests
      (cherry picked from commit b469030b)
      3b1580d9
    • Ghada El-Zoghbi's avatar
      Bug 1606101: usr.suspendedcusr must be non-zero · 1b577978
      Ghada El-Zoghbi authored
      It turns out a lot of existing code checks the boolean
      value of usr.suspendedcusr to determine if a user should
      be treated as suspended or not. The LDAP sync cron (and,
      indeed, any code suspending users via a cron task) was
      setting usr.suspendedcusr to 0, which is boolean false,
      so these users would be treated as not suspended.
      
      We are going to update all usr.suspendedcusr = 0
      to a valid site admin ID.
      
      Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234
      behatnotneeded: Test to come later
      1b577978
    • Ghada El-Zoghbi's avatar
      bug#1607669: Validate the results of ldap_search() and ldap_list() when syncing users. · fb75f139
      Ghada El-Zoghbi authored
      When retrieving data from the LDAP server, check the results retrieved from
      ldap_search() and ldap_list(). If there is an error, do not continue.
      
      Otherwise, the sync_users() will assume that zero users were retrieved
      from LDAP. It will then deleted or suspended users when
      'If a user is no longer present in LDAP' is set to either suspend
      users or delete them.
      
      behatnotneeded
      
      Change-Id: Ib57901c61f769d96720cf932d2e0d7f643853a56
      (cherry picked from commit 1daee33a)
      fb75f139
    • Ghada El-Zoghbi's avatar
      bug#1605067: improve accessibility by adding text placeholders for: · 2c6ae585
      Ghada El-Zoghbi authored
      1. search text at the top menu
      2. search text for users
      3. search text for elasticsearch
      4. search text for institutions
      
      Thus, eliminating the need for the emptyonfocus class and its
      related jquery code to hide the default text.
      
      behatnotneeded
      
      Change-Id: I57b9fcac4f9fd758b7048b8567101f28dcc48cff
      (cherry picked from commit d48226c7)
      2c6ae585
  19. 14 Jul, 2016 1 commit
    • Aaron Wells's avatar
      Fixing issues in embedded images in copied pages · ffac44d1
      Aaron Wells authored
      Bug 1489274
      - DB upgrade to fill in artefact_file_embedded records for
      existing blog entries
      - Improving the regex that rewrites links in copied journal
      entries, notes, and text blocks
      
      behatnotneeded: Requires upgrading the site; not testable via Behat
      
      Change-Id: Ie5d5dc12065ed039df663910e5ee738d57377a91
      ffac44d1