Change-Id: I2a2ba2a54de22fb82c36ffd8ca807f7e237ceff1
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

When fetching & evaluating js files using getScript, there's a time
delay, so it's better to pass initialisation js for each block as
a callback to getScript, otherwise the js from the file is not always
loaded in time.

Change-Id: I819f911acb2a729f4cf3c52b06a285a793ba819f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Commit 9496078b

 overwrote the $js variable in build_configure_form,
losing any inline javascript from the form's elements.

Change-Id: I541d510134b238789fbcea88512ed12889a2e7ab
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

The test for whether a blocktype plugin's js file was internal (and
needed a wwwroot added) is case sensitive, and ignored https.

Change-Id: Idc81123d0367df739a698ab688b4d4a59e023da0
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When a plans block is first added to the page, the javascript overlay of
the task titles was not evaluated.  This is fixed by moving javascript
functions for the plans block into a new javascript file and pulling the
script onto the page with the same method used by the configuration form
javascript.  A new get_instance_inline_javascript method is added to
initialise the block when it's first configured.

Change-Id: I148a1e8a667c26fe58b3f915768ada4743718c5b
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Moving this code into its own function will allow it to be used for
block instance rendering javascript as well as the configuration form.

Change-Id: I42dba8425a8455aaa9faae19d50414e33c5988db
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Iab7aac11915b19d0c3e306949513dfc90e6a82c6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Trying to access blocktype/wall/deletepost.php with a bad wallpost id
creates a new empty View object, and attempts to commit it to the db
when the View destructor is called.  This fails with an sql error, and
then a PHP Fatal error.

Change-Id: I7e462cc4ea6cda0611e432336839d153bbd0a42e
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When creating a new BlockInstance object for a view, pass the view
object to the BlockInstance constructor when we already have it
handy.  This stops the BlockInstance from having to pull the view
out of the database again in its get_view method, and can save
several queries when rendering a view.

Change-Id: I717f154031794afec1ca0d353c1d358f297c5c1e
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Some more changes were necessary. It's the same
file as for review 760 for Mahara 1.4

Change-Id: I0ee9d521b619f9afc3e8038122f00f4b0b0cfeff
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Google keeps spitting out different urls to their users. Our users
aren't going to understand how to massage these to the correct
format, so we have to try keep up. Bad google, bad.

Change-Id: I06901c142da5db179ef5361d9939ae9a03ead14e
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Some people already see the new Google documents interface.
The help file is updated to reflect the changes in selecting
the "Publish on the web" link. A few other small changes have
been made to update the workflow.

Change-Id: I167c71c54b1bfdf37a2e6f423408f0590445d499
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Change-Id: I345a21118902ed10cd6ccec73c543dc24af42708
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #597479

Blocktype plugin that allows the user to select a tag, which then
displays: all blog posts, from all blogs, owned by this user, tagged
with the selected tag.
Update: moved from main blocktype area to artefact/blog/blocktype

Change-Id: I28ddeb7181188c1441c7a6fb55aa3200192fe112
Signed-off-by: Chris Wharton <chrisw@catalyst.net.nz>

This adds a new regex that catches the new format. Addendum
to 8c1316f3

 in which "id=" changed
to "key=", this patch covers spreadsheets where google has now
changed the url from "/pub." to "/ccc."

Change-Id: Id2c013257ae801e251b8b8cd9fb1fcc10a7c933b
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

This is needed to avoid mixed secure and insecure content on the
views that use this block.

Bug #853647

Change-Id: I45b851b393ae4b3f9a44c2abc10019c673cd12cd
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Allow users to override certificate errors when adding an external
feed to a view.

This new option is turned OFF by default.

Bug #849831

Change-Id: I0e7baab0994bf5f27a6ad7fc5089dfc1b583d87c
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

These new per-block options allow the use of authenticated (through
HTTP basic auth) feeds in Mahara.

Thanks to Darren James Harkness for the initial patch.

Change-Id: I8c916c31698ae3b32dd826d14fd475cbbad61b02
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: I935c40be12aeab914f64a60b18b579dd2140ca23
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #697837

Added a database entry to blocks to enable reordering of tabs.
This sort field can be used as a weighting but must be unique.
other tabbed structures should also have a field as such to allow
admins to change the order on the fly.

Patch by Sean Brennan, cleaned and rebased by Hugh Davenport

Change-Id: I269d3f00288b5470b8e612a54527ae7f22aa747c
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This set of changes attempts to handle missing plugins in a better fashion.
Rather than throwing an uncaught error which causes a unrecoverable site
error, which in turn means that no user can use any other plugin; this
patch disables the problem plugin and informs administrators of the issue.

To handle the case where core plugins, which under normal circumstances
cannot be disabled, are missing and disabled; the plugins.tpl template is
also changed to test for the contents of the activateform, instead of
whether the plugin can ordinarily be disabled. This means that if the issue
is then fixed, the plugin can once again be re-enabled, at which point the
[ hide ] link will no longer appear.

Change-Id: I6f9fa73ae0ac307b5f5f8f30b8205690926f54fc
Signed-off-by: Andrew Robert Nicols <andrew.nicols@luns.net.uk>

When the logged-in user can't get to the member listing for a group
(bug #845287, bug #504830), it seems like a good idea to also hide
the number of members.

Member counts are hidden in the group info block and copy a view page
by moving member & view counting into the group_get_groupinfo_data
function, and performing the permission check in one place for both
pages.

Member counts are hidden on My Groups and Find Groups inside the
group_prepare_usergroups_for_display function.

Change-Id: Ibe5675861040cedf67c2ddff7647117cd155722a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This creates groups in which members can't search for each other.
Group admins can get to the member listing, but tutors cannot: the
stated use case is anonymous reviewer groups.

Change-Id: Id2550e574b55ceeb43958475340e967de16850f1
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Site & institutional admins & staff can check a 'hide membership'
checkbox on the edit group page.  Non-members cannot access the
membership lists of these groups, and when they view the group,
both the members block and members tab are hidden.  Site admins
and staff can still access the members page directly.

Also filters the my friends block by changing that block to use
group_get_user_groups rather than group_get_associated_groups.

See http://mahara.org/interaction/forum/topic.php?id=2229



Change-Id: Iaa907484c5d395cdf3869565fcf1c47c2faec733
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These two pages both display the same data, so it makes sense to
fetch it in a single function.  This also reduces the number of
display_name queries and thumb.php requests for group admins.

Change-Id: Ie10caa60d560337fe0302690e629d1ac8196db6f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

It seems that the google spreadsheets published url changed and was
not being caught by the existing regexs. This adds a new regex that
catches the new format.

Change-Id: Ic51ae17a789f2f97647796d9a4daa5d13d2d0108
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

This was introduced in commit 118084a6



The original code presumed that the the data was an object, but was infact
an array. This patch changes it to array access's instead of object deref's.

Bug #800373

Change-Id: I4a70eef6c5fec9c1cf8174f78a96e31df29bfd4f
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Bug #794460

A basic block that shows a list of views currently on a users watchlist.
Allows click-through to the view itself, where the user can remove the
view from their watchlist.

This block could be extended with a "Remove from Watchlist" button on
the block itself, and/or an inbox style paginated list.

Change-Id: Iec98314c1c22daec919290cfaaf0f02cced7100a
Signed-off-by: Chris Wharton <chrisw@catalyst.net.nz>

The removal of the leading / has caused this to trip the
exception at line 2421 of htcdocs/lib/web.php
(https://gitorious.org/mahara/mahara/blobs/master/htdocs/lib/web.php#line2421)
which gets triggered when javascript is not enabled. This change
preceded the general redirect changes, as well as the usage of gerrit.
It appears to not have been made to fix anything in particular, so it's
being reverted to fix the issue at hand.

This reverts commit 6415c6bf

.
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>
Change-Id: Ia511efeb14dad2771801593771ca6c406c751799

As per Francois' comment in the bug
https://bugs.launchpad.net/mahara/+bug/829674/comments/1



Change-Id: I03d99dbc93ea57d16240d0904c6bd670534f82b5
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

View submission was previously enabled on all (and only) course
grouptype groups (those groups with tutors).  After this change
view submission can be turned on and off on any group, and if a
group has no tutors (standard grouptype), then only the group
admins will be allowed to assess submitted views.

Change-Id: I6df7f9dfc1b9fadbe39887ead4c1aa5c7a9eaed6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #809058

If the site is running https, embed external videos and google apps
over https where possible.

Change-Id: Id1d4b66c1f04587d4864126c2e58d2167e45fe70
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Change-Id: Ie48b79e048fd34f2c167eac5ab3b9310e1e747e8
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Ie2f748214146d86caf53a82a167ea2d86e8a4fb6
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

If an exception is thrown in a blocktype plugin's instance_config_save
function, display an error on screen rather than dying silently with the
'loading...' box still visible.

Change-Id: I7242d47b53a279714e8d4fc3502518eefd207f73
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

A blocktype plugin's get_instance_config_javascript method is
expected to return an array of urls to javascript files.  With
this change, if the method returns a string rather than an array,
it will be added to the configuration form as inline javascript.

Change-Id: Icc3b669d2d3358c64c5abd3ed5c965f296a6d113
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When a block is saved after configuration, the view editor currently
only rerenders the newly configured block.  This change allows a
blocktype's instance_config_save function to return a list of other
blocks on the page that should be rerendered in addition to the newly
configured block.

This will provide a mechanism for *all* the textbox blocks on a page
which contain a particular html artefact to be updated when the text
of one of those blocks is updated (see bug #736665).

Change-Id: Ic68f21bb8f46b79c5d9ed8e32504314dcc067429
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When a text box block is saved, a new html artefact is created,
or an existing html artefact updated.  The 'Block content'
field from the form is saved into the description field of the
artefact, and the artefact title is overwritten with the block
title.

This patch includes an upgrade to convert the contents of all
existing textboxes on the site to html artefacts.

Change-Id: I321735de5c0e4dc5768222f02c8e7e1bc716c237
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This allows the blocktype plugin's instance_config_store function
to access the block instance object.

Change-Id: Ib2492fb9847096abab5d25032db6f7656ff47833
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Because text boxes will create and display html artefacts, they should
really live inside the internal artefact plugin.

Contains a couple of whitespace/coding style fixes to ensure that new
lines from the copied files pass the minaccept test.

Change-Id: I9520f1d32eaaa7735b168f35ccc6af37e8c9e2c6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>