Skip to content
GitLab
Switch branch/tag
  1. 15 Jun, 2015 7 commits
  3. 03 Jun, 2015 1 commit
    • Robert Lyon's avatar
      Lazy-load list of textboxes when opening textbox form (Bug 1393734). · 0a1e5e0e
      Robert Lyon authored 
      

The query to load other textboxes when displaying textbox config. forms
is very heavy in a large instance of Mahara. This patch postpones the
listing of other textboxes in the textbox config. form, until the link
to display them is clicked.
This enables the textbox config. form to load and display quickly.

TODO: optimise loading speed of list of textboxes. This process is still
as slow as it was before - all this patch does is defer it until it's
actually required!

Change-Id: I92c77e22753882a2b9ed5be3738b8d26b7f5709d
Signed-off-by: default avatarMike Kelly <m.f.kelly@arts.ac.uk>
      0a1e5e0e
  5. 02 Jun, 2015 1 commit
  7. 28 May, 2015 1 commit
  9. 11 May, 2015 1 commit
  11. 07 May, 2015 1 commit
  13. 04 May, 2015 2 commits
  15. 03 May, 2015 1 commit
  17. 29 Apr, 2015 1 commit
  19. 28 Apr, 2015 2 commits
  21. 24 Apr, 2015 1 commit
  23. 21 Apr, 2015 1 commit
  25. 15 Apr, 2015 2 commits
    • Robert Lyon's avatar
      Stopping SWF files XSS exploitation (Bug #1190788) · 8df9bdfa
      Robert Lyon authored 
      By doing two things:

1) Getting the embedded SWF object to set the
 allowscriptaccess = "never" and allownetworking = "never"

2) By forcing a 'download file' link to actually download file
- this goes for all files now that don't have embedded=1
in their url.

I've done it this way, having the embedded item have extra url param
so that if a user tries to manipulate a url by removing params it
will default to force download.

I've merged the changes I'd done here https://reviews.mahara.org/#/c/3522/2


and I've also cleaned up places where the download=1 was used as that is
not needed now. Now if there are places where we need to embed rather
than download we add the embedded=1 to the url.

Change-Id: If5290a7c571d06d4178ef2ae5c4c09ed287403b4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      8df9bdfa
    • Aaron Wells's avatar
      Explicitly tell the template to use the AJAX block loader · 29053d1b
      Aaron Wells authored 
      Bug 1444229: It was hacky to rely on the block content being empty
to signal the AJAX block loader. We should tell it to do so explicitly.

Change-Id: I9816c43c96ffed85282ac0d874fa5bfe1ca62e00
      29053d1b
  27. 07 Apr, 2015 1 commit
  29. 01 Apr, 2015 1 commit
  31. 31 Mar, 2015 1 commit
  33. 26 Mar, 2015 1 commit
  35. 24 Mar, 2015 1 commit
  37. 23 Mar, 2015 2 commits
  39. 19 Mar, 2015 2 commits
  41. 18 Mar, 2015 3 commits
  43. 17 Mar, 2015 2 commits
  45. 16 Mar, 2015 1 commit
  47. 13 Mar, 2015 1 commit
    • Ghada El-Zoghbi's avatar
      Annotation artefact: Bug 1397759 · 389df353
      Ghada El-Zoghbi authored 
      A new artefact similar to the comment artefact but with less
functionality (i.e. no attached files, etc).
It's an explenation of why a particular evidence meets a
particular standard.

If an annotation is created and added to a page, when the user
deletes it from the page, the instance is deleted along with the
annotation and its feedback.

TODO:

1. Imports seem to be working.
Can get all comments to import and display.
Needs some serious testing.

2. Made changes for broken images but another bug was reported and is
currently being worked on. So, may not need the fixes in here. Changes in:
- htdocs/artefact/file/download.php

To completely fix the broken images for all artefacts, changes are also required
in htdocs/lib/embeddedimage.php to delete based on resourceid instead of fileid.

Change-Id: Ibdb2e1c6500862645bac741bf61cff37e5a5b35c
      389df353
  49. 11 Mar, 2015 1 commit
  51. 10 Mar, 2015 1 commit