1. 15 Jun, 2015 4 commits
  2. 03 Jun, 2015 1 commit
    • Robert Lyon's avatar
      Lazy-load list of textboxes when opening textbox form (Bug 1393734). · 0a1e5e0e
      Robert Lyon authored
      The query to load other textboxes when displaying textbox config. forms
      is very heavy in a large instance of Mahara. This patch postpones the
      listing of other textboxes in the textbox config. form, until the link
      to display them is clicked.
      This enables the textbox config. form to load and display quickly.
      TODO: optimise loading speed of list of textboxes. This process is still
      as slow as it was before - all this patch does is defer it until it's
      actually required!
      Change-Id: I92c77e22753882a2b9ed5be3738b8d26b7f5709d
      Signed-off-by: default avatarMike Kelly <m.f.kelly@arts.ac.uk>
  3. 02 Jun, 2015 1 commit
  4. 11 May, 2015 1 commit
  5. 28 Apr, 2015 2 commits
  6. 24 Apr, 2015 1 commit
  7. 15 Apr, 2015 1 commit
  8. 26 Mar, 2015 1 commit
  9. 24 Mar, 2015 1 commit
  10. 18 Mar, 2015 1 commit
  11. 17 Mar, 2015 1 commit
  12. 11 Mar, 2015 1 commit
  13. 04 Mar, 2015 1 commit
  14. 03 Mar, 2015 2 commits
    • Robert Lyon's avatar
      Adding ids to the edit access and secret url edit buttons · 769d117f
      Robert Lyon authored
      Bug #1427845
      the ids are in the form of:
       editaccess_{id of view}
       secreturl_{id of view}
      eg for view id=10 it will be editaccess_10 and secreturl_10
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      Change-Id: I9b86a39db9a56d295d659203a9c8c1b4b4ba5e5e
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
  15. 01 Mar, 2015 1 commit
  16. 26 Feb, 2015 2 commits
  17. 25 Feb, 2015 1 commit
  18. 24 Feb, 2015 1 commit
  19. 12 Feb, 2015 2 commits
    • Robert Lyon's avatar
      Stopping the 'skins' tab showing for dashboard (Bug #1419959) · c33bb9ef
      Robert Lyon authored
      This is on the page edit screen
      Change-Id: I1e96837c2292cbf9fb6c44bcb291bf722b079329
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
    • Nigel Cunningham's avatar
      Bug1051844: Fix block configure dialog width. · 141ee71b
      Nigel Cunningham authored
      The configure dialog for blocks is currently set to a fixed width via
      Javascript, but there is no handler for browser resizing and it results in the
      dialogue being very wide for the sake of just one line when a license agreement
      is enabled.
      Fix this issue by making all dimensions percentages, and using a combination of
      max-width: 90% and width: max-content. In addition, make the dialog fixed
      position with its own scrollbars as needed (the body's scrollbar is disabled
      when the dialog is shown).
      Contextual help's width code and CSS is also adjusted so that it wraps within
      dialog boxes rather than pushing the width out.
      Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356
  20. 08 Feb, 2015 1 commit
  21. 05 Feb, 2015 1 commit
  22. 02 Feb, 2015 1 commit
  23. 28 Jan, 2015 2 commits
  24. 25 Jan, 2015 1 commit
  25. 21 Jan, 2015 1 commit
  26. 20 Jan, 2015 1 commit
  27. 13 Jan, 2015 2 commits
  28. 07 Jan, 2015 1 commit
  29. 16 Dec, 2014 1 commit
    • Mike Kelly's avatar
      Implement TinyMCE imagebrowser plugin · 36bc9f7d
      Mike Kelly authored and Aaron Wells's avatar Aaron Wells committed
      This is a TinyMCE plugin which allows for browsing and embedding of
      Mahara-hosted images as well as the embedding of external web-hosted
      images. This makes adding inline images to WYSIWYG text boxes more
      Viewing permissions for these embedded files is set by adding references
      to them to a new database table, artefact_file_embedded, then checking
      for the existence of the references in the table when serving the files
      via artefact/file/download.php. For content blocks in views, such as
      text and textboxes, any embedded images are saved as view artefacts, and
      viewing permission is granted for those files accordingly via previously
      existing checks in artefact/file/download.php.
      This patch is designed to allow image embedding in all WYSIWYG text
      boxes throughout Mahara, hence the table structure, with resourcetype
      and resourceid providing the context for checking the validity of the
      image file to be served.
      Change-Id: Idcc5ab3495eed44eea6ced171d670ba4c73884f6
      Signed-off-by: default avatarMike Kelly <m.f.kelly@arts.ac.uk>
  30. 09 Dec, 2014 1 commit
  31. 19 Nov, 2014 1 commit
    • Robert Lyon's avatar
      Always specify what base type we want returned from parseInt() · 3743dcf6
      Robert Lyon authored
      Bug 1394330
      In most places in mahara we specify that we want base 10 number
      returned (or base 16 in case of a hexidecimal css colour)
      But there are a few places where we don't specify the radix at all
      It's best practice to always include the radix because for older
      browsers it interprets leading 0 as octal by default.
      Also makes it clearer to developers what type of number is expected to
      be retrieved from the string.
      Change-Id: Iaecc85cbed875f85b313188c4e96cc1b77c77b31
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>