Skip to content
GitLab
Switch branch/tag
  1. 15 Jun, 2015 2 commits
  3. 28 Apr, 2015 1 commit
  5. 26 Mar, 2015 1 commit
  7. 17 Mar, 2015 1 commit
  9. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored 
      

This patch adds a JSON progress meter (I'll call it that to avoid confusion
with progress bars) to the bulk uploading of users, groups and group
memberships and the bulk export and import of users (LEAP), so the user can see
the progress of the operation and not just the submit button changed to
'Processing..' and whatever indication their browser gives while waiting for
content.

The bulk export and import are minor rewrites, replacing the old iframe based
progress bar and the associated multiple pages and additional template file in
the case of the bulk export, and the recursive redirect-to-self of the bulk
import.

To accomplish the display of the progress bar during the operation, we make the
PHP session be closed (read only) except when changes need to be made. This is
for the most part a straightforward change in session.php as it's the only
direct accessor. In other places, we replace direct accessing of the session
variable ($_SESSION) with use of the session class ($SESSION) so that it can
reopen the session, make the change and close the session again.

There is one more aspect to all of this: with previous behaviour, multiple
requests for the same session would queue, taking the session lock in turn.
After this patch is applied, they can proceed in parallel, allowing greater
throughput. There is no additional locking requirement because the issues are
the same as those already dealt with in allowing multiple PHP threads to
process requests from different sessions at the same time.

I have sought to make the progress meter nice and generic, so it can be used in
the other bulk imports and exports too.

Paradoxically, these changes don't just make the import seem to be faster, it
actually is.. at least in the case of users and groups.

Times for importing 1000 users, groups and memberships, averaged over 3 runs
each (Wall time, not CPU time - but the relationship is the same).

                Without Progress     With Progress
Users                166s               155s
Groups                85s                78s
Memberships           20s                19s

Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      55a8deb8
  11. 18 Sep, 2014 1 commit
    • Robert Lyon's avatar
      The archiving of submitted pages/collections from groups (Bug #1335670) · 5c57b565
      Robert Lyon authored 
      

This patch contains:
- The export queue system where pages/collections on release from
submission are added to the export queue table ready to be archived.
- The export queue admin page showing what is in the queue to be
exported. The cron runs every 6 minutes. Queue items failed to export
are also shown here.
- The archive list admin page, where one can download the generated
leap2a files for the archived submissions.

In this patch you should be able to add things to the export queue by
either releasing a sumbission on a group that has 'archive
submissions' option ticked. This will add the archive to that archived
submission page, or you can also run a leap2a export from portfolio
export which will add the export queue and send you an email once the
export is done.

Things to note:
- The is a server busy function that stops the export queue from
running but I'm not too sure if the threshold is too low/high
- The export queue tries to export the first 100 items each run but if
resources are fine in handling that easily then the number could be
higher but I'm not sure of what will be a good number.
- Currently there is alsoe infrastructure like table columns for dealing
with releasing submissions from external systems (eg moodle) but that
functuionality is yet to be built.
- The checking of server busy in MS windows untested - may need to
just let MS ignore server busy check as there doesn't seem to be
standard way to check this.

Change-Id: If4c1d272e9c5d46fbf16b2ff73ceb2687c06ffd4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      5c57b565
  13. 12 Sep, 2014 1 commit
  15. 05 Jun, 2014 1 commit
  17. 27 May, 2014 3 commits
  19. 27 Mar, 2014 1 commit
  21. 26 Mar, 2014 1 commit
  23. 24 Mar, 2014 1 commit
  25. 09 Mar, 2014 2 commits
  27. 03 Mar, 2014 1 commit
  29. 26 Feb, 2014 1 commit
  31. 23 Feb, 2014 1 commit
  33. 21 Feb, 2014 1 commit
  35. 18 Feb, 2014 1 commit
  37. 02 Feb, 2014 1 commit
  39. 02 Jan, 2014 1 commit
  41. 30 Dec, 2013 1 commit
  43. 16 Dec, 2013 1 commit
  45. 24 Nov, 2013 1 commit
  47. 19 Jul, 2013 1 commit
  49. 22 Apr, 2013 1 commit
    • Son Nguyen's avatar
      Add a filter for users with duplicate emails (Bug #1166499) · cf31e142
      Son Nguyen authored and Aaron Wells's avatar Aaron Wells committed 
      

1. When the option "Filter by duplicate email addresses" is checked,
 the result table will list the accounts with duplicate emails.
 The primary email and additional emails will be shown in the column
'Emails'
 The column 'Emails' is still sortable based on the primary email

2. Also add the column 'Authentication' in search result table

3. Reset offset param when changing the filters

Change-Id: Id59f2de1d9a95c0bb67e8da40eebfeb5a5def60f
Signed-off-by: default avatarSon Nguyen <son.nguyen@catalyst.net.nz>
      cf31e142
  51. 07 Mar, 2013 1 commit
  53. 21 Jan, 2013 2 commits
    • Jiri Baum's avatar
      Masquerading auditability - report on masquerading sessions. (Bug #1027574) · e19d7fb0
      Jiri Baum authored 
      

Masquerading session report, including who, why and when the session started.

Change-Id: I93a6daa60c97ac6a22b6f6d35ba25cb7c2ab275e
Signed-off-by: default avatarJiri Baum <jiri@catalyst-au.net>
      e19d7fb0
    • Jiri Baum's avatar
      Masquerading auditability - ask for reason, notify, emit event. (Bug #900983) · 40517fde
      Jiri Baum authored 
      

Masquerading (aka Loginas) is a useful and sometimes indispensable function.
However, previously it was rather too powerful, because admins can do anything
as the target user, with no indication that it is not the user themselves doing
so.

This feature adds some auditability to masquerading, by logging and reporting
who, when, why and (partially) what, as well as notifying the affected user.

See also bugs: #900983 and #1027574

This commit changes the masquerading feature itself to request a reason from
the admin masquerading, notify the user, and emit an event (for logging by the
next commit).

Change-Id: I066e9fdeb4d2e00679b2aa9b0b839cb4b78629a8
Signed-off-by: default avatarJiri Baum <jiri@catalyst-au.net>
      40517fde
  55. 16 Jan, 2013 1 commit
  57. 30 Nov, 2012 1 commit
  59. 15 Oct, 2012 2 commits
  61. 29 Aug, 2012 1 commit
  63. 24 Jul, 2012 1 commit
  65. 29 Jun, 2012 2 commits