GitLab

Cecilia Vela Gurovic authored Dec 08, 2017 and Robert Lyon committed Feb 16, 2018

added settings

- institution level: reviewselfdeletion
    0 if the institution does not require approval
      from an admin to delete an account
    1 if the institution requires an admin to approve
      account deletion requests from users
    if not set, it takes the value from the site's
    default

- site level: defaultreviewselfdeletion
  (Site options->User Settings -> Review account before self-deletion)
    1 if the site's default is requiring approval
    null otherwise

Account deletion by a user

when a user accesses to the account settings, a
'Delete account' button is displayed.

This will:
- If the user belongs to an institution that requires
  approval (or does not have the settings but the site
  requires approval by default)
    then a notification will be sent to the admins
    of the institutions that require approval that
    the user belongs to
- if the user belongs to institutions and none of them
  require approval (or does not have the setting
  but the site does not require approval by default)
    then the account is deleted
- if the user does not belong to any institution
    then the action will depend on the setting of
    the 'mahara' institution or sites default if
    'mahara' doesn't have the setting

Approval by institution admins

An institution admin can see the pending deletion
requests in Admin menu-> Institution -> Pending deletions
After approving/denying a request, the user
that requested the account deletion will receive
a notification

behatnotneeded
Change-Id: I4ccd9c798cab065ec557eaddf7dfc3a51920b6d0

Maria Sorica authored Feb 02, 2018 and Robert Lyon committed Feb 14, 2018

behatnotneeded

Change-Id: I71f21f76129bc160904cffd1ff62dc6c7fd83c27

Maria Sorica authored Jan 30, 2018 and Cecilia Vela Gurovic committed Feb 12, 2018

1. Add the site T&C to the 'site_content_version' table during installation

2. Display just the privacy statement on the privacy pages for now.
The logic to display the T&C will be added in a future patch.

    behatnotneeded

Change-Id: I70c1477c974b5790762a371d37107819d3c685b6

That way we can have other things like terms and conditions also part
of this system

Change-Id: I00d44a856142095dc3d48f9953a5c775b06b6891
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Rather than loading page with just existing content we can load table
with table and content displayed together for easier comprehension of
which row relates to which statement

Also added the 'Cancel' link so one can cancel out of the form without
saving

behatnotneeded

Change-Id: Idae22c7659c5ea9f63e98e77b73abccaecd97462
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: If1d564c309ebf32025299035fb8cca4d0981f603

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: I1330f4975460a5fff7313b0af139735caf8b9d99

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: I50c0bb5767f866ce0a8b5a961cbd0dd177962323

behatnotneeded

Change-Id: I2d0e298b6ec4c249f4b3a1ee2d8d4b2e54193f1d

This way if we ever query / display who has edited the content we can
know user = 0 is the installed version.

behatnotneeded

Change-Id: I81973a315d7953f29249425ae52712ec2334634f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Added a field displaying the last logged in date

behatnotneeded

Change-Id: I90febf22f0c06d1d739fcd1f9f93857e5f8d9db4

Also tidying up the table / layout to be more like user search page

behatnotneeded

Change-Id: I1c7e880d0ff6bc658ac4c21f5f04138fcf8c7b5c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

fixed following:
jQuery get user type from dropdown usertype_type
the list does not work if no pagination needed

behatnotneeded

Change-Id: I2da46141bd3c12969ab5523b5c822cd85978b8e9

Samantha Jayasinghe authored Oct 11, 2017 and Robert Lyon committed Nov 20, 2017

And avoid direct $_GET and $_POST usage where possible and instead use
param_exists() and the correct param_*() function to fetch the
expected value

behatnotneeded

Change-Id: If2a917360ebf1d198a494907517eb06bb823743c

This patch includes
- Allow the overview report to be the default report
- Fixed sorting of modified/visited columns for page activity report
- Fixed sorting for username in useractivity report
- Fixed total rows count for user activity
- Fixed collaboration report for institutions
- Fixed issues with the new columns in the groups report

Change-Id: I2269bb5610d238bc9786d04d4c2a9122c0a4ccfc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Oct 03, 2017 and Kristina Hoeppner committed Oct 11, 2017

To make choosing 'from' date more realistic

behatnotneeded

Change-Id: Idd11d28e4115989f23cca8046567a72720fe553b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So that they have artefact_file_embedded rows associated with them and
can display to non-admins

behatnotneeded

Change-Id: I477a910637ffc53e0e5be9ed44d0188f49b61bad
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch will contain the fixes for:

- Navigation placement
- Collaboration report
- CSV's of reports
- Overview page for the graphs
- Making Institution selector a select2 field
- Moving all configs for reports into the modal and combine 3rd level
menu with submenu choices in select2 field
- Ignore non logged in users from user activity report
- Move more variables for reports into sticky (session) vars
- Allow results to be fetched from elasticsearch

Change-Id: I725b7615ac3cd6b1d9b6352bae9f6be0d5161e1b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Introduce a new navigation bar to allow going through the different
types of reports:

- Change the page title according to the selected report section and
  report
- Decide which columns to display in a report
- Configure reports via the "Configure reports" button

Add existing reports into the new interface.

Create new and expand existing reports:

- User activity
- Page activity
- Collaboration

Sponsored by the AAIM project with funding from University of
Sussex and Dublin City University.

Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored May 24, 2017 and Robert Lyon committed Jun 29, 2017

behatnotneeded

Change-Id: Ic74144a55e7e3f8e82380b6d5394e258787e0471

Making the admin/statistics.php obsolete and getting admin/users/statistics.php
to do the work.

The institution 'all' shows the site statistics

Sponsored by University of Sussex and Dublin City University

behatnotneeded

Change-Id: Ic2fb9d4ef355fdc5e5527c1ce776463d821c0c08
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Kristina Hoeppner authored Mar 29, 2017 and Robert Lyon committed Mar 30, 2017

Some string IDs changed so that they are
picked up by the translators while others
aren't changed when they are just changes
for English.

behatnotneeded

Change-Id: I9afb8980492937f361e6e35361245c689b5a4413

Lets one have a custom profile field that can be used to record data
against

behatnotneeded

Change-Id: I39de0e6f1aa5b1e29a3bf5604ee88612ccff5478
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

  Hide the dropdown menu site and institution level adding option
    to enable in config.php
    $cfg->dropdownmenuenabled= true

  Separate normal navigation menu from admin navigation menu
    and place it next to user menu at the top right

  Make the navigation changes in all themes but keep old raw theme
    unchanged in raw_old directory

behatnotneeded: Are added in a separate commit
Change-Id: If15680e17486f5bf607c3b0bf84d9086f4179e7d

Also added a couple of missing accessibility strings

behatnotneeded

Change-Id: Ia50f587ae0c46e4972086a72606796e1aa822642
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch allows the dataroot/metadata/*.xml file to be named after
the idp rather than the Mahara institution.

Also added
- A select dropdown so that institution can pick existing auth to be
paired to
- Upgrade to rename the dataroot/metadata/*.xml file
- Check to stop being able to add blank metadata field
- An alert for user when updating metadata if other institutions are also being effected
- Delete the metadata if deleted institution is only one using it

behatnotneeded

Change-Id: Ie3f5cdc523404b1081352ede67aab591e79b6dbb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Currently set the group shortname/institution to NULL but now we
should leave shortname alone and change institution = 'mahara'

behatnotneeded

Change-Id: I390d5e8e17c3edca40a59438e5160db00fcc60fb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

alexeyomelchenko authored Dec 05, 2016 and Robert Lyon committed Dec 20, 2016

behatnotneeded: same functionality

Change-Id: Ied3a5f105dbe0bee6db2c9773163a437c7dfad44
Signed-off-by: alexeyomelchenko <alexeyomelchenko@catalyst.net.nz>

* applied feedback from comments

behatnotneeded: same functionality

Change-Id: Iea7e3a04efca7d8b9c12014a1b16a67970fce62f
Signed-off-by: alexeyomelchenko <alexeyomelchenko@catalyst.net.nz>

To avoid:
1) Bulk deleting all users - by checking if you
   are deleting yourself.
2) Bulk deleting all the site admins - which can happen if you are an
institutional admin and the site admin(s) are in the same institution

behatnotneeded

Change-Id: I4c33d9e54f14e688897275066d2ee128557d4465
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When an institution has artefacts attached, eg Logo image we
include the artefact/lib.php file

Change-Id: I5da9ee684ac3520c682d25cf359ae1e009053e64
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If a user has manually assigned a remote authorization method
from an institution and he is not a member of that institution
when we try to delete the institution there will still be
a record in auth_remote_user table.

When the institution is deleted, so is the authorization method,
and so should be the remote user record.

behatnotneeded

Change-Id: I91dcadc5fbfddc8941c60adc78f304996591b3b8

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat

Added shortname of institution to:
 - Table in institution screen as a column
 - individual institution form as a non editable field

behatnotneeded

Change-Id: I37ba89d5d7c801852f970ce2ff82d7193c85f8d1

with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264

Should be code changes only

behatnotneeded

Change-Id: Ie0a35a8cf54d3f19b6875022a3f6a9f30de1cbd3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And adding the master switch to be set via the config.php file

Change-Id: I92c5a689af75b42b1774c54cc8b97f2938099740
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Because all of our emails need to pass PHPMailer's
validation method before they get sent (due to the way
PHPMailer is written) it makes the most sense to use
that for validation.

Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
behatnotneeded: Covered by phpunit