1. 04 Dec, 2017 1 commit
    • Ghada El-Zoghbi's avatar
      Bug#1735072: Upgrade error with event_log updated columns · a7acb6a5
      Ghada El-Zoghbi authored
      Several issues resolved:
      1. The event_log.time column has been removed
      and replaced by ctime. The handl_event() call is using
      the new column even though the new column has
      not been created yet in the upgrade script.
      Therefore, include both columns in the event handling.
      
      2. The 'deleteartefacts' event stores multiple
      artefact IDs in the one event_log record. Therefore,
      there is not a one-to-one relationship when converting the
      record to the new format. Ignore the record when setting
      the resourceid and resourcetype.
      
      3. In the 'saveartefact' and 'deleteartefact' events,
      not all of the event_log records have 'id' and 'artefact'.
      Ignore setting the resourceid and resourcetype fields
      when the data is not available.
      
      4. For newer versions of Postgres and MySql, utilise
      the json dattype to convert the data held in the
      event_log.data column. This will speed up the
      processing of the table for sites with large data
      in the event_log table.
      
      Sponsored by Australian National University
      
      behatnotneeded
      
      Change-Id: If068dac825b9cef6301cd970f0a368124a67b3f1
      a7acb6a5
  2. 20 Nov, 2017 1 commit
  3. 29 Oct, 2017 1 commit
  4. 27 Oct, 2017 1 commit
  5. 18 Oct, 2017 1 commit
    • Robert Lyon's avatar
      Bug 1724113: Changes for reports · a5c930d8
      Robert Lyon authored
      This patch includes
      - Allow the overview report to be the default report
      - Fixed sorting of modified/visited columns for page activity report
      - Fixed sorting for username in useractivity report
      - Fixed total rows count for user activity
      - Fixed collaboration report for institutions
      - Fixed issues with the new columns in the groups report
      
      Change-Id: I2269bb5610d238bc9786d04d4c2a9122c0a4ccfc
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a5c930d8
  6. 12 Oct, 2017 1 commit
  7. 11 Oct, 2017 1 commit
  8. 26 Sep, 2017 1 commit
  9. 24 Sep, 2017 1 commit
  10. 22 Sep, 2017 1 commit
  11. 14 Sep, 2017 1 commit
    • Robert Lyon's avatar
      Bug 1692385: Adjusting the handle event for 'updateviewaccess' · a3d904e1
      Robert Lyon authored
      We want to record things like so:
      
      resourceid = view_access.id
      resourcetype = what type the view_access row is for, eg 'token',
      'user', 'loggedin' etc
      parentresourceid = the id if the view the access is for
      parentresourcetype = 'view';
      ownerid = the id of the owning resource, eg usr.id / group.id / institution.name
      ownertype = what owns the resource, eg user / group / institution
      
      Also this patch adjusts how we index things into elasticsearch
      
      behatnotneeded
      
      Change-Id: I079a42ded2fefaab64a6e49fc26e8aad303c9e8a
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a3d904e1
  12. 09 Sep, 2017 2 commits
    • Robert Lyon's avatar
      Bug 1697248: Update report navigation and reports · 8c08b88b
      Robert Lyon authored
      Introduce a new navigation bar to allow going through the different
      types of reports:
      
      - Change the page title according to the selected report section and
        report
      - Decide which columns to display in a report
      - Configure reports via the "Configure reports" button
      
      Add existing reports into the new interface.
      
      Create new and expand existing reports:
      
      - User activity
      - Page activity
      - Collaboration
      
      Sponsored by the AAIM project with funding from University of
      Sussex and Dublin City University.
      
      Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      8c08b88b
    • Robert Lyon's avatar
      Bug 1692385: Adjusting the event_log table · ebd928b1
      Robert Lyon authored
      Add 5 new new columns to event_log table make searching over the
      data easier and also record the id of any parent/related info as well
      
      Eg, if one deletes an image block from a page we now record:
      id - the event id
      resourceid - the block id
      resourcetype - the blocktype, eg image
      parentresourceid - the id of the parent, eg view id
      parentresourcetype - the type of parent, eg 'view'
      
      Because we would not be able to find related view info from just the
      block id anymore.
      
      Also added the ability to index and search over event information in
      elasticsearch search type event_log
      
      Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      ebd928b1
  13. 06 Aug, 2017 1 commit
  14. 15 Jun, 2017 1 commit
  15. 28 May, 2017 1 commit
  16. 23 May, 2017 1 commit
    • Robert Lyon's avatar
      Bug 1692749: Security: Stop event log having plain text passwords · 433ab8e6
      Robert Lyon authored
      This patch only deals with:
      1) removing passwords from existing event_log table data
      2) stopping the recording of passwords into the event_log table
      3) sets the reset password on next login for those users
      
      It doesn't deal with removing the unnecessary cruft information
      that will be handled by the bug 1692385
      
      behatnotneeded
      
      Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      433ab8e6
  17. 11 May, 2017 1 commit
  18. 21 Mar, 2017 1 commit
    • Gregor Anzelj's avatar
      Enhance the Watchlist block (Bug #1516981) · 3ca8f0be
      Gregor Anzelj authored
      Enhance the "Watched pages" block to configure it so as to
      display changes relating to users' friends since their last
      login of different time frame (e.g. last week, last month,
      last quarter, last year, etc.).
      
      behatnotneeded: Tests will be written later.
      
      Change-Id: I0ed978a5070120e5b32e79d25f99c2bca84feb20
      Signed-off-by: default avatarGregor Anzelj <gregor.anzelj@gmail.com>
      3ca8f0be
  19. 13 Mar, 2017 1 commit
    • Gregor Anzelj's avatar
      format_date function returns false (Bug #1670885) · e707353a
      Gregor Anzelj authored
      It is known that under Windows the %e modifier of strftime
      function is problematic. Modifier %l is also problematic and
      must be replced with %#I so that format_date will work under
      Windows.
      
      behatnotneeded
      
      Change-Id: I7c0dec6bfd220fbd79a5608a28d152f41df47b6b
      e707353a
  20. 01 Feb, 2017 1 commit
  21. 25 Jan, 2017 1 commit
  22. 09 Jan, 2017 1 commit
  23. 27 Oct, 2016 1 commit
  24. 17 Oct, 2016 1 commit
  25. 07 Oct, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1620879: Remove extraneous "/webservice" from end of plugin components · 98ca273e
      Aaron Wells authored
      Currently, a plugin has to list its component as e.g.
      "module/mobileapi/webservice". This could just be "module/mobileapi".
      
      Since we're using the component string as part of the automated token
      request system, it's better to change this now to something more sensible.
      
      behatnotneeded: Tests to come later
      
      Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d
      98ca273e
  26. 27 Sep, 2016 1 commit
    • Aaron Wells's avatar
      Documenting that call_static_method() is deprecated · dc852194
      Aaron Wells authored
      PHP 5.0 to 5.2 apparently did not support dynamic access
      of static members, e.g. $classname::$method(). But support
      for this was added in PHP 5.3. So there's no longer any
      reason to use call_static_method().
      
      Change-Id: Ib2c48251fb3e5a8ca4af9994bd2d648bc40794d2
      behatneeded: Comment update only
      dc852194
  27. 26 Sep, 2016 2 commits
    • Aaron Wells's avatar
      Bug 1533377: Browserid end-of-life migration script · cfef0ff9
      Aaron Wells authored
      This patch removes all authentication functionality
      from the browserid auth plugin. It adds a script,
      accessible through the plugin's configuration page,
      to migrate user accounts from browserid to
      internal auth.
      
      Also includes changes to allow users to be searched
      by authtype, and to prevent non-useable plugins
      from being enabled on the plugin config page.
      
      Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
      behatnotneeded: Can't test with behat
      cfef0ff9
    • Aaron Wells's avatar
      Bug 1620879: Improve JSON error messages when JSON flag is on · d382d069
      Aaron Wells authored
      JSON-encodes more information about the error or exception,
      and adds an optional error number.
      
      behatnotneeded: Can't test in Behat
      
      Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d
      d382d069
  28. 19 Sep, 2016 1 commit
  29. 01 Sep, 2016 3 commits
  30. 31 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1615280: More robust email validation · 1192c05d
      Aaron Wells authored
      Because all of our emails need to pass PHPMailer's
      validation method before they get sent (due to the way
      PHPMailer is written) it makes the most sense to use
      that for validation.
      
      Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
      behatnotneeded: Covered by phpunit
      1192c05d
  31. 30 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1600099: Cleanup of the webservice admin page · ce1a97ac
      Aaron Wells authored
      This patch does a few things:
      
      1. Renames "webservice_enabled" config to "webservice_provider_enabled",
      to indicate that this config only controls Mahara's actions as
      a webservice provider, *not* a webservice client.
      
      2. Renames all the "webservice_<protocol>_enabled" configs to
      "webservice_provider_<protocol>_enabled" to indicate that they only
      control whether Mahara will provide webservices via that protocol,
      and not whether Mahara will use that protocol as a client.
      
      3. Renames "webservice_connections_enabled" config to
      "webservice_requester_enabled", to clarify that this config
      controls whether Mahara is allowed to request webservices
      from external sources.
      
      4. Updates language strings to make these changes clearer.
      
      5. Rearranges and renames the form methods in
      webservice/admin/index.php to make the flow of control more
      obvious. Now the main form method is first, followed in order
      by the methods that generate its subforms and each of their
      submit handlers.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9
      ce1a97ac
  32. 24 Aug, 2016 1 commit
  33. 23 Aug, 2016 1 commit
  34. 19 Aug, 2016 1 commit
    • Aaron Wells's avatar
      CLI upgrader, better handling of out-of-sequence plugin upgrades · 0e1704c1
      Aaron Wells authored
      Bug 1614805. When a plugin is installed "out of sequence" by a
      call to plugin_upgrade in the core lib/db/upgrade.php file, the
      AJAX-based web upgrader handles it gracefully, because it does
      check_upgrade() before upgrading each plugin, detects the change
      in status, and doesn't run the upgrade for that plugin a second
      time.
      
      The CLI upgrader, on the other hand, uses the same cached data
      from check_upgrades() all the way through, causing it to re-run
      upgrades for such plugins.
      
      This patch makes it behave the same as the AJAX plugin, running
      check_upgrade() again immediately before each component gets
      upgraded. This does cause some redundancy in code execution,
      but it shouldn't be enough to cause a noticeable performance hit.
      
      Change-Id: Id5c431fc9e636df2cab05d22e6cc424271ce9f3d
      behatnotneeded: Covered by existing tests
      0e1704c1
  35. 04 Aug, 2016 1 commit
  36. 13 Jul, 2016 1 commit
    • Aaron Wells's avatar
      Get rid of redundant DB writes in set_config() · a79dd6bb
      Aaron Wells authored
      Bug 1526073. Also in set_config_plugin() and
      set_config_plugin_instance().
      
      set_config_institution() is more complicated, and outside
      the scope of this bug.
      
      Change-Id: Ibaeb93fea83c190e6ffab7cd000eddf98f3afbb7
      behatnotneeded: Covered by existing tests
      a79dd6bb