GitLab

Move the help icon for view/view down to near the links that it is help for, rather than leaving it as page help.

Cleaned up the help for create view step one. There is now less of it and what is there is worded better.

Some editing to helptext to make it (hopefully!) more helpful. Removed a help icon that seemed rather pointless.

called when committing changes or deleting an artefact

Applied the same feedback improvements to viewing an artefact that were previously applied to viewing a view.

Also make it impossible to submit a file as an attachment when viewing an artefact. Digging around on production suggests this feature isn't used, and it's buggy because if the user chooses to upload a file, then the feedback is placed on the view rather than the artefact they were viewing.

If a logged out person hits a public page which has thrown an AccessDeniedException, redirect them to the login page.

Real users are only going to try logging in anyway, and non users aren't going to be able to log in, so it's just a usability improvement.

It might be worth adding a message to say what's happened later.

Added a 'busy' cursor when performing a json request. Works well on create view step two, I'll evaluate how it works elsewhere over the next little while.

* If you have not tags, it now tells you rather than just mysteriously disappearing
* If you click on a tag and it's already in the input box, it is removed instead, giving a nice toggle ability. It handles the commas/spacing too.
* Removed a debugging line that had been there for ever.

Make the help for the tags control appear on one line. Also reduced the default length of the tags control.

Added some helpful text (I think!) to the profile page. Made its title 'edit profile' to match its menu item (usability related).

Added a button to take the user to view their profile page, which should help in making it easier for users to find it for now.

Some reworking of the navigation might change this in future.

I'm not sure why calling reset() on the form wasn't doing this in firefox 2. I've left that line in just in case it actually works on other browsers.

The format is now much easier to read and style. Users have icons beside their names. Language strings are translated.

If your session times out and you've just hit a public page, make the URL to trigger the transient login page remember any GET parameters.

This makes it so that if you hit a public view (view.php?id=8 for example) and your session has just timed out, after you submit the login form you will continue to view.php?id=8 rather than just view.php. The latter is very annoying because it's not what you were after and will cause the script to bail anyway.

Conflicts:

	htdocs/theme/default/templates/header.tpl

The name is largely irrelevant as it's only the creator of the file.