GitLab

Created switch in site options. When set to 'yes',
it disables the multiple institution per user switch.

To do: When set to 'yes', force user to accept T&C
and privacy statement. Will be resolved in another
bug report #1741799

behatnotneeded

Change-Id: Ie62fb34a6c7cbf8e5b9bce93e76dc7c4a05376b9

Currently we have a mahara_log function that logs page visits
So I decided we also need a mahara_touch_record($table, $id) function
that updates the 'atime' for a record when called

behatnotneeded

Change-Id: I2f645c8357426112f9edcdd24f1b8b85513cb7cb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

when calling clear_all_caches(true), the dataroot/sessions
directories will be deleted
we recreate them again at that moment instead of
waiting until the Session checks

behatnotneeded

Change-Id: I1ea2318cda4743d4908f5cb51990b02aa385a1ea

Several issues resolved:
1. The event_log.time column has been removed
and replaced by ctime. The handl_event() call is using
the new column even though the new column has
not been created yet in the upgrade script.
Therefore, include both columns in the event handling.

2. The 'deleteartefacts' event stores multiple
artefact IDs in the one event_log record. Therefore,
there is not a one-to-one relationship when converting the
record to the new format. Ignore the record when setting
the resourceid and resourcetype.

3. In the 'saveartefact' and 'deleteartefact' events,
not all of the event_log records have 'id' and 'artefact'.
Ignore setting the resourceid and resourcetype fields
when the data is not available.

4. For newer versions of Postgres and MySql, utilise
the json dattype to convert the data held in the
event_log.data column. This will speed up the
processing of the table for sites with large data
in the event_log table.

Sponsored by Australian National University

behatnotneeded

Change-Id: If068dac825b9cef6301cd970f0a368124a67b3f1

Dmitrii Metelkin authored Oct 19, 2017 and Robert Lyon committed Nov 21, 2017

behatnotneeded

Change-Id: Ie2450031b608cdcf6072b1793023668ab2ed0727

Also make the minimum PHP version be 5.5.9

behatnotneeded

Change-Id: I784566d0a75ec7020ac61d3b6a56237fe4e2c670
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

For the 3 columns that use elasticsearch
- group page comments
- shared pages
- shared page comments

behatnotneeded

Change-Id: Ib7ee64f958a0d9ddd7382e067f23fe2e62c7d207
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch includes
- Allow the overview report to be the default report
- Fixed sorting of modified/visited columns for page activity report
- Fixed sorting for username in useractivity report
- Fixed total rows count for user activity
- Fixed collaboration report for institutions
- Fixed issues with the new columns in the groups report

Change-Id: I2269bb5610d238bc9786d04d4c2a9122c0a4ccfc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I439d1161e2d3ae12920ae24bba8af47c62a7ce07
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As part of the db upgrade process. This allows us to turn the triggers
off while updating a certain table and turning them on again afterwards.

behatnotneeded

Change-Id: I5d6f2f7fb7075fca5fe8c811820abe87d92790b3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

By checking if extra args are expected

behatnotneeded

Change-Id: I64d4b0bc55323be71fcf11c4455e19190d511ea3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I589cc42dd543ea4edfa418de8b85b711d3f0dd3e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As we don't need to record user interation at this point and it breaks
things on upgrade from old systems as some of the
tables/columns/sequences do not exist

behatnotneeded

Change-Id: I7d6f8969f9b94ba93761c0c25303e2e4916fa778
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

We want to record things like so:

resourceid = view_access.id
resourcetype = what type the view_access row is for, eg 'token',
'user', 'loggedin' etc
parentresourceid = the id if the view the access is for
parentresourcetype = 'view';
ownerid = the id of the owning resource, eg usr.id / group.id / institution.name
ownertype = what owns the resource, eg user / group / institution

Also this patch adjusts how we index things into elasticsearch

behatnotneeded

Change-Id: I079a42ded2fefaab64a6e49fc26e8aad303c9e8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Introduce a new navigation bar to allow going through the different
types of reports:

- Change the page title according to the selected report section and
  report
- Decide which columns to display in a report
- Configure reports via the "Configure reports" button

Add existing reports into the new interface.

Create new and expand existing reports:

- User activity
- Page activity
- Collaboration

Sponsored by the AAIM project with funding from University of
Sussex and Dublin City University.

Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

We need to avoid the sprintf() error if lang string expects extra args.

We can do this by supplying function check_string rather than
format_string

behatnotneeded

Change-Id: Ibfc2d9a552f2d87b2f5f762bab2ff2ec76a73dca
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Antonella De Chiara authored Jun 16, 2017 and Robert Lyon committed Jun 16, 2017

behatnotneeded

Change-Id: Ie14a090eaacbdabf621d366109c5082107eba50a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Making the admin/statistics.php obsolete and getting admin/users/statistics.php
to do the work.

The institution 'all' shows the site statistics

Sponsored by University of Sussex and Dublin City University

behatnotneeded

Change-Id: Ic2fb9d4ef355fdc5e5527c1ce776463d821c0c08
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch only deals with:
1) removing passwords from existing event_log table data
2) stopping the recording of passwords into the event_log table
3) sets the reset password on next login for those users

It doesn't deal with removing the unnecessary cruft information
that will be handled by the bug 1692385

behatnotneeded

Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Also do not show the annotation feedback comment form if not logged in
Also goto the matrix page if exists and the token cookie doesn't
rather than frist page of collection

behatnotneeded

Change-Id: Ibf05bfde95d257090bd7aa4aabb9e28025ad3a07
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Gregor Anzelj authored Feb 14, 2016 and Robert Lyon committed Mar 22, 2017

Enhance the "Watched pages" block to configure it so as to
display changes relating to users' friends since their last
login of different time frame (e.g. last week, last month,
last quarter, last year, etc.).

behatnotneeded: Tests will be written later.

Change-Id: I0ed978a5070120e5b32e79d25f99c2bca84feb20
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

Gregor Anzelj authored Feb 20, 2017 and Robert Lyon committed Mar 14, 2017

It is known that under Windows the %e modifier of strftime
function is problematic. Modifier %l is also problematic and
must be replced with %#I so that format_date will work under
Windows.

behatnotneeded

Change-Id: I7c0dec6bfd220fbd79a5608a28d152f41df47b6b

To make it easier for admins to know which PHP modules to install

behatnotneeded

Change-Id: Ib58750436426f87b3e6c4fc41c639b930f0a6a56
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The root user needs to exists for Mahara to function correctly

It is used (at least) to hold some default layout options

behatnotneeded

Change-Id: I8a25a2d60a0f2be55b4abb6d86c470d0f7f08786
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Fixed lines of code that threw the error
"Only variables should be passed by reference"
and other errors found.

behatnotneeded

Change-Id: I23e6a3c1b2ef97bf2cae29c15814fcdb79d5676f

behatnotneeded: styling only

Change-Id: I9b88be45e97271fdb43e9cb9407caa619fa9c880

In rest/locallib.php and lib/mahara.php

behatnotneeded

Change-Id: I5120656913d39b69d2f8c9492b485a12e7c58f90
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Currently, a plugin has to list its component as e.g.
"module/mobileapi/webservice". This could just be "module/mobileapi".

Since we're using the component string as part of the automated token
request system, it's better to change this now to something more sensible.

behatnotneeded: Tests to come later

Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d

PHP 5.0 to 5.2 apparently did not support dynamic access
of static members, e.g. $classname::$method(). But support
for this was added in PHP 5.3. So there's no longer any
reason to use call_static_method().

Change-Id: Ib2c48251fb3e5a8ca4af9994bd2d648bc40794d2
behatneeded: Comment update only

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat

JSON-encodes more information about the error or exception,
and adds an optional error number.

behatnotneeded: Can't test in Behat

Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d

with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264

Should be code changes only

behatnotneeded

Change-Id: Ie0a35a8cf54d3f19b6875022a3f6a9f30de1cbd3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1) Saving framework setting when copying collection

2) Removing the ability of site admins from setting an institution only
framework to a different institution

3) Made standard tooltip be like element tooltip

4) Added owner's name to the matrix.page

5) Added the framework name as a 'page' in the list for
collection/index.php

6) Updated the matrix completed count before page reload

7) Allowed basic html in .matrix descriptions

8) Replaced example.matrix with 2 new .matrix files

9) Fixed issue where framework evidence was not being restricted to a
collection

Change-Id: I171ff55482191e19b9b734907af7a86bfd1ccede
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Instead of the plugin's directory name so that we can change the
plugin's displayed name without having to move/change the directory
name.

Change-Id: Iacafb89dc8aaaa284ec57323f7e889679385c567
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Because all of our emails need to pass PHPMailer's
validation method before they get sent (due to the way
PHPMailer is written) it makes the most sense to use
that for validation.

Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
behatnotneeded: Covered by phpunit

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

Also adding aria-required="true" to required fields

behatnotneeded - existing test are ok

Change-Id: Iaba02ea6653d28da298a0e410ab3d79773f810db
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1525736: Also doing a general cleanup of this very old
and very messy function.

behatnotneeded: Covered by existing tests

Change-Id: I4b2feba22764fd290a69dc4b6ab1d734abd08a1c