1. 06 Oct, 2019 1 commit
  2. 04 Oct, 2019 4 commits
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Accessibility settings and layout · 25082988
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      - Added an option to set the profile to accessible.
      This can be set in account preferences and
      enables one extra field in the settings
      of a view, in the basic settings section, to make
      the layout accessible.
      
      - by default, if the user account is accessible then
      the pages will be crated as accessible.
      To have a non accessible page, the option un view settings
      needs to be set as 'No'
      
      - Accessible layout only allows to add blocks with width=12
      that is the same with of the grid.
      This makes the blocks show as a sequence one on top of the other
      like a list. The user can only reorder the position
      they have in the list.
      
      - When a page is accessible, the adding a block
      by drag & drop is disabled
      
      - Reordering of blocks is accessible by keyborad
      
      - The 'add block' button is reachable by keyboard
      
      - add an intro to the page for the screen reader
      to explain how the page works
      
      - add identification to each block for screen reader,
      blocktype and title (if it’s set)
      
      TODO
      * When adding a block to the bottom or the top of the page,
      the page should be scrolled to that block
      
      * Floating menu: should have a way to be recognized as a menu
      by the screen reader. Check the access keys for the menu.
      
      behatnotneeded
      
      Change-Id: I08417f0f11d747a67900c88c2f675ef5f85b7499
      25082988
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Creating a view via tags with gridstack · 1a1d2a69
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      when creating blocks via tags
      - the position of the copied blocks in the new view
      will be one on top of the other
      - if the block comes from a view with grid layout,
      it will take the width & height from its dimensions
      - if the block comes from an old layout view,
      it will be created with default dimensions
      width = 4
      height = 3
      
      behatnotneeded
      
      Change-Id: I465e09fa4af6742913302c7ef278708c3cb627bc
      1a1d2a69
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Remove edit layout section · d45aed8d
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      - also remove the layout pieform
      and the custom layout javascript code
      
      behatnotneeded
      
      Change-Id: I3e2e2b3f09106dd2a341a40d178feca693194e64
      d45aed8d
    • Lisa Seeto's avatar
      Bug 1844470: Move "Display page" and "Return to pages and collections" · 466b4a8a
      Lisa Seeto authored
      
      to right-hand side on "Edit" screen
      
      - create new edit page action buttons for return to <location> button
      - delete references to the old display page link created in file editviewtabs.tpl
      - delete file editviewtabs.tpl
      - change the edit button in editviewpageactions.tpl into a display button
      - change behat tests to reflect the change from Edit to Display page
      - change the Behat instruction for And I display the page to target updated element
      - delete the old display button styling from the style guide
      - move url, title display logic into new func get_return_to_url_and_title in lib/view.php
      - adjust blocks.php, access.php, editlayout.php to assign url, title using new func
      
      behatnotneeded
      
      Change-Id: Iedf2882c42fa1d204e438a23842834fbb9a709f9
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      466b4a8a
  3. 10 Sep, 2019 1 commit
  4. 16 Aug, 2019 1 commit
  5. 12 Jun, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1827272: move theme dropdown menu to page settings · 33d1f349
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed
      -move select box from the page edit screen to
      Settings-> Advanced
      -remove no-longer-used code from views.js, blocks.tpl
      and blocks.php
      -update behat test
      -add desc field for the theme chooser
      I also fixed the 'Lock blocks' description, which had a grammatical error.
      
      Change-Id: I4cddf3fe884d11cf950408041daf92d12915b2d3
      33d1f349
  6. 12 Apr, 2019 1 commit
  7. 19 Mar, 2019 1 commit
  8. 06 Nov, 2018 1 commit
  9. 03 Oct, 2018 1 commit
  10. 02 Oct, 2018 2 commits
  11. 09 Sep, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1790543: Display portfolio instructions · 5cedce1f
      Cecilia Vela Gurovic authored
      1) Add an 'instructions' field to view table via install / update.
      
      2) Add 'Instructions' textarea / wysiwyg field to view settings page and
      have it save to the database
      
      3) Move generic "This area shows a preview of what your page looks like.
      Changes are saved automatically. Drag blocks onto the page to add them.
      You can then also drag them around the page to change their position."
      text in edit page to the help icon and in it's place have an expandable
      area to display the saved 'instructions' message.
      
      4) On view display page have an expandable area to display the saved
      'instructions' message
      
      5) in view edit mode, collapsing/uncollapsing the Instruction section
      is remebered automatically for next time the view is edited
      
      behatnotneeded
      
      Change-Id: Ia56323b9b734b8ebe9498c54dce5a3b934d1fd29
      5cedce1f
  12. 06 Sep, 2018 1 commit
  13. 08 Aug, 2018 1 commit
    • Kevin Dibble's avatar
      Bug 1781844: Lock blocks on pages · 3e76e38e
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed
      A lot of users in Mahara create (Template) pages to share out to users.
      This reduces the setup a new user will have to do to. There is an issue
      that on their personal copy, the blocks that were so carefully setup can
      be deleted.
      
      This functionality creates a new column in the database called
      "lockblocks" that can be enabled/disabled on the share page.
      
      When the user copies the page, this setting is copied over and the
      "delete" icon is hidden from view should the lockblocks setting be
      enabled. This only happens on normal portfolio pages.
      
      To unset - the user can edit the page settings and
      disable the lock blocks feature to enable the deletion of the blocks as
      per normal.
      
      behatnotneeded
      Change-Id: I7a2062f77431d6371f95d7f55bedcc499dd7caa2
      3e76e38e
  14. 12 Jul, 2018 1 commit
  15. 09 Jul, 2018 1 commit
  16. 04 Jul, 2018 1 commit
  17. 06 Mar, 2018 1 commit
  18. 22 Feb, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1738303: Remove the obsolete $new variable being passed about when · fef8c68d
      Robert Lyon authored
      
      creating a new page.
      
      It is mostly so we can show 'No title' for page name and to have a
      'back' button instead of 'edit page' when viewing ones own page.
      
      But we don't need it as a page has a title when we click 'add page' as
      we make the new view entry in database straight away and the title
      will be something like 'Untitled v.2'.
      
      And if we change the title on page settings form then block edit screen
      will now show new correct title instead of 'No title'
      
      behatnotneeded
      
      Change-Id: I4630d53fbee734f1f4e903c05aa92b8348f3f41f
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      fef8c68d
  19. 29 Sep, 2017 1 commit
  20. 24 Sep, 2017 1 commit
  21. 07 Sep, 2017 1 commit
  22. 04 Aug, 2017 1 commit
  23. 29 Jun, 2017 1 commit
  24. 27 Jun, 2017 1 commit
  25. 09 Feb, 2017 1 commit
  26. 06 Jul, 2016 1 commit
  27. 03 Jun, 2016 1 commit
  28. 27 Apr, 2016 1 commit
  29. 21 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1539262: Making constant SUBSECTIONHEADING · 4d6abc2b
      Robert Lyon authored
      
      
      To make this similar to PAGEHEADING / TITLE for consistency
      
      This allows the for it to display when an AccessDeniedException is
      thrown.
      
      Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
      the wrong order.
      
      behatnotneeded - existing tests should be fine
      
      Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4d6abc2b
  30. 16 Mar, 2016 1 commit
  31. 09 Dec, 2015 1 commit
  32. 01 Oct, 2015 1 commit
  33. 27 Sep, 2015 1 commit
  34. 20 Sep, 2015 1 commit
  35. 17 Aug, 2015 1 commit
  36. 30 Jul, 2015 1 commit