Skip to content
GitLab
Switch branch/tag
  1. 21 Apr, 2016 2 commits
  3. 18 Apr, 2016 7 commits
    • Liam Sharpe's avatar
      Journal add file remove is now a button - Bug #1515398 · 17190a62
      Liam Sharpe authored and Robert Lyon's avatar Robert Lyon committed 
      - Fixed 'Remove' button for existing attachments
- Fixed reloading of modal popup for 'Add a file' if form reloads with
error

behatnotneeded

Change-Id: Ib68e6a33beb6f85701281fcdf337fafd079c9528
      17190a62
    • Liam Sharpe's avatar
      Added first and last buttons to image gallery slideshow block - Bug #1530606 · 6fa397e3
      Liam Sharpe authored and Robert Lyon's avatar Robert Lyon committed 
      behatnotneeded

Change-Id: Ic839970344a7b09d742f3f609ef2a80e6ea500af
      6fa397e3
    • Aaron Wells's avatar
      Correcting typoes in cookie-issuing code · abd93f7c
      Aaron Wells authored 
      Bug 1570744: Accidentally used set_cookie() instead of
setcookie(). This makes the cookie break if you use
the $cfg->cookieprefix setting.

behatnotneeded: Covered by existing tests

Change-Id: Idec3676222e3ff4eb22f7925de6bec10cfa35755
      abd93f7c
    • Kristina Hoeppner's avatar
      Bug 1571298: Adjust edit page info to be clearer for preview · 5e0c27ac
      Kristina Hoeppner authored and Robert Lyon's avatar Robert Lyon committed 
      Make it clearer that changes are saved automatically
and shorten 2nd sentence.

behatnotneeded

Change-Id: I875afae34d950e77e43bf3b4ece895d42c23e1ec
      5e0c27ac
    • Aaron Wells's avatar
      Bug 1567784: session_regenerate_id() not working · a923f51b
      Aaron Wells authored 
      We have existing code that tries to regenerate your
session ID when you log in. But it stopped working
in PHP 15.04 because the session has usually been
closed when it gets called.

Change-Id: I5f99cdf355892040866bb0113fd934e3d37bf33c
behatnotneeded: Can't be tested by behat
      a923f51b
    • Aaron Wells's avatar
      Bug 1570744: Fixing session bugs · 83ec33f2
      Aaron Wells authored 
      This patch does 2 things:

1. It loads the session much earlier during init.php. We wind
up creating one on *every* script load anyway, due to LiveUser's
constructor. Sometimes it gets created earlier if other code
tries to use it before then, which adds some unpredictability
to things. Moving it up to the top of init.php reduces that
unpredictability.

2. It turns out that in PHP 5.3, using header_remove('Set-Cookie')
to only doesn't remove session headers. But header_remove()
(with no params) to remove *all* cookies does remove them. So
I'm changing remove_duplicate_cookies() to use that instead.

3. Also in PHP 5.3, session headers are visible in headers_list().
In situations where your session id changes (due to session_destroy()
and session_regenerate_id()), our use of array_unique() meant we
would preserve the old and new session IDs and send both back
to the browser. This patch makes remove_duplicate_cookies() aware
of the current session ID, and it only preserves that one.

Change-Id: I7a90b8692a5f97429415aa9a17451a44cd2109dd
behatnotneeded: Covered by existing tests
      83ec33f2
    • Aaron Wells's avatar
      Adding a wait step to "I delete link resource menu item" · 904e510e
      Aaron Wells authored 
      Need to give the browser a chance to proceed, in case the
popup makes the page reload.

Change-Id: I271a00e38be3cb65f236f6aa46f20a14105ca230
      904e510e
  5. 17 Apr, 2016 1 commit
    • Tobias Zeuch's avatar
      Fix illegal reference in join condition on Exists-subquery · 65c21985
      Tobias Zeuch authored 
      

Bug 1571421: In the exists-subquery the join-condition contains a reference to an outer table alias, which is not supported in MySql (though it seems to work in Postgres). This leads to a "site unavailable" e.g. when searching on the "shared with me" page.
The solution is to move the condition into the WHERE-part. This might actually improve performance because it allows the database engine to precalculate the join one single time and reuse it for each Exists-subquery

behatnotneeded

Change-Id: I5097154d939bf7ddba01d5845af7e8cbb42681b8
Signed-off-by: default avatarTobias Zeuch <tobias.zeuch@rwth-aachen.de>
      65c21985
  7. 15 Apr, 2016 1 commit
  9. 14 Apr, 2016 2 commits
  11. 13 Apr, 2016 1 commit
  13. 12 Apr, 2016 1 commit
    • Aaron Wells's avatar
      Remove session.referer_check (Bug 1566366) · 91807920
      Aaron Wells authored 
      This setting kills your Mahara session whenever you navigate
to Mahara from a link or redirect on another page. This totally
prevents SAML and other redirect-based auth methods from working,
makes it annoying to use links in email, and while it is mentioned
on the PHP manual's "Securing Sessions" page, it's only
recommended there if you also have "session.use_trans_id" enabled,
which we do not.

Change-Id: I8b3b14bae8043c5004cc8f36766f2db9422eac1c
behatnotneeded: Can't be tested by behat
      91807920
  15. 11 Apr, 2016 2 commits
  17. 07 Apr, 2016 1 commit
  19. 06 Apr, 2016 1 commit
  21. 05 Apr, 2016 2 commits
    • Kristina Hoeppner's avatar
      Bug 1565206: Update tag help files · 52efd247
      Kristina Hoeppner authored 
      Making all elements named "tags" use ANY.tags.html
by default.

Also add a tag help file when viewing a note
under "Content" -> "Notes" and for "Plans" and
"Tasks" under "Plans".

behatnotneeded

Change-Id: Ib71b04d65507cc3b2c38ac9db87db2727521cb82
      52efd247
    • Aaron Wells's avatar
      Use PHP 5.3 array syntax · d5aef398
      Aaron Wells authored 
      Bug 1566127

Change-Id: I8e249a93fbff7c3bf914099e53f1f29068a36a15
behatnotneeded: Covered by existing tests
      d5aef398
  23. 04 Apr, 2016 2 commits
  25. 01 Apr, 2016 2 commits
  27. 31 Mar, 2016 15 commits