GitLab

Robert Lyon authored Jul 16, 2018 and Cecilia Vela Gurovic committed Oct 01, 2018

To allow us to restrict things being shown for block when in older
version.

behatnotneeded

Change-Id: I8d9ffe1e7b26a07fc84e3ce64e988b9d7babc396
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Roisin Pearson authored Feb 05, 2018 and Cecilia Vela Gurovic committed Oct 01, 2018

Change-Id: Ia5e26f7791a1aec90cd26d3092f7542881456255

Includes converting the RESUME_SUBPAGE to MENUITEM_SUBPAGE

And getting the group subnav to use the same structure

behatnotneeded

Change-Id: Ia3bcb02030b5fe4deae47f20ff497dda55667d95
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I523b7989df426670690b0a086c553149dba26d84
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change the Plan icon from 'checkbox' to 'map' as signoff plugin makes more
sense to use the 'checkbox' icon in page editor

Also adding icons to the titles of the pages
in content/portfolio/group sections

behatnotneeded

Change-Id: I6b2ab5945dca1e6e26d5b1a9c23d59e39ee057ce
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1) Add an 'instructions' field to view table via install / update.

2) Add 'Instructions' textarea / wysiwyg field to view settings page and
have it save to the database

3) Move generic "This area shows a preview of what your page looks like.
Changes are saved automatically. Drag blocks onto the page to add them.
You can then also drag them around the page to change their position."
text in edit page to the help icon and in it's place have an expandable
area to display the saved 'instructions' message.

4) On view display page have an expandable area to display the saved
'instructions' message

5) in view edit mode, collapsing/uncollapsing the Instruction section
is remebered automatically for next time the view is edited

behatnotneeded

Change-Id: Ia56323b9b734b8ebe9498c54dce5a3b934d1fd29

Robert Lyon authored Jul 31, 2018 and Cecilia Vela Gurovic committed Sep 10, 2018

A new block is created that can only be filled with content from a
person who has the “Peer assessment” role for a portfolio. The block's
content is not visible to the page owner until the peer published it.

The block can be selected by the portfolio author for inclusion on any
page, but it can only be used in conjunction with the peer assessor role.
If no peer assessor is selected for a portfolio, the block stays empty.
It is also available on the site and institution level for inclusion into
portfolio pages there (for the creation of templates).

behatnotneeded: will be added in patch 9063

Change-Id: I6f9945f184b4512c345402e1a73f6fc6f21572a7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I9a46effa541a741dd525de66f8bec654b9d011d7

behatnotneeded

Change-Id: I4b7b4d95bd17ff2fea81e3b750f9978471ec5d7a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And handle how we configure / render them when not on normal portfolio
page

Change-Id: Ib5407a32b52edd0df4ecc2907f8a5c9455f7aa64
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Jul 09, 2018 and Robert Lyon committed Aug 15, 2018

behatnotneeded

Change-Id: Idc07cd4408854bc234c75031964f777164fd12e0

Rebecca Blundell authored May 29, 2018 and Robert Lyon committed Aug 15, 2018

replaced each() with foreach in core code.
replaced create_function() with anonymous function in core code.

Also removed some functions that were not used anymore

behatnotneeded

Change-Id: I300396a1ec04c75d7882b7ec5c9de76c3763e70d

Things done with this patch:

1) Changed the 'Use photo frame' option from being a plugin variable
   to being an instance config variable

2) Added back in the css for the giving the gallery images photo frame
   borders

3) Get the non-square thumbs to render correctly spaced on load

4) Swapped the slimbox2 to fancybox3 and allowed the block itself to
control when to put content into head data

behatnotneeded

Change-Id: I397be45f2347588988b663b25b560d8ab876afe1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Jun 14, 2018 and Robert Lyon committed Aug 07, 2018

Deprecated: document-ready handlers other than jQuery(function)
Breaking change: Deprecated .size() removed

behatnotneeded

Change-Id: I7c61090a3362586571855fc081847c084e398c33

Cecilia Vela Gurovic authored May 04, 2018 and Robert Lyon committed Aug 07, 2018

Event
   Breaking change: .load(), .unload(), and .error() removed
   Breaking change: .on("ready", fn) removed
   Breaking change: event.pageX and event.pageY normalization removed
   Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
   Breaking change: Delegated events with bad selectors throw immediately
   Deprecated: .bind() and .delegate()
     no calls to .bind() for events in core.
     Only calls to bind() refer to the js bind of arguments to functions.
     no calls to unbind() for event in core.
     Only calls to unbind refer to the unbind method defined in
     formChangeManager not related to the jQuery method.

    Warnings fix
    JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
    - also applies to the other event shorthands, including:
     blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
     mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
     change, select, submit, keydown, keypress, keyup, and contextmenu.

    JQMIGRATE: jQuery.fn.hover() is deprecated
    JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
	(for FileBrowser we can see this error when editing a block in a page)

behatnotneeded

Change-Id: I1a50050f882b864ad63d273de160e0b441a77705

In the past there was 2 filebrowser fields, body background and view
background, in the skin edit form and this meant we couldn't submit
the form by js as it confused things.

But now we only have the body background image option so I've altered
the form so that it submits via javascript.

In doing so it gets the changing folder to work as expected as well.

I've also restricted the images one can use to non-profile ones as
that was causing an error on valid image check.

behatnotneeded

Change-Id: Ia11d3ce6073d15d2c60727d3abbdf31b6a93993b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This js file was loaded when calling
 function get_instance_javascript() in
 artefact/file/blocktype/gallery/lib.php

The line that included that file was removed when adding bootstrap
There are no calls to the only function defined in slideshow.js,
I think is safe to remove the file.

behatnotneeded

Change-Id: Iddcc6419a06cfccebdd3d243680ee653fd5cae2d

Maria Sorica authored Mar 09, 2018 and Robert Lyon committed Jun 20, 2018

Change-Id: I665d03d083e217647e00e64ab5573e263534276c

So that we only have one 'tag' table that holds all the tag information

behatnotneeded

Change-Id: Ieb83e61da45edddfa8703816c11f3658c5394c47
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This flag will set whether the function should
attempt to create the file if it doesn't exist.

E.g. image resizes.

This allows an external file system to call
get_local_path with this flag set to false to
skip the processing. This allows an external
file system to avoid an infinate loop when calling
get_local_path to check local file availibility.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: Iaade0b06fcc2cd1755467231e0bafea6b90a99ec

behatnotneeded

Change-Id: Ide581c47d02772478fe04a85673e8d72cdd919e0

If zipped up Leap2A files are uploaded containing files with viruses we need to
check them before finishing the importation.

Also we should check existing zipped files for viruses as well, eg:

1) Upload a zip file with virus
2) Turn on clamav
3) Try extracting the zip file

behatnotneeded

Change-Id: I7635deb5f69e6fdb60e89d11ddf9362bb7928994
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Alexander Del Ponte authored Mar 19, 2018 and Cecilia Vela Gurovic committed May 08, 2018

behatnotneeded

Change-Id: If9c4bfbc7e1113cd4de131712db821a048ba2136

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
 commit 2319c045

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2

A mistake made in the patch for Bug 1367539

behatnotneeded

Change-Id: If0b27c356887483532693153f0b8936b7d12eb14
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Currently there is a regex to append the view id to the embedded url
But it doesn't take into account the domain of the site

If you use a link from anther mahara it tries to append the viewid of
the page the link is being used in causing confusion

behatnotneeded

Change-Id: Iece12b1c993d53cdf48e13da16af1156e3ddc9e2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When the contenthash is missing

Also set the new orientation column as not null

behatnotneeded

Change-Id: I64de51a2a0f456ac54f7a47cbc6398fb1b588594
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch contains the following:
- created a relatedtags.php page + json file + template to handle the
viewing of related tags for a user, the differences for this to
tags.php page are:
-- it can be viewed publically
-- it requires a tag and viewid

- Adjusted the filters for blog/blogpost, plan/task so they appear
under their own filters as well as 'text' filter

- adjusted the dwoo function list_tags so that we can pass an array of
viewids/tags and/or just a view id

-adjusted the portfolio_search_* functions so they would work for both
my tags and related tags pages

- fixed a filter js problem for tags.php where choosing the filter was
not updating the displayed filter string

behatnotneeded

Change-Id: Ie3a2c3cb56e94ced0e021265bce88e35a9cfba5d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0

Robert Lyon authored Mar 08, 2018 and Cecilia Vela Gurovic committed Mar 13, 2018

for leap2a artefact import

behatnotneeded

Change-Id: Ib87c051c824c56a732d02ce83a5a6f0811e1df37
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ie27ddcacd606e038854c69a81fc147f0c4152bd2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I7fb2fa618719dd12d6b77177a9e1ad127ea175d2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Enables Mahara to save files to an external file system
- object storage (such as AWS's S3) -
which can reduce the cost of storage

Change-Id: I76822612f2922ba0ef2a0b7a4efb9cd2b96979a6

So saves as file name rather than 'document.pdf'
Also make en-GB the default english as 'en' is not an lang file for
the pdfjs

behatnotneeded

Change-Id: I320a141ce6c0a0734b9c0e21d6b933f5d99c238f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I059485a45e60926e650e67d02e3582d0c9e327bc

Cecilia Vela Gurovic authored Oct 03, 2017 and Robert Lyon committed Oct 31, 2017

removed code from htdocs/api/module/ files and replace it with a json reply error message.
removed the 'allowmobileuploads' config variable since it is only used by the old mobile api.
removed the 'mobileuploadtoken' values in usr_account_preferences since they are only used by old mobile api. The new mahara mobile uses external_tokens table to store its access tokens.

behatnotneeded

Change-Id: I02e94079fc83aa6a81534b70446f7e8ab2ebd7a4

About the danger of displaying big PDF files

behatnotneeded

Change-Id: I451c6daafc0d1fa537e4d3fdeb16d164be92ac0a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Rather than fetching by array now that we have multiple extensions
using the 'video/mp4' mimetype.

This would cause problems for older sites where the file was correctly
saved as 'video' artefacttype but where the fetching from db of the
mimetypes to compare would associate a different extension to
'video/mp4', eg 'm4v'.

This also meant that videos uploaded after commit
a5cf7d59

 could end up being saved as
atefacttype 'file' rather than 'video'

This patch fetches mimetypes as array and tidies things up for video

behatnotneeded

Change-Id: I53dc2d5ddb573d630f1de408cc9c027e488cd99e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So that they have artefact_file_embedded rows associated with them and
can display to non-admins

behatnotneeded

Change-Id: I477a910637ffc53e0e5be9ed44d0188f49b61bad
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>