GitLab

(#3404) Flip function arguments order around for constructor of LeapExportElementResumeCompositeSibling.

This matches everwhere that it's called. The bug never manifested itself
because we were quashing the E_RECOVERABLE_ERRORs caused by passing
invalidly typed arguments. Though it probably would have died on PHP
5.1.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

On PHP 5.1, this was causing a fatal error when it was hit.

On PHP 5.2 or greater, this causes an E_RECOVERABLE_ERROR. Due to a bug
in Mahara's error handler, such errors were being squashed so we never
saw them. Whoops!
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Prevents Dwoo warnings as spotted as part of fixing #3404.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This makes the watchlist stuff (and potentially other stuff on this
page) work again.

Spotted by Sam Timofeev on the forums.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Strangely, this didn't appear to be broken in IE8 with IE7 compatibility
mode on.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This leads to improved user experience.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This reverts commit 246bdfec.

This reverts commit 8824fa29.

Rewrite xmlrpc jump links by regex in all email notifications; remove url from link contents in forum post html email (avoids thunderbird scam warning)
Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

NOTE: not signed off deliberately, I'm testing the commit hook.

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

(not tested, I couldn't find anywhere that used it)

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>
(cherry picked from commit 7aee42de)

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Andrew Robert Nicols <andrew.nicols@luns.net.uk>

It's no where near as good as it was.. sigh.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Broken by Penny cleaning up Smarty->Dwoo transition stuff.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

for some reason there's completely weird data here, which results in no
firstname or lastname displayed

Mainly cos they don't any more, Richard removed it on September 17th.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

We now have a nice import screen in the admin section :)
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Instead of using a fixed platform-specific path for temporary image files,
create a new temporary directory inside dataroot and place temporary files
there.

In addition to it, make sure we prefix the profile icon file names with 'mpi_'
(stands for mnet profile icon) to prevent clashes (as per Nigel's suggestion)
and check the return result from file_put_contents() for errors (but otherwise
and continue gracefully if the file can't be written, as Nigel suggested on the
bug tracker).

While in this particular case the related code takes care of the temporary
files, if we are going to have a temp directory, it might be good to have a
cronjob to clean it out (We should file a bug to remind us to do that)

[Minor whitespace fixups by Nigel]
Signed-off-by: Iñaki Arenaza <iarenaza@eps.mondragon.edu>
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Conflicts:
	htdocs/lib/web.php

Inaki's patch had changed the smarty function to add httpswwwroot.  I
moved this to lib/dwoo/mahara/Dwoo_Mahara.php