GitLab

* changes:
  bug 1555407 - Fixed overlapping carousel in collapsible block
  bug 1570667 - Fixed carousel styles - chevrons are now on the sides of the image - caption is below the image instead of on top

They need to  be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit c5eb6088)

To allow for quicker loading of the block for power users that have
many item on their watchlist

behatnotneeded

Change-Id: Ia504071b0315baf3b7c9b5ad2ec1277813779ae4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 940f6cd9)

behatnotneeded

Change-Id: I105728bdc5ed9c500e86efc99965c3936e543f17

- chevrons are now on the sides of the image
- caption is below the image instead of on top

behatnotneeded

Change-Id: I145a81fd06ae92580a541dd3ade55fcd6ab1d000

behatnotneeded

Change-Id: If377cc507a3ee524ffe28d72b87c3f906a045812
(cherry picked from commit 0ebe822b)

To avoid lines in error log

Behatnotneeded

Change-Id: I7024d0c1aa764d27c7d3a03dc8c01ae2e6031562
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit f600592d)

When paginating then searching

See bug for testing info

behatnotneeded

Change-Id: I344cdfe28aee0f8182cfa6214f4dd9611f5666c1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8d571ebb)

behatnotneeded

Change-Id: Iedc0bec19d31501104b9b63adf786147cf1c6321
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8d6a0458)

Bug 1548130

As they are more nicely styled - for consistency

behatnotneeded

Change-Id: I1b0795e17bcf1fb61b7a169e27971a3e80d243cf
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6dbc2452)

And also indent it to fit with the thread flow

behatnotneeded - style change

Change-Id: Iad7e9e22c05e36b7d9910e1640fd58110209b27a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b1ec6f43)

Replaced by a span tag to hold the back to top position

behatnotneeded - documentation page only

Change-Id: Ida26a48d1b17130418ddbbe65140972fac592ed0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9de226aa)

behatnotneeded

Change-Id: I1aa52a076843ff0dc4dcaf86a01e76b9673885b5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0a6860a9)

behatnotneeded - issue with older versions of php

Change-Id: Ib732c593a1bbd37bf35cd747b9b57c992b8c1681
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 82086002)

1) Allowing $CFG to accept json encoded strings and to be decoded back to php
2) Making the $cfg->openbadgedisplayer_source a json encoded string
3) Allowing the openbadges have the defaults only on one place and warn when they are missing

behatnotneeded

Change-Id: Ica0349d6343d9f608b2272117d7412b288799278
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit af64abec)

When the block needs to copy child artefacts. Another instance where
we don't include all the plugins on page load anymore.

behatnotneeded

Change-Id: I231325e0f17091da68fbd7a88d7882342f5a5d68
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit c8252bcc)

behatnotneeded

Change-Id: Ib0c69ba2b0b740b934206b6337bcc02a3f155abb
(cherry picked from commit 17d51bba)

behatnotneeded

Change-Id: I2c7b76e1b62a1c9524bb177d1485cc7edb7352b0
(cherry picked from commit 862bd72d)

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit fb330e38)

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

And tidying up a hardcoded string

behatnotneeded

Change-Id: I6f42d57adf414c94b6522602742c4f36d4d7367f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded - unable to test other languages

Change-Id: I417b1b1bd8fd8dcddcd1c7277d2da83d2c3c6f8e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8d58e3a6)

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 4993ce1c)

Rather than having an increasing list of specific parameters
that we know to have passwords, this patch censors the content
of any parameter with a name that contains the string "password"
or "pw".

behatnotneeded: Can't test with Behat

Change-Id: Ifaa2ec10cf749c173b1a8d0928c6cc052124a83f

An oversight when making the change to remove group_homepage_url()
from templates.

behatnotneeded

Change-Id: Icf1eefe1f8e97e4040c61ac7321d944f02a62df1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 45329751)

behatnotneeded

Change-Id: I7f4f040abb6e9989eac6077ed28f946c44813927
(cherry picked from commit 9c0cb45a)

We have existing code that tries to regenerate your
session ID when you log in. But it stopped working
in PHP 15.04 because the session has usually been
closed when it gets called.

Change-Id: I5f99cdf355892040866bb0113fd934e3d37bf33c
behatnotneeded: Can't be tested by behat
(cherry picked from commit a923f51b)