1. 22 Dec, 2020 4 commits
  2. 21 Dec, 2020 2 commits
    • Rebecca Blundell's avatar
      Bug 1897190: Improve behat properties file structure · 3f82f722
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed
      rewrite properties file and functions to make structure
      easier to manage:
      - add multiple arrays to split up properties by category
      - modernise PHP syntax to use array constants
      - fix location option to work properly
      - remove need for xpath/css to be specified in arrays,
      by adding set_selector_type()
      - remove unused function and add others as required
      - update tests to call properties, not css/xpath
      - add check for null return from  get_property() and
      throw ExpectationException for property if null
      
      Change-Id: If64a5a1ed1a572b8eadcf91dd9f7a87bcf621d7c
      3f82f722
    • Robert Lyon's avatar
      Bug 1908858: Admin's profile page access not correct · 1c07c4be
      Robert Lyon authored
      
      
      When the admin is within an institution.
      The institution name is being displayed as 'Shared with'
      
      This is due to an error in the fix for Bug 1501133
      
      Also an issue with stop/start dates - removing obsolete check
      
      Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      1c07c4be
  3. 19 Dec, 2020 1 commit
  4. 18 Dec, 2020 1 commit
    • Kevin Dibble's avatar
      Bug 1803101: peer assessment artefact import · 6d19103a
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed
      Need to define owner and block when creating a
      peer assessment artefact while importing
      
      Create a temp block to assign on artefact creation
      that later needs to be replaced by the actual block
      when it's available
      
      Draft assessments should not be exported or imported.
      For exported portfolios created on older version of
      Mahara, there is no way of knowing if they are drafts
      at the moment of importing because this information
      was not included in the leap2A export xml file.
      Not importing draft peer assessments should work
      from this patch.
      
      It also adds a fix to support
      Postgres and MySQL when a table
      column name is a reserved word.
      
      Removing not null restriction for "usr" field in "artefact_peer_assessment"
      table:
      - The author in peer assessment table should be working as comments table.
      - For each comment, there is an entry in 'artefact' table that contains
      author and authorname, and another entry in 'artefact_comment_comment'
      that doesn't have an author field
      because we already have one in 'artefact' table.
      - We should have something similar on 'artefact_peer_assessment'.
      There is already an author field in 'artefact' table,
      then the 'usr' field in 'artefact_peer_assessment' should not to have a
      'not null' restriction. If the peer assessment artefact has been imported
      and the author is not present in this site, then the 'usr'
      should be allowed to be null.
      
      behatnotneeded
      
      Change-Id: I182520159d1fcbc072081c2d976cdc68cde5e19d
      6d19103a
  5. 17 Dec, 2020 1 commit
  6. 16 Dec, 2020 2 commits
    • Robert Lyon's avatar
    • Doris Tam's avatar
      Bug 1866779: moving watchlist delay notification settings · 5d55b90c
      Doris Tam authored and Robert Lyon's avatar Robert Lyon committed
      Moving the watchlist delay notification setting from site options from admin settings
      to plugin administration under blocktype.
      
      - Moved strings to the blocktype.watchlist lang strings area.
      - Removed a set_config call in upgrade.php and added a post_inst method
      following other blocktype plugin  post install calls instead.
      
      - Upgrade step to transfer over old site setting 'watchnotification_delay'
      to plugin admin, updating the version number too
      Change-Id: If388ddd083ceb8f46026fdc138f27ca8c8da5b04
      5d55b90c
  7. 09 Dec, 2020 1 commit
  8. 08 Dec, 2020 3 commits
  9. 07 Dec, 2020 2 commits
  10. 06 Dec, 2020 5 commits
  11. 03 Dec, 2020 2 commits
  12. 02 Dec, 2020 1 commit
  13. 01 Dec, 2020 2 commits
  14. 30 Nov, 2020 3 commits
  15. 27 Nov, 2020 1 commit
    • Robert Lyon's avatar
      Merge changes Ib98a90e4,I70d54e89 · 6deb237e
      Robert Lyon authored
      * changes:
        Bug 1904949: removing old duplicate lang pairs.
        Bug 1899855: Created lang strings for hardcoded string literals in webservices/functions
      6deb237e
  16. 26 Nov, 2020 4 commits
  17. 25 Nov, 2020 5 commits