1. 25 Sep, 2019 2 commits
    • Lisa Seeto's avatar
      Bug 1827811: Embedded Media Task · b82df03d
      Lisa Seeto authored
      
      
      add the block-header to the block.
      remove the download link from page as it now shows in the modal.
      add artefactid and blockid to image.tpl
      fix issue with data-toggle collapse targeting syntax error.
      update  active block functionality for block headers
      update block-comments-details-header.tpl for icon headers
      fix Journals, and tagged entries and recent posts to use icons for block header.
      change pdf block to use block header icons
      clean up .comments-details class that is no longer needed.
      add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
      add modal functionality for some html block, clear up js for icons that is no longer needed.
      add title text to icons and block-header
      create activateModalLinks() func to tidy up js modal click events in view/view.php
      
      Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      b82df03d
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      
      
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  2. 17 Jul, 2019 1 commit
  3. 04 Apr, 2019 1 commit
  4. 30 Sep, 2018 1 commit
  5. 06 Sep, 2018 1 commit
  6. 09 Aug, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1785938: Fixing gallery and changing slimbox2 to fancybox3 · 66e7468a
      Robert Lyon authored
      
      
      Things done with this patch:
      
      1) Changed the 'Use photo frame' option from being a plugin variable
         to being an instance config variable
      
      2) Added back in the css for the giving the gallery images photo frame
         borders
      
      3) Get the non-square thumbs to render correctly spaced on load
      
      4) Swapped the slimbox2 to fancybox3 and allowed the block itself to
      control when to put content into head data
      
      behatnotneeded
      
      Change-Id: I397be45f2347588988b663b25b560d8ab876afe1
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      66e7468a
  7. 25 Jan, 2017 1 commit
  8. 18 Oct, 2016 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1181696: Reorder images in gallery when renaming files · 8662adc9
      Cecilia Vela Gurovic authored
      Check the filename when displaying an image gallery
      and show images in alphabetical order.
      The same ordering function is used as the Content/files
      view when displaying the files.
      This can be easily undone when bug 732462 is fixed.
      
      behatnotneeded
      
      Change-Id: I795e4f606e570f0088a21a4404fbf8a4c5249998
      8662adc9
  9. 21 Jul, 2016 1 commit
  10. 15 Jul, 2016 1 commit
  11. 11 Jul, 2016 1 commit
  12. 23 Mar, 2016 1 commit
  13. 25 Nov, 2015 1 commit
  14. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  15. 07 Oct, 2015 1 commit
  16. 08 Sep, 2015 1 commit
  17. 15 Jul, 2015 1 commit
  18. 01 Jul, 2015 1 commit
  19. 15 Jun, 2015 2 commits
  20. 28 Mar, 2015 1 commit
  21. 12 Mar, 2015 1 commit
  22. 26 Feb, 2015 1 commit
    • aceMa's avatar
      Do square thumb images while preserving ratio (Bug #1397005) · a3f12ab1
      aceMa authored
      
      
      I've taken what aceMa provided in bug report and made it a replacement
      for the square thumbs option rather than a new option as we don't need
      two square thumb options.
      
      I've tweaked it a bit more and hopefully have got the padding/ratio
      stuff more consistent and not using hardcoded numbers so much
      
      And getting it to show descriptions/captions below frame
      
      Change-Id: Iafc0ec8a8132d1bef5401b3ebd49e3df013fddc3
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a3f12ab1
  23. 04 Feb, 2015 1 commit
  24. 28 Jan, 2015 1 commit
    • Robert Lyon's avatar
      Don't expand the comment lists on page edit screen (Bug #1317343) · 1b663910
      Robert Lyon authored
      
      
      This was causing some problems with tagged posts
      - also hiding the 'add comment' link on page edit screen.
      
      And making the comments info show when no comments were on item and
      allow comments for artefact was enabled. This is an issue with newer
      versions of php.
      
      Also placing some of the template files in the new correct location
      
      Change-Id: I599e16b0899559a3ebcdf68cff53220b1d83f2d6
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      1b663910
  25. 04 Dec, 2014 1 commit
  26. 03 Dec, 2014 1 commit
  27. 16 Nov, 2014 1 commit
    • Robert Lyon's avatar
      Adding comment display to image gallery artefact (Bug #1037531) · 34025e76
      Robert Lyon authored
      
      
      This is only for the displaying of a folder as a gallery
      in either the thumbs, square thumbs, or slideshow.
      
      The allow comments is based on the allowing the folder to have
      comments so this means any folder comments will display whether they
      have been added following the link in gallery block or the folder
      block as both end up at the same artefact on artefact/artefact.php page
      
      Change-Id: I787a730861823ef3f731fb5209bf3470b00a7ed3
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      34025e76
  28. 13 Oct, 2014 1 commit
  29. 01 Sep, 2014 1 commit
  30. 15 Jul, 2014 1 commit
  31. 09 May, 2014 1 commit
    • Yuliya Bozhko's avatar
      Some artefact refactoring (Bug #1298646) · 3ba72d71
      Yuliya Bozhko authored and Robert Lyon's avatar Robert Lyon committed
      
      
      Fixes in this patch:
      
      - Moved artefact.php to artefacts directory to separate it from pages.
      - Fixed reference to a wrong 'artefactonlyviewableinview' string.
      - Removed add_to_render_path() and its calls which have no purpose at all.
      - Removed 'artefact_parent_cache' table.
      - Removed cron jobs related to 'artefact_parent_cache' from DB.
      - Added 'path' column in 'artefact' table to easier calculate hierarchy.
      - Added ArtefactTest.php for artefacts unit tests
      
      Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
      Signed-off-by: default avatarYuliya Bozhko <yuliya.bozhko@totaralms.com>
      3ba72d71
  32. 11 Feb, 2014 1 commit
  33. 07 Jan, 2014 1 commit
  34. 23 Oct, 2013 1 commit
  35. 14 Oct, 2013 1 commit
  36. 07 Oct, 2013 1 commit
    • Robert Lyon's avatar
      Problems with image gallery and file/folder selection · 2d855e68
      Robert Lyon authored
      
      Bug 123530 and Bug 1236122
      
      When js slideshow was chosen on a page without a slideshow block
      (eg a new page) the js code returned by the selection was not loaded
      fast enough
      
      - I've altered it so the js is loaded on opening of config block
      
      - Also folder was not staying selected when re-editing the block
      due to it being not ArtefactTypeFile - have adjusted the check to
      include ArtefactTypeFolder as well
      
      - The switching between My files and Site files was breaking due to
      folder artefact chooser not having certain elements on the page that the
      js was trying to access. Have made it so js checks for elements before
      trying to update them.
      
      Change-Id: I9b8cbe786b0d35109f05a664f04665e9a9967d92
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      2d855e68
  37. 02 Oct, 2013 1 commit
  38. 09 Sep, 2012 1 commit