GitLab

This is kinda important if we want icons for rss feeds to work! :)

Conflicts:

	htdocs/blocktype/externalfeed/version.php

Getting rid of the lines that set the style of the clones to be dragged around seems to work. They don't seem to be necessary anyway.

This patch makes most blocktypes have no title set by default when created. For those that used to set their own titles, if no title is set after the configuration form is submitted, then they get the chance to set the title.

So for example, the RSS block will start with an empty title, but if the user doesn't set it, the title will be the title of the feed that is being syndicated.

Blocks like 'textbox' still keep their defaults, because they don't have any special case way of setting their own titles.

This used to work, but for some reason the code for it has disappeared. The links to edit and delete a view have disappeared from the 'My Views' page, but you could still visit the pages directly. Now that has been locked down.

Before this wasn't happening, so if an administrator created a group, then later edited it and turned it into a controlled group, the group would have no tutors.

* You can now configure whether you want to see just a brief summary of the feed, or the feed in full
* If the description is the same as the first item (Google News is stupid like this), then don't show the description
* Show the feed icon with the feed (regardless of whether it's brief or full mode)
* Show an RSS icon which links to the feed itself so other people can subscribe to it
* Only fetch the first 10 items of a feed, not the first 11. Not sure why the code thought that only 10 were being fetched...

It now lists the sites from which users can embed videos. It also explicitly states you can use the 'embed code' the sites provide. You always could, but now everyone will know.

This fixes issues we've seen in many browsers where the videos wouldn't be displayed properly. It seems that in most (but not all!) combinations of browser, flash version and operating system, a pixel width and/or height is necessary to force the video to display.

Whether it worked or not seemed to vary from computer to computer without too much pattern.

Now with more instructions for confused users.

New sentence gives more immediate instruction. The meaning has changed, so the language string key has changed.

This means that the bottom-pane always has a consistent height, even when dragging blocks into an empty view.

It works in ie7. Many people died to obtain this vital information.

For some strange reason, where setStyle used to work in IE7 it doesn't any more. It might just be Martyn's IE though.

Previously, the code was only making sure whitespace was removed, but other parts of Mahara depend on this field having only alphabetical characters.

Now the code makes sure only alphabetical characters are in the string, and will cycle through the letters a - z attempting to generate a new institution name if the one generated is already taken.

If someone needs more than 26 peers all with the same name... well tough :)

As pointed out in the bug, there's more reasons to not do it than there are to do it.
(cherry picked from commit b65afd98)

Prevent warnings if the xmlrpcmaxservertimedifference configuration setting isn't set - which will mostly be the case.

Now they say that you can enter whatever you like. I also removed a bunch of helpfiles that aren't used any more.
(cherry picked from commit 6572a552)

Instead, generate a list of users who we could not send e-mail to, and display this to the uploaded, with more detailed reasons in the server error log.

Also, put a line in the .htaccess file to turn allow_call_time_pass_reference off. This way we'll never be caught by this issue again, not because php will not warn about it, but because developers will see these types of problems and fix them.

Use it in check_dir_exists, to set the permissions of directories created in dataroot.

Directories used to be created 0777, which is unnecessary unless the user is on shared hosting and needs to download their dataroot at some point later (which they will do for backup purposes).