GitLab

This was mostly right but the json bits were not hooked up
Also fixing layout of table to be more like a similar
table, User -> Search

behatnotneeded

Change-Id: I9b29c8cc780535efae5b74b4f1eedb60d2227625
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Includes:
1) Group -> my groups
2) Group -> find groups
3) Admin -> Users -> Suspended ...
4) Admin -> Group
5) Content -> Journal -> entries list

This is also to standardize pagination

behatnotneeded

Change-Id: Iad9edc668b3f5f8e8c71408c842cbf28a69fa2f4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

It was trying to pass an unset $userid - which should really be the
owner of the dashboard page's id

behatnotneeded

Change-Id: I8886f37275b0b7ff9be823a0c3f2b271baf67afc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I9f2534a11a71f6c356ee836db1386a0c1bbebf8d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 6 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I70f77d04efa55a14680da5427acc1310b517ec3b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 5 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I7f0160df6459b96006febbca9d8d57cf26c3ed7f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 4 of 6 patches to standardize pagination

behatnotneeded

Change-Id: If89d7a800e4d76c6ec6e7dc44c3b69c73dee9952
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 3 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I4c563a83ee70b24fc0111fe200a3b2d4514b9590
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 2 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I7741ae0d436d7e11fe248307936757d3d8027cc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is one of 6 patches to standardize pagination

To help test this there is a zip file in Bug 1515774

behatnotneeded

Change-Id: I278ae35cdbe83929cd8eca2b28d1191cab5c3ea6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* changes:
  Bug 1514374: Fixing pagination in a number of places
  Bug 1515431: Missing templates for the group report page

behatnotneeded

Change-Id: I99756d283512b930464d6d98f9760cb749adf0ff
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Set the state of the libxml entity loader & use internal
errors settings, back to what they were before we called
them, as a workaround to https://bugs.php.net/bug.php?id=64938,
which causes them to be shared by all threads in a single
process.

behatnotneeded

Change-Id: I0720146b1e91c24095a18636e09981830ef4ce8f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Problem is we need to do a type comparison when checking how to apply
the title as group/institution pages have owner as null

Change-Id: I0a9128e329f180f1a8fbacae7803e38159f6f88a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1515929: Usually when we use get_record(), we're
querying against a record that has a uniqueness constraint
guaranteeing that it is unique, in which case the PHP
code that dies on non-uniqueness is redundant.

In the remaining cases, we're dealing with records
that for some reason can't have a uniqueness constraint,
and the dying just causes the site to entirely stop
working, when it would be more useful to have it continue
to work but throw a warning message to the logs.

behatnotneeded: Covered by existing test cases

Change-Id: I264f72e3a8904293d78909410f68b29f2c78db3c

Bug 1510421

Defines a new static PluginBlocktype method, get_css_icon(), which
fetches the name of the CSS icon to use for this blocktype. It returns
false by default, which tells the theme to "fall back" to the old
thumbnail.png instead. 3rd-party plugins can override this to
specify a particular icon to use.

All the core blocktypes have been refactored to extend
MaharaCoreBlocktype, which uses the blocktype name as the name
of the CSS icon to use. I also deprecated the "SystemBlocktype"
class while I was at it.

PluginBlocktype::get_blocktypes_for_category() now returns both
the results of get_css_icon() and the thumbnail.png path, so that
themes can decide which they want to use. (And of course
thumbnail.png is served via thumbnail.php, so 3rd party themes
can provide their own custom image files if they wish.)

behatnotneeded: Requires installing third-party plugins to test

Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0

Rewrite to use ensure_record_exists instead of re-inventing
the wheel.

behatnotneeded: Covered by existing tests

Change-Id: Id57be0e00f14ab65dd40b4ef13f696e72f608d46
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1518796

behatnotneeded: Covered by existing tests

Change-Id: I996e4562441140a6163dbf0b9dff4ee2894ffd83