Skip to content

GitLab

Switch branch/tag
  1. 22 Oct, 2013 1 commit
    • Robert Lyon's avatar
      Allowing pieform error text to not be escaped if needed (Bug 1239539) · bd33b9c8
      Robert Lyon authored 
      Currently if there is html in an error message used by pieforms it
escapes the html so the link becomes not usable.

I have made a change where you can tell pieforms not to escape the
error message.

So instead of using:
$form->set_error($field, $message);

you can use:
$form->set_error($field, $message, false);

Where false means do not escape the message.

As the terms and conditions are displayed on the page already I've
updated the link to jump to the terms section

Change-Id: Ia8650a9f2284fb007cbe81a4a94223f127c4f6cd
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      bd33b9c8
  3. 08 Oct, 2013 1 commit
    • Aaron Wells's avatar
      Update session-cached display name when deleting it · 6ecbe067
      Aaron Wells authored 
      Bug 1223063: ArtefactTypeCachedProfileField was only updating
the session cache when you updated a value, not when you deleted it.
Of course, the only one that can get deleted and that is shown
anywhere is the PreferredName (aka display name) so only this
one shows the problem.

Change-Id: I55f9c96b59c91ced5cba3cf6443ba2e222201ef7
Signed-off-by: Aaron Wells's avatarAaron Wells <aaronw@catalyst.net.nz>
      6ecbe067
  5. 02 Oct, 2013 8 commits
  7. 01 Oct, 2013 3 commits
    • Kristina Hoeppner's avatar
      Add alt and title tag for blocks (Bug #1218684) · 971fa738
      Kristina Hoeppner authored 
      IE only picks up the alt and not the title
tag. I added both so that users will see the
description.

Change-Id: I2f1c9342363d3372e5aa1549da7fcfc3086177b1
Signed-off-by: Kristina Hoeppner's avatarKristina D.C. Hoeppner <kristina@catalyst.net.nz>
      971fa738
    • Kristina Hoeppner's avatar
      Add missing lang string for warning (Bug #1227372) · e147f3c9
      Kristina Hoeppner authored 
      Lang string was missing for "Allowed iframe sources"

Change-Id: I1cab612134a334fac7f0ca54fcf406b4a08f3226
Signed-off-by: Kristina Hoeppner's avatarKristina D.C. Hoeppner <kristina@catalyst.net.nz>
      e147f3c9
    • Hugh Davenport's avatar
      Fix permissions of group area (Bug #1034180) · f5cebdef
      Hugh Davenport authored 
      A user should not be able to view/publish an artefact if
- they don't have view/publish permission of that artefact
- they don't have view permission of all parents of that artefact

A user should not be able to edit an artefact if
- they don't have edit permission of that artefact
- they don't have edit permission of the immediate parent of that artefact
- they don't have view permission of any parents below the immediate

This is similar to the UNIX permissions, you shouldn't be able to view
a directory unless all directories below have read (r) and executeable (x)
bits set. The same for editing, you need write (w) permissions of the
immediate parent, and rx for all parents.

In Mahara, there are no executeable bits, but it can be assumed
that view is basically the same as rw for container artefacts, and the same
as r for non container artefacts.

Change-Id: I4f84aca05dd08d02b05fbe084e4724f78c8681a0
Signed-off-by: default avatarHugh Davenport <hugh@catalyst.net.nz>
      f5cebdef
  9. 24 Sep, 2013 1 commit
  11. 22 Sep, 2013 1 commit
  13. 19 Sep, 2013 1 commit
  15. 16 Sep, 2013 1 commit
  17. 04 Sep, 2013 1 commit
  19. 02 Sep, 2013 1 commit
  21. 29 Aug, 2013 1 commit
  23. 27 Aug, 2013 1 commit
  25. 23 Aug, 2013 1 commit
    • Aaron Wells's avatar
      Reduce false positives in syntax checket for unbracketed SQL tables. · d6f0092f
      Aaron Wells authored 
      Bug #1215702
This one gets me a lot of false positives, so I'm changing the message to explain
that it's triggered by the words "from" and "join", and make it so that it doesn't
perform this check on lines that are probably comments

Change-Id: I5d1acc5eed0a31acc0a570b9bdac564ca514707f
      d6f0092f
  27. 22 Aug, 2013 1 commit
    • Aaron Wells's avatar
      Correct Mahara 1.6 version number · cf3deb95
      Aaron Wells authored 
      The patch for Bug #1207140 erroneously raised the Mahara 1.6 version number too high.
Mahara versioning policy says that version numbers within a stable branch should only
increment by 1.

Change-Id: Iedcca7281494f4826df60621fe48df0cba4f36e1
      cf3deb95
  29. 20 Aug, 2013 3 commits
  31. 24 Jul, 2013 3 commits
  33. 23 Jul, 2013 1 commit
    • Robert Lyon's avatar
      Fix for bypassing moderation when making comment public (Bug #1171310) · 1b5babb0
      Robert Lyon authored 
      To get a private -> public comment moderated the system needs to check:
* if the view has approvecomments set to 1
* if the submitter has checked the make public checkbox
* if the submitter is not the owner of the view
* if the view is a group view
* if the approvecomments are set per view

And update the comment table accordingly and now sends off notify
message if needed.

Removed some unneeded variable declarations

Change-Id: I74d44f5dab6442c2cae11df1dc588bd753471f8e
Signed-off-by: Robert Lyon's avatarrobertl <robertl@catalyst.net.nz>
      1b5babb0
  35. 12 Jul, 2013 1 commit
    • Robert Lyon's avatar
      Fix for bulk user change auth method problem (Bug #1180194) · 7d6ab3e3
      Robert Lyon authored 
      The auth_remote_user db table was not being updated correctly when
users were being moved from one auth method to another in bulk.
Fix adds in the correct lines to that table. Code similar to what
is used in admin/users/edit.php for single user update.

Moved some things around to improve performance and fixed a mistake

Change-Id: Ieb2d453bc06646444aadaff92ea5b42af4246411
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      7d6ab3e3
  37. 01 Jul, 2013 3 commits
  39. 10 Jun, 2013 1 commit
  41. 05 Jun, 2013 3 commits
  43. 13 May, 2013 1 commit
  45. 02 May, 2013 1 commit