Skip to content

GitLab

Switch branch/tag
  1. 08 Feb, 2012 2 commits
  3. 07 Feb, 2012 29 commits
  5. 06 Feb, 2012 4 commits
  7. 03 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Fixes for microheaders in stylesheets · 7a882ad1
      Richard Mansfield authored 
      

Some recent changes to the main stylesheets have resulted in themes
not being correctly applied when "Small page headers" are turned on.
First, the addition of a body#micro rule for background colour in the
raw theme was inherited by all the child themes, when it needs to be
overridden.  Also, some rules were using the main-column id rather
than the main-column class.

Change-Id: Iea21ff4dff71ebc85a2020bca900da1e344dfa8d
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      7a882ad1
  9. 02 Feb, 2012 2 commits
    • Richard Mansfield's avatar
      Remove unnecessary sanitisation from forum notifications (bug #882894) · 1c022eed
      Richard Mansfield authored 
      In commit 93c012f2

, the forum and group name were added to the body
of forum post email notifications, each wrapped in a call to
clean_html (htmlpurifier).  This crashes cron due to out-of-memory
errors whenever there are more than a few subscribers, and stops
notifications from being sent out at all.

The forum and group name only need to be rendered once per forum post,
so this could be fixed by moving the clean_html call up to the
activity constructor, rather than doing it in the get_emailmessage,
get_htmlmessage functions.  These functions get called for every
single subscriber notification, to ensure the string is displayed in
the subscriber's language.

But because group and forum names are never rendered as html, we don't
need to use htmlpurifier - html escaping is more appropriate and less
memory-hungry.

Change-Id: I0a4133b0a11e0e0004bdab1c29984ab4fc5dfbbf
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      1c022eed
    • Richard Mansfield's avatar
      Fix remote avatars broken by 'profileiconbyid' commit (bug #924777) · ab3b5a19
      Richard Mansfield authored 
      Commit 011c5039 changed lot of thumb.php urls to use the
type=profileiconbyid parameter (which takes an artefact id) rather
than type=profileicon (which takes a user id, and which cannot be
cached).

Unfortunately, when a user has no locally stored profile icon, use of
type=profileiconbyid stops their remote gravatar image from being
displayed.

This commit updates the thumb.php urls that were changed in commit
011c5039 to use the profile_icon_url() function, which respects
remote avatars when no local profileicon is available.

In some cases this requires a new size of the no_userphoto.png image,
so three new sizes are added in the raw theme.  The four no_userphoto
images in the custom theme were duplicates of those in raw, and are
removed.

Finally, the type=profileiconbyid change from commit 011c5039

 in the
viewacl.tpl template has been reverted back to type=profileicon.
Because this url is constructed in javascript, it is not worth the
trouble to use a profile_icon_url call here until the number of
requests to thumb.php really becomes a problem.

Change-Id: I7dce7090842999fe090dc2d8c481cb4aca7720d5
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      ab3b5a19
  11. 01 Feb, 2012 2 commits