- 25 Sep, 2019 1 commit
-
-
Lisa Seeto authored
create modal using configureblock id, update various templates to use the modal for blocks: Image Note File(s) to download Journal/blogs add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments. add JS to handle url that redirects to view/view.php with modal open and populated. Further changes to each block will be completed in child patches. Add segment headings to the modal. Fix display of comments to cover width of modal. Show comment removed msg in modal/page appropriately. Fix behat test to close modal before continuing. do not show existing comments if comments not allowed on artefact. add validation to modal for comments/attachments disable image as link when editing for image block trigger focus on modal for accessibility close modal on escape keydown event fix merge conflict in view/view.php fix merge conflict with master make configureblock modal play nicely when comment block is on the page update display of error messages to always show at top of modal so user doesn't have to scroll add accesibility to close modal on escape key down handle dock show/hide events for paginated pages in modal during validation create block-comments-details-header template file create details button and custom scss file with js to show and hide header update comment links to save add comment and details when commentcount == 0 add active-block class to colour the block-header when active toggle the details-btn active css add _block-comments-details-header.scss to patch change class invisble to class d-none add block-comments-details-header.tpl to blocktypecontainerviewing.tpl code review changes add .no-modal class to links on group home page, dashboard and profile page. add block header to appear above the title change assessbtn from anchor tag to button to prevent scrolling. make all clickable links clickable on page load (ignore assess mode) fix js issues surrounding assessbtn move and show/hide blocks change cursor on dashboard, my profile page, group homepage to default when over disabled modal links update assessbtn to details btn create tooltip for hover over file download block titles fix containerElm console log error by not reattaching tinymce unneccessarily. fix null named attributes issues on e.target when span (icons) instead of anchor is clicked. Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e Signed-off-by:
Lisa Seeto <lisaseeto@catalyst.net.nz>
-
- 23 Sep, 2019 2 commits
-
-
Evonne authored
An issue with flex on IE11 where flex item has a max-width, the fix sets the min-size in flex-basis to 0% instead of 25% so that it grows to fit. behatnotneeded Change-Id: I719acbc6db578444d0621cb4f660cb2226d8960b
-
Robert Lyon authored
Making it a db_table_exists() call instead behatnotneeded Change-Id: I5206657a7e76a96dbe878147e07d42a241790764 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 20 Sep, 2019 6 commits
-
-
Robert Lyon authored
-
Robert Lyon authored
-
Robert Lyon authored
-
Cecilia Vela Gurovic authored
* changes: Bug 1827445: Check if a table exists in a quicker way Bug 1827445: Check if a table column exists in a quicker way
-
Robert Lyon authored
Without needing to include the lib/ddl.php file, and create the xmldb table objects We do this by trying to query the table to return one value and capture the SQLException if it doesn't exist The places changed are where we don't manipulate the table - so have left upgrade places the same as we will need to do things the ddl.php way anyway behatnotneeded Change-Id: Ic38cee95a221a22e644370b308356cf687a1e831 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
Robert Lyon authored
Without needing to create the xmldb table / field objects We do this by trying to query the column and capture the SQLException if it doesn't exist behatnotneeded Change-Id: I0a15dd4d1d4e47e6650576c084ee9e1d36b4ae62 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 19 Sep, 2019 10 commits
-
-
Cecilia Vela Gurovic authored
-
Cecilia Vela Gurovic authored
-
Cecilia Vela Gurovic authored
-
Robert Lyon authored
Change-Id: Ibcb5347254055002c0102dd3f62c4932c9ddefdb Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
Robert Lyon authored
-
Robert Lyon authored
-
Mitsuhiro Yoshida authored
behatnotneeded Change-Id: Ie65a2da1c4a6dadb05fb46d00feefb39a09bd754
-
Robert Lyon authored
-
Lisa Seeto authored
- put consent button in own div so it always displays - add description as info text underneath the button - change wording/ styling on modal buttons - Added in newline for accountsuspended string as it wouldn't ignore the <br /> tag - change name of confirm-no-button to suspend-account-btn for clarity Change-Id: I1ca009a76b1b3243512f6b9658439c111f2b80f0 Signed-off-by:
Lisa Seeto <lisaseeto@catalyst.net.nz>
-
Robert Lyon authored
-
- 18 Sep, 2019 8 commits
-
-
Robert Lyon authored
-
Robert Lyon authored
-
Robert Lyon authored
-
Matt Clarkson authored
Change-Id: Ib0a677db1b04b328f0e679cffa0c4d52fa52ecee
-
Robert Lyon authored
By making a fonttype mixin behatnotneeded Change-Id: I4f0938795c3b5f8ab93751915227d0c5370ba48f Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
Robert Lyon authored
Merge "Bug 1839223: When creating a page via tags, the copied blocks have the wrong text for the tags"
-
Evonne authored
When on a small screen, the add blocks button in the floating menu on edit page has a gap on the right. Fix adds 100% to the button and its wrapper so it will fill up the space just like the buttons below it. behatnotneeded Change-Id: Ia20003a4a8115ac6edae5a1d4ac8a4e00557c2de
-
Evonne authored
Some pages like user profile page where there the content is short, the previous patch made the content vertically center in the main-content div. This fix gives the div flex: 1 to tell it to not do that. behatnotneeded Change-Id: I4f8951d799fdbfcb397e46e99592f3f6bd13347e
-
- 16 Sep, 2019 1 commit
-
-
Kristina Hoeppner authored
Fixed the spacing in the notification to make it more consistent with other mails. Also fixed the subject where only "page" or "collection" was shown and thus we don't need the quotation marks. behatnotneeded Change-Id: I5403c70dab8fed11718071573c1bc525ada4a768
-
- 14 Sep, 2019 1 commit
-
-
Robert Lyon authored
Change-Id: I6372d71e8377ab7c100c2cad9885b54324e7fc66 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 12 Sep, 2019 2 commits
-
-
Evonne authored
Put in class card-body for external media video block to add the space and be consistent with other blocks. behatnotneeded Change-Id: I164ecff8b2505a5f5e393ff623dff4512f296345
-
Evonne authored
The small Mahara logo now appears at the smallest breakpoint at 480px Also fixed the placement of the user profile icon in the header so that the image sits away from the border and more centre-aligned within the toggle. behatnotneeded Change-Id: I085590cb5734124a91ee50b063448102943387f2
-
- 10 Sep, 2019 7 commits
-
-
Evonne authored
Fixes so name isn't covered by a person's profile picture in th profile side bar block when the name is long. Also fixed the "Default" theme where the colour of the block header fits the profile picture better. behatnotneeded Change-Id: I1b8f8b2e113156399ac6b3d7a7c032097acee0e2
-
Evonne authored
Reverted commit c9b82dcd because it has conflicts with z-index negatives. This fix uses flex to push footer down to bottom of short pages. Note this fix does not work on IE11, there the normal footer position is used. behatnotneeded Change-Id: I03db6217a235a99191685bda75acaa0dbc9deae0
-
Evonne authored
On My tags page, the link next to "Search results for" is not clickable due to the Edit this tag button floating on top of it in a transparent layer. Fix give the button group a margin-left to move it away from the search title. Both the link and the edit button (sometimes doesn't display) should now be clickable. behatnotneeded Change-Id: Idecfbaaf8965b1908a8b6edd3c3300b36da33929
-
Evonne authored
Fixes for first button in button group that appear to have all four corners rounded rather than just the left ones. Fixes placement of button group on style guide sitting above the box. behatnotneeded Change-Id: I06e19a3633e2692ee6a8f97b13be7751833356af
-
Evonne authored
Fixes short pages where footer colour stops in a strip rather than extend to the bottom of the browser window. behatnotneeded Change-Id: Ia5968cf0f6926c89a83ed89f3b6bcd196327923c
-
Evonne authored
Replacing manually entered values for border-radius to use bootstrap variable. Visually nothing should be different, just easier long term maintenance. behatnotneeded Change-Id: I68aeb998cd43f3a9c7b1b9b770d6d30a20612c63
-
Lisa Seeto authored
when creating a block, run through all the tags and if they match institution style tag, then construct the tag with the institution display name and the tag. behatnotneeded Change-Id: If6b92d1c2d993368f057f1b6c71354ce6d8cbb3c Signed-off-by:
Lisa Seeto <lisaseeto@catalyst.net.nz>
-
- 09 Sep, 2019 2 commits
-
-
Robert Lyon authored
So that we only try and save the new block one time behatnotneeded Change-Id: I6dd1fbe0bcaf98c37db7ee601198efa108867970 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
Evonne authored
Fixes list-group-item-text background from white to transparent. An example of where this appears is in the "Latest changes I can view" block. The page description had a white background, which did not look good as there shouldn't have been a background. behatnotneeded Change-Id: Ib5b08d1a49b6c22458fbf8e0dfe846a00920ff22
-