1. 25 Sep, 2019 1 commit
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  2. 23 Sep, 2019 1 commit
    • Evonne's avatar
      Bug 1834973 IE11 side panels are at bottom of page · e3a53e16
      Evonne authored
      An issue with flex on IE11 where flex item has a max-width, the
      fix sets the min-size in flex-basis to 0% instead of 25% so that
      it grows to fit.
      
      behatnotneeded
      
      Change-Id: I719acbc6db578444d0621cb4f660cb2226d8960b
      e3a53e16
  3. 19 Sep, 2019 1 commit
  4. 18 Sep, 2019 4 commits
  5. 12 Sep, 2019 2 commits
  6. 10 Sep, 2019 6 commits
    • Evonne's avatar
      Bug 1843239: Profile block user picture overlaps name · 73ee0b00
      Evonne authored
      Fixes so name isn't covered by a person's profile picture in th profile
      side bar block when the name is long. 
      
      Also fixed the "Default" theme where the colour of the block
      header fits the profile picture better.
      
      behatnotneeded
      
      Change-Id: I1b8f8b2e113156399ac6b3d7a7c032097acee0e2
      73ee0b00
    • Evonne's avatar
      Bug 1830835 Footer at bottom of short pages · 59b8c41e
      Evonne authored
      Reverted commit c9b82dcd
      because it has conflicts with z-index negatives. This fix uses flex
      to push footer down to bottom of short pages. Note this fix does
      not work on IE11, there the normal footer position is used.
      
      behatnotneeded
      
      Change-Id: I03db6217a235a99191685bda75acaa0dbc9deae0
      59b8c41e
    • Evonne's avatar
      Bug #1833348 Heading on tags page can't be selected · b54845fb
      Evonne authored
      On My tags page, the link next to "Search results for" is not
      clickable due to the Edit this tag button floating on top of it
      in a transparent layer. Fix give the button group a margin-left
      to move it away from the search title. Both the link and the edit
      button (sometimes doesn't display) should now be clickable.
      
      behatnotneeded
      
      Change-Id: Idecfbaaf8965b1908a8b6edd3c3300b36da33929
      b54845fb
    • Evonne's avatar
      Button group styling and placement · f82fa316
      Evonne authored
      Fixes for first button in button group that appear to have all four
      corners rounded rather than just the left ones. Fixes placement of
      button group on style guide sitting above the box.
      
      behatnotneeded
      
      Change-Id: I06e19a3633e2692ee6a8f97b13be7751833356af
      f82fa316
    • Evonne's avatar
      Bug 1830835: Extending page footer colour · c9b82dcd
      Evonne authored
      Fixes short pages where footer colour stops in a strip rather than
      extend to the bottom of the browser window.
      
      behatnotneeded
      
      Change-Id: Ia5968cf0f6926c89a83ed89f3b6bcd196327923c
      c9b82dcd
    • Evonne's avatar
      Bug 1836676: Using border-radius variable in theme · 34891d1e
      Evonne authored
      Replacing manually entered values for border-radius to use bootstrap
      variable. Visually nothing should be different, just easier long term
      maintenance.
      
      behatnotneeded
      
      Change-Id: I68aeb998cd43f3a9c7b1b9b770d6d30a20612c63
      34891d1e
  7. 09 Sep, 2019 2 commits
    • Evonne's avatar
      Bug 1843238: Make List-group-item-text background transparent · e06f74d7
      Evonne authored
      Fixes list-group-item-text background from white to transparent.
      An example of where this appears is in the "Latest changes I can view"
      block. The page description had a white background, which did not look
      good as there shouldn't have been a background.
      
      behatnotneeded
      
      Change-Id: Ib5b08d1a49b6c22458fbf8e0dfe846a00920ff22
      e06f74d7
    • Evonne's avatar
      Bug 1836675: Alignment of pageheader to page · da5ba0bb
      Evonne authored
      Fixes left alignment of pageheader to the rest of the page as it
      got pushed out on the left side of the page when padded was added
      to the right for the floating menu.
      
      behatnotneeded
      
      Change-Id: Iac3b7cf41a2b0efb6def4bec6a512adf12ccdfe9
      da5ba0bb
  8. 06 Sep, 2019 1 commit
  9. 28 Aug, 2019 1 commit
  10. 23 Aug, 2019 1 commit
  11. 19 Aug, 2019 1 commit
    • Peter Spicer's avatar
      Bug 1837194: Allow going directly to a message from a URL · ab0a0975
      Peter Spicer authored
      For normal messages, going to the inbox and unhiding a message is fine,
      but if the message is one that will have been synced to an LMS, the user
      is quite likely to come from the LMS via a direct link to the message itself.
      
      This allows us to expand a message - albeit on the proviso that it is on
      the first page of results, though this is a scenario that never came up in
      a year of user testing.
      
      I did include a Behat test, though I had to write a new step to cover the
      specifics of 'going directly to a message'.
      
      Change-Id: I0e68fcc37f1ed453b6c43ce939d8c2a3a60b292e
      ab0a0975
  12. 16 Aug, 2019 1 commit
  13. 13 Aug, 2019 2 commits
  14. 12 Aug, 2019 4 commits
  15. 11 Aug, 2019 1 commit
  16. 07 Aug, 2019 1 commit
  17. 05 Aug, 2019 1 commit
  18. 04 Aug, 2019 7 commits
    • Kevin Dibble's avatar
      Bug 1529730: show user introduction · 87ed7435
      Kevin Dibble authored
      This change allows the user introduction to be fully seen
      by clicking on a new link called "show introduction".
      
      This is displayed in
      - Engage -> People
      - Engage -> Groups
      
      behatnotneeded
      
      Change-Id: I5cc533571977a978982ca6aa39f0de022abe699e
      87ed7435
    • Robert Lyon's avatar
      Bug 1829940: Create plugin base config form / system · 62e432fb
      Robert Lyon authored
      And create a form for the blocktype class
      Allow the blocktype_installed to have a sort order
      
      behatnotneeded
      
      Change-Id: I2e11274a36dba59dfc193b2f5b504303a7e21a54
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      62e432fb
    • Robert Lyon's avatar
      Bug 1829940: Move 'add placeholder' to float on right · 51af094b
      Robert Lyon authored
      Done in this patch: -
      - have the add block button on right
      - have text on large screens but only icon on smaller screens
      
      behatnotneeded
      
      Change-Id: I37b6a8e44036d2d9a43b25700c3f1812f94c9a81
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      51af094b
    • Robert Lyon's avatar
      Bug 1829940: Restrict the chooser to one 'add' button · 4d9a5645
      Robert Lyon authored
      Done in this patch:
      - restricted the list to one shortcut button (the placeholder one)
      - cleaned up old code where one could edit the block on the without
      modal
      - moved the button to be above content layout and next to the
      instructions section
      - move the block help link to within placeholder block and be an 'i'
      on 'Content types' heading
      
      behatnotneeded
      
      Change-Id: I8a85842ffef5e50c62aca73a4b33c22579b160ca
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4d9a5645
    • Robert Lyon's avatar
      Bug 1829940: Placeholder option update page with block of choice · 882259ee
      Robert Lyon authored
      This patch does the following:
      - Make 'placeholder' configure options clickable so that on clicking
      an option updates the block on the page and changes the configure form
      to the form of the blocktype chosen
      - On 'add placeholder' -> 'choose option' we have 'remove' option on
      form and it removes the block from the page
      - On 'add placeholder' -> 'save' -> 'configure block' -> 'choose option'
      we have 'cancel' option on form and it reverts the block back to
      'placeholder'
      
      behatnotneeded
      
      Change-Id: I1681ef92c5ccc14cda2167a040bb751501bfdbcd
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      882259ee
    • Robert Lyon's avatar
      Bug 1829940: Placeholder block · 0f8d5b31
      Robert Lyon authored
      This patch does the following:
      - Create new blocktype 'placeholder'
      - Make sure it is copyable
      - Make sure it is versionable
      - Allow tags for it and that it works with create page via tags
      - Populate instance config with content types using 'showmore' pagination
      
      behatnotneeded
      
      Change-Id: I8437fbab587b5dc8661512ce8d227161f0129475
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      0f8d5b31
    • Ivan Barreto's avatar
      Bug #1353809: Avoid making duplicate group categories · b4203597
      Ivan Barreto authored
      This change stops one having duplicate group category entries.
      We will do the comparison in a case insensitive way so we avoid
      having: CatA, caTa, catA, cAta etc.
      
      behatnotneeded
      
      Change-Id: I2daafe898f78e78b0aa0b0bf2ffac29ea1b814e4
      b4203597
  19. 02 Aug, 2019 1 commit
  20. 31 Jul, 2019 1 commit
    • Kristina Hoeppner's avatar
      Bug 1811904: Font Awesome icon adjustments · 0a9c9356
      Kristina Hoeppner authored
      A few icons required adjusting to use only
      free icons. Additionally, icons in the
      card header in the "Primary School" theme
      were changed or added in the first place.
      
      Needed to update the card icons to use the correct font awesome family
      
      behatnotneeded
      
      Change-Id: Ief8f4b4393b1becfb18a8c39d3ef6b8966bbe9eb
      0a9c9356