GitLab

create modal using configureblock id, update various templates to use the modal for blocks:
Image
Note
File(s) to download
Journal/blogs
add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
add JS to handle url that redirects to view/view.php with modal open and populated.
Further changes to each block will be completed in child patches.
Add segment headings to the modal. Fix display of comments to cover width of modal.
Show comment removed msg in modal/page appropriately.
Fix behat test to close modal before continuing.
do not show existing comments if comments not allowed on artefact.
add validation to modal for comments/attachments
disable image as link when editing for image block
trigger focus on modal for accessibility
close modal on escape keydown event
fix merge conflict in view/view.php
fix merge conflict with master
make configureblock modal play nicely when comment block is on the page
update display of error messages to always show at top of modal so user doesn't have to scroll
add accesibility to close modal on escape key down
handle dock show/hide events for paginated pages in modal during validation
create block-comments-details-header template file
create details button and custom scss file with js to show and hide header
update comment links to save add comment and details when commentcount == 0
add active-block class to colour the block-header when active
toggle the details-btn active css
add _block-comments-details-header.scss to patch
change class invisble to class d-none
add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
code review changes
add .no-modal class to links on group home page, dashboard and profile page.
add block header to appear above the title
change assessbtn from anchor tag to button to prevent scrolling.
make all clickable links clickable on page load (ignore assess mode)
fix js issues surrounding assessbtn move and show/hide blocks
change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
update assessbtn to details btn
create tooltip for hover over file download block titles
fix containerElm console log error by not reattaching tinymce unneccessarily.
fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.

Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

An issue with flex on IE11 where flex item has a max-width, the
fix sets the min-size in flex-basis to 0% instead of 25% so that
it grows to fit.

behatnotneeded

Change-Id: I719acbc6db578444d0621cb4f660cb2226d8960b

- put consent button in own div so it always displays
- add description as info text underneath the button
- change wording/ styling on modal buttons
- Added in newline for accountsuspended string as it wouldn't ignore the <br /> tag
- change name of confirm-no-button to suspend-account-btn for clarity

Change-Id: I1ca009a76b1b3243512f6b9658439c111f2b80f0
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Change-Id: Ib0a677db1b04b328f0e679cffa0c4d52fa52ecee

By making a fonttype mixin

behatnotneeded

Change-Id: I4f0938795c3b5f8ab93751915227d0c5370ba48f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When on a small screen, the add blocks button in the floating
menu on edit page has a gap on the right. Fix adds 100% to the
button and its wrapper so it will fill up the space just like
the buttons below it.

behatnotneeded

Change-Id: Ia20003a4a8115ac6edae5a1d4ac8a4e00557c2de

Some pages like user profile page where there the content is short,
the previous patch made the content vertically center in the
main-content div. This fix gives the div flex: 1 to tell it to not
do that.

behatnotneeded

Change-Id: I4f8951d799fdbfcb397e46e99592f3f6bd13347e

Put in class card-body for external media video block to add the
space and be consistent with other blocks.

behatnotneeded

Change-Id: I164ecff8b2505a5f5e393ff623dff4512f296345

The small Mahara logo now appears at the smallest breakpoint at 480px 

Also fixed the placement of the user profile icon in the header so
that the image sits away from the border and more centre-aligned
within the toggle.

behatnotneeded

Change-Id: I085590cb5734124a91ee50b063448102943387f2

Fixes so name isn't covered by a person's profile picture in th profile
side bar block when the name is long. 

Also fixed the "Default" theme where the colour of the block
header fits the profile picture better.

behatnotneeded

Change-Id: I1b8f8b2e113156399ac6b3d7a7c032097acee0e2

Reverted commit c9b82dcd
because it has conflicts with z-index negatives. This fix uses flex
to push footer down to bottom of short pages. Note this fix does
not work on IE11, there the normal footer position is used.

behatnotneeded

Change-Id: I03db6217a235a99191685bda75acaa0dbc9deae0

On My tags page, the link next to "Search results for" is not
clickable due to the Edit this tag button floating on top of it
in a transparent layer. Fix give the button group a margin-left
to move it away from the search title. Both the link and the edit
button (sometimes doesn't display) should now be clickable.

behatnotneeded

Change-Id: Idecfbaaf8965b1908a8b6edd3c3300b36da33929

Fixes for first button in button group that appear to have all four
corners rounded rather than just the left ones. Fixes placement of
button group on style guide sitting above the box.

behatnotneeded

Change-Id: I06e19a3633e2692ee6a8f97b13be7751833356af

Fixes short pages where footer colour stops in a strip rather than
extend to the bottom of the browser window.

behatnotneeded

Change-Id: Ia5968cf0f6926c89a83ed89f3b6bcd196327923c

Replacing manually entered values for border-radius to use bootstrap
variable. Visually nothing should be different, just easier long term
maintenance.

behatnotneeded

Change-Id: I68aeb998cd43f3a9c7b1b9b770d6d30a20612c63

Fixes list-group-item-text background from white to transparent.
An example of where this appears is in the "Latest changes I can view"
block. The page description had a white background, which did not look
good as there shouldn't have been a background.

behatnotneeded

Change-Id: Ib5b08d1a49b6c22458fbf8e0dfe846a00920ff22

Fixes left alignment of pageheader to the rest of the page as it
got pushed out on the left side of the page when padded was added
to the right for the floating menu.

behatnotneeded

Change-Id: Iac3b7cf41a2b0efb6def4bec6a512adf12ccdfe9

behatnotneeded

Change-Id: I246e1d6a4af9904354b900126aa18374a931dde9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And in navigation.tpl

behatnotneeded

Change-Id: Ib60cebe519810b93d504b38bf138bcb15306d340

To make it more in line with the current look/feel

behatnotneeded

Change-Id: I66859b34ff01b06f474dd85417c85a6408047d6f

For normal messages, going to the inbox and unhiding a message is fine,
but if the message is one that will have been synced to an LMS, the user
is quite likely to come from the LMS via a direct link to the message itself.

This allows us to expand a message - albeit on the proviso that it is on
the first page of results, though this is a scenario that never came up in
a year of user testing.

I did include a Behat test, though I had to write a new step to cover the
specifics of 'going directly to a message'.

Change-Id: I0e68fcc37f1ed453b6c43ce939d8c2a3a60b292e

behatnotneeded

Change-Id: I847b415b931b5db92a214058c1d42717819b4ba3

To make it more in line with the current look/feel

behatnotneeded

Change-Id: Ibd5279677f18863b25b4f83f7d6404730aa750e7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So the text aligns better with radio button and that discription is
paired better with radio button

behatnotneeded

Change-Id: I9aa7a170814a1de9bedf8458efc37556136970d6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ib060fef54ac3ef4a1b881743ed00774e9eb6424a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

with social media icons we fetch them from external server each time
but a lot of them exist in the FontAwesome font library.

We should use the FA icons instead

behatnotneeded

Change-Id: I7b66ae0882836c7a0715969e5e03353b1e4fd70d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Changing from fontawesome to fontawesome5

Change-Id: If7e324b11e5bfc070d3a947d8f04f88a87ba7875
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Places to check
- the Extensions -> Plugins -> Comment configuration
- adding a Comment to a page/artefact and how it displays

Change-Id: I6d0945ee0d54492b65ff285d98bd65bc14d6e723
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I8334ea625a2f2790bed846913990cecd68b24a70
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ic931a2439078ec2dbdcf1df2af24e6c92f72a26b

This change allows the user introduction to be fully seen
by clicking on a new link called "show introduction".

This is displayed in
- Engage -> People
- Engage -> Groups

behatnotneeded

Change-Id: I5cc533571977a978982ca6aa39f0de022abe699e

And create a form for the blocktype class
Allow the blocktype_installed to have a sort order

behatnotneeded

Change-Id: I2e11274a36dba59dfc193b2f5b504303a7e21a54
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Done in this patch: -
- have the add block button on right
- have text on large screens but only icon on smaller screens

behatnotneeded

Change-Id: I37b6a8e44036d2d9a43b25700c3f1812f94c9a81
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Done in this patch:
- restricted the list to one shortcut button (the placeholder one)
- cleaned up old code where one could edit the block on the without
modal
- moved the button to be above content layout and next to the
instructions section
- move the block help link to within placeholder block and be an 'i'
on 'Content types' heading

behatnotneeded

Change-Id: I8a85842ffef5e50c62aca73a4b33c22579b160ca
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch does the following:
- Make 'placeholder' configure options clickable so that on clicking
an option updates the block on the page and changes the configure form
to the form of the blocktype chosen
- On 'add placeholder' -> 'choose option' we have 'remove' option on
form and it removes the block from the page
- On 'add placeholder' -> 'save' -> 'configure block' -> 'choose option'
we have 'cancel' option on form and it reverts the block back to
'placeholder'

behatnotneeded

Change-Id: I1681ef92c5ccc14cda2167a040bb751501bfdbcd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch does the following:
- Create new blocktype 'placeholder'
- Make sure it is copyable
- Make sure it is versionable
- Allow tags for it and that it works with create page via tags
- Populate instance config with content types using 'showmore' pagination

behatnotneeded

Change-Id: I8437fbab587b5dc8661512ce8d227161f0129475
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This change stops one having duplicate group category entries.
We will do the comparison in a case insensitive way so we avoid
having: CatA, caTa, catA, cAta etc.

behatnotneeded

Change-Id: I2daafe898f78e78b0aa0b0bf2ffac29ea1b814e4

-Add lang strings for:
"Edit saved framework"
"Copy existing framework"
"Preview"
in the SmartEvidence editor

behatnotneeded

Change-Id: Ic5436cb4184896791ccf07f7be5be29c8e982012

A few icons required adjusting to use only
free icons. Additionally, icons in the
card header in the "Primary School" theme
were changed or added in the first place.

Needed to update the card icons to use the correct font awesome family

behatnotneeded

Change-Id: Ief8f4b4393b1becfb18a8c39d3ef6b8966bbe9eb

for the owner of the collection when the framework is not a
self-assess one
and for institution staff when the framework is a self-assess one

behatnotneeded

Change-Id: Iac63c94b7e07a526e2e8790de1d7f4fc7e409160