1. 25 Sep, 2019 1 commit
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  2. 28 Aug, 2019 1 commit
  3. 12 Aug, 2019 2 commits
  4. 09 Jul, 2019 2 commits
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - final name changes · c3479dc6
      Rebecca Blundell authored
      icon-clipboard      -> icon-clipboard-check
      icon-eye            -> icon-regular icon-eye
      icon-eye-slash      -> icon-regular icon-eye-slash
      icon-file-archive-o -> icon-regular
      icon-comments-o     -> icon-comments
      icon-external-link  -> icon-external-link-alt
      icon-tachometer     -> icon-tachometer-alt
      icon-rotate-right   -> icon-redo
      icon-file-archive-o -> icon-file-archive
      icon-comments-o     -> icon-comments
      icon-send           -> icon-paper-plane
      icon-lightbulb-o    -> icon-regular icon-lightbulb
      icon-code-fork      -> icon-code-branch  - changed versioning to
      'history' icon
      icon-file-o         -> icon-regular icon-file
      
      also changed some icons to new ones
      used text-align, width and margin-right to centre list items.
      
      behatnotneeded
      
      Change-Id: I4d27e450a281dc49716d97de309a3c99b89a0bc1
      c3479dc6
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - yet more name changes · e84165b0
      Rebecca Blundell authored
      icon-calendar       -> icon-regular icon-calendar-alt
      icon-check-square-o -> icon-regular icon-check-square
      icon-square-o       -> icon-regular icon-square
      icon-circle-o         -> icon-regular icon-circle
      icon-legal          -> icon-gavel
      icon-level-up       -> icon-level-up-alt
      icon-long-arrow-down-> icon-long-arrow-alt-down
      long-arrow-left     -> icon-long-arrow-alt-left
      long-arrow-right    -> icon-long-arrow-alt-right
      long-arrow-up       -> icon-long-arrow-alt-up
      
      icon-remove         -> icon-times || icon-user-times
      (times is the 'x'used elsewhere, user-times is the 'x' next to a profile person.
      Remove has been removed so I have deleted it from the styleguide)
      
      icon-level-up       -> icon-level-up-alt
      icon-heart-o        -> icon-regular icon-heart
      icon-arrows         -> icon-arrows-alt
      
      icon-sign-in        ->icon-sign-in-alt
      
      Change-Id: Ia2cd81ea24119a7d0fec3000af1eaf2571a2a62b
      e84165b0
  5. 25 Jun, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - Name changes · 7b952964
      Rebecca Blundell authored
      new default for fontawesome is 'solid',
      where we are using a different class (regular or brand),
      we need to add these.
      
      also confirming that where the icon name has changed, we've
      picked that up.
      
      Where there's a choice of icon, I've kept it as close to what we
      currently have as possible.
      All free icons can be seen here:
      https://fontawesome.com/icons?d=gallery&m=free
      
      Name changes:
      icon-trash-alt      -> icon-trash
      icon-pencil         -> icon-pencil-alt
      icon-unlock-alt     -> icon-unlock
      icon-files-o        -> icon-regular icon-copy
      icon-pencil-square  -> icon-regular icon-edit
      icon-file-text      -> icon-file-alt || icon-regular icon-file-alt
      icon-image          -> icon-regular icon-image
      
      behatnotneeded
      
      Change-Id: I34646a6857f6cf54dc39572f5a66c07da4f4c0e2
      7b952964
  6. 14 Jun, 2019 1 commit
  7. 05 May, 2019 1 commit
  8. 30 Apr, 2019 1 commit
  9. 28 Apr, 2019 1 commit
  10. 23 Apr, 2019 1 commit
    • Doris Tam's avatar
      Bug 1824684: Tags for folders and files appearing for non-personal files · a8ccbf09
      Doris Tam authored
      Separated the show tags from the user id of who is owning the tags
      
      Also, removed help icon for Institiution tags in the settings as there
      was no linked help text for the icon and the existing description
      is intuitive enough.
      
      behatnotneeded
      
      Change-Id: I1a980413fbb94fb290ffe21bd832c0a8dafe6756
      a8ccbf09
  11. 16 Apr, 2019 1 commit
  12. 09 Apr, 2019 1 commit
    • Evonne Cheung's avatar
      Bug #1822911 User icons not appearing circular in some themes · 74bfb4a6
      Evonne Cheung authored
      Use object-fit:cover to force non-square images to size to the min
      width/height of the image loaded so that it displays the center of
      the image in the correct ratio, hence fixing the issue of oval shapes.
      
      Added extra classes to tell theme what size the images are to display,
      ie .user-icon-20, .user-icon-40, .user-icon-60, etc, and
      .user-icon-inline for when username is displayed inline with user icon.
      
      behatnotneeded
      
      Change-Id: I28e0b37d0961c3be0195f4baef704262a0547af0
      74bfb4a6
  13. 05 Apr, 2019 2 commits
  14. 29 Mar, 2019 1 commit
  15. 27 Mar, 2019 2 commits
  16. 24 Mar, 2019 1 commit
  17. 22 Mar, 2019 2 commits
  18. 26 Feb, 2019 18 commits