GitLab

When decrypting responses to our XMLRPC requests, consider an older key to be OK. This fixes keyswap when both hosts have different keys (!)
(cherry picked from commit cfde5bfd)

When we receive a request using an old key, respond with a signed and encrypted message with our new key.

This makes it so that when Moodle and Mahara are set up to network, and Mahara's key expires, Moodle can successfully grab the new key.

Modify get_keypair so that it can be called from outside the class, and the regenerate parameter being true actually regenerates a key.

When an CryptException occurs when sending an XMLRPC request (because the response was using an old key for example), fail in a nicer manner.

Update the message for the primary cause of this (old key) so it's more obvious in the logs.

[#2987] Set default wantsurl so that the jump URL doesn't have to set it. This makes the SSO peers block work again.

Properly delete blockinstances when deleting a View, this ensures that the delete hooks are called properly (and thus extra data is removed from blocktype tables).

Also wrap view deletion in a transaction.

Conflicts:

	htdocs/lib/db/upgrade.php
	htdocs/lib/version.php

Haven't tested SSO updating it yet.

The MNET code uses this a bit.

Set the default remote application to 'moodle' when configuring an XMLRPC plugin, as this is by far and away the most popular choice.

Add a debug line to the logs when a user tries to SSO in from a remote app, we don't know about them and we won't create an account for them.

It's now a %s based string, which means we can change the logic later and only have to update the lifetime in one place.

- can_view_view needs http://paste.dollyfish.net.nz/0e6800 (see comment
  in function)
- blocktype/mygroups/lib.php is BROKEN (was using get_associated_groups
  which I guess has been removed. needs updating! I commented out a line
  to stop it fataling in the meantime.