GitLab

The blogpost delete form had $title variable in 16.10 but the
changepoststatus form did not.

So gives undefined variable warning on journal list page

behatnotneeded

Change-Id: I562a51687f95cb996a2da023ab52b846c26a1c8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I2dde01166da1a001edfee3b2cc97badfe6ceb2a4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I663f6ffde03b6b3504d49a767ac0ff55d0ab8437
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 056d42fc)

1. when a user logs in it clears any obsolete
   usr_session cookies for the user
2. recording the user-agent of the session
   and if it changes to prompt the user to
   login again
3. when self adding / editing email address(es)
   send 2 emails
	- one to the new email address asking user to confirm address
	- and one to the primary email address to alert user
	that a new email is being added to their account and
	if this is bad how to contact their admin about the problem.

behatnotneeded
Change-Id: Ia44b66cf831abd553b72aa8b1d58d2a2634863b8

Which is only the user's name

Change-Id: I01d3dab89c0f48b6b734b31690f1b4036c7cf7a6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 974728dd)

to avoid having problems when the user emails another user

Change-Id: If694e969ea8a9d77badfffa095dc5fac3b6da417
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit dbbbb91c)
(cherry picked from commit bf1717cb)

behatnotneeded

Change-Id: I6f0c82a74e0d60614230aac1d4fc3884eae387a5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit c367be4d)
(cherry picked from commit 465b7df2)

Before displaying it to screen

Change-Id: I0bfc727ca6e0feee649392fcd85a89b16f55201f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 648b191e)

an oversight from commit dde8e52b

Change-Id: Iba1c23b7b88cfb9526627f1b9c934bb94ecc4e5c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 873eeed0)
(cherry picked from commit 9ccdfe2d)

behatnotneeded

Change-Id: I4b342a0d3f00015e8f2e0ff7d93d2b5198fbc32d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 86711cb8)

behatnotneeded

Change-Id: Ibea0816e9823c0a790564a39fd5b12455aa28339
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 836e37d9)
(cherry picked from commit 2d601f66)
(cherry picked from commit 54f05eae)

In webservices / csv upload we deal with the variable 'submitpages' in
relation to if one can submit pages to group. But the group
create/update functions and db table expect 'submittableto'.

The csv upload function converts this as expected but the webservices
didn't.

Have made adjustemets to webservices to suit

behatnotneeded

Change-Id: Ia2a593705a85fec88debed63dd55277c8f1acc37
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Administrator is spelled adminstrator

behatnotneeded

Change-Id: I93c5514f9aa68930945924c1334be1e3f4c07eae
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit fe64abcd)

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

Added permissions to use json in public views
that include myviews blocktype, so the pagination
won't break when the block has more than 10 views

behatnotneeded

Change-Id: I8b96020729cc5cd0f3a34be7013155e2965c3ec2
(cherry picked from commit 35f3d2dc)

behatnotneeded

Change-Id: I80432042b06f00f0e84d0bdf2d7327233c4f2ba9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 3cc09ae5)

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 457d11d1)
(cherry picked from commit c544f506)

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To avoid potential hacking vectors for the site

behatnotneeded

Change-Id: I53088c5e73017bc59f156483509e1bb7e8c1710a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* changes:
  Bug 1715260: Keep tinymce fields on block config form error
  Bug 1694875: Annotation field validated via JS

behatnotneeded - will be covered by annotation_block.feature

Change-Id: Ibc5652e208ff4d65d2e845678db00ce245e91f63
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Validation on portfolio collections
Validation on smartevidence grid
Behat tests added
A new feature file added

Change-Id: Ib5adf627f3391fb53805b0566a7c405313a3066b

behatnotneeded

Change-Id: I014b29c0b7e22a0ff87f321fe60ccb66edd88bbe
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7c45e18b)

Due to the json file not using the correct call to site templates

It was updated for the initial page load but not for the json load of
pagination results

behatnotneeded

Change-Id: Icea835bc6252df05aac8b3a6cf367d1f2364f7ea
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ic511e25066ebd84b80118e71f70c6f867a3564b4

behatnotneeded

Change-Id: I469f8136e287bb86eb17a32dbed48dec05b87969

And searched on for elasticsearch.

behatnotneeded

Change-Id: Ib53787ab882496a998b767bbeb3713a3547fd471
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6943926a)

We need to avoid the sprintf() error if lang string expects extra args.

We can do this by supplying function check_string rather than
format_string

behatnotneeded

Change-Id: Ibfc2d9a552f2d87b2f5f762bab2ff2ec76a73dca
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7f9b6945)

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 2b3f239d)