GitLab

This is 2 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I7741ae0d436d7e11fe248307936757d3d8027cc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is one of 6 patches to standardize pagination

To help test this there is a zip file in Bug 1515774

behatnotneeded

Change-Id: I278ae35cdbe83929cd8eca2b28d1191cab5c3ea6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I99756d283512b930464d6d98f9760cb749adf0ff
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Set the state of the libxml entity loader & use internal
errors settings, back to what they were before we called
them, as a workaround to https://bugs.php.net/bug.php?id=64938,
which causes them to be shared by all threads in a single
process.

behatnotneeded

Change-Id: I0720146b1e91c24095a18636e09981830ef4ce8f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1515929: Usually when we use get_record(), we're
querying against a record that has a uniqueness constraint
guaranteeing that it is unique, in which case the PHP
code that dies on non-uniqueness is redundant.

In the remaining cases, we're dealing with records
that for some reason can't have a uniqueness constraint,
and the dying just causes the site to entirely stop
working, when it would be more useful to have it continue
to work but throw a warning message to the logs.

behatnotneeded: Covered by existing test cases

Change-Id: I264f72e3a8904293d78909410f68b29f2c78db3c

Bug 1510421

Defines a new static PluginBlocktype method, get_css_icon(), which
fetches the name of the CSS icon to use for this blocktype. It returns
false by default, which tells the theme to "fall back" to the old
thumbnail.png instead. 3rd-party plugins can override this to
specify a particular icon to use.

All the core blocktypes have been refactored to extend
MaharaCoreBlocktype, which uses the blocktype name as the name
of the CSS icon to use. I also deprecated the "SystemBlocktype"
class while I was at it.

PluginBlocktype::get_blocktypes_for_category() now returns both
the results of get_css_icon() and the thumbnail.png path, so that
themes can decide which they want to use. (And of course
thumbnail.png is served via thumbnail.php, so 3rd party themes
can provide their own custom image files if they wish.)

behatnotneeded: Requires installing third-party plugins to test

Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0

Rewrite to use ensure_record_exists instead of re-inventing
the wheel.

behatnotneeded: Covered by existing tests

Change-Id: Id57be0e00f14ab65dd40b4ef13f696e72f608d46
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1518796

behatnotneeded: Covered by existing tests

Change-Id: I996e4562441140a6163dbf0b9dff4ee2894ffd83

And getting them to display in the export html files

behatnotneeded

Change-Id: I881817dfb94d78a1fd2ac8b0e85b3ebed83b42cf
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To allow for better performance. Have taken what a user contributed
and tried to make it even more efficient still.

behatnotneeded - existing tests should take care of this

Change-Id: I91ff4e0b5e3e4e22ee437cce5e3da33bace1e736
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I1bd65328134a57757bf788839fef06715a984310
behatnotneeded
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

behatnotneeded: Can't test mobileupload API in Behat

Change-Id: Ied63c973fc125d4f2d403dcdd75be28c0314aeec

In both Admin -> Institutions and Admin -> Groups

behatnotneeded

Change-Id: I014d49d1c6c0fb6f6ac7e7236142615077ff835d

Bug 1517658

Change-Id: I531a1c95b94910e564e71e1f2dc26754eefa45d5
behatnotneeded: platform-specific bug

To let users know they cannot customise themes with gulp/sass if they
have the zip version of Mahara from launchpad  as important files
are not present.

It lets them know they need to get the zip from http://git.mahara.org
which will have all the extra stuff.

behatnotneeded: change to readme file

Change-Id: I7ae3e05340b54bc037f4b6856ecb237f9611b7e4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Because some systems may not have all the available data we should
check if the data exists before trying to display it.

To test:
Before patch change the line in lib/mahara.php
 if (function_exists('posix_times')) {
to
 if (!function_exists('posix_times')) {

and make sure the 'perf_to_log' config option is set to true

This will cause the errors we are trying to deal with to show up

behatnotneeded

Change-Id: If9610fa0eaf4c8bb036b21c1c75e10d828de7934
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The help icons clickable area was being hidden. Removing the position
relative seems to fix the problem and not cause any other issues.

behatnotneeded

Change-Id: Ib0ae7368c52ebdb952ba147f03e25ec3e4301d02
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

For the tag links at the top of a page

behatnotneeded: styling

Change-Id: Ie64809a434a9d2ce2c38afb9492ed652d6980910
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When adding resume composite options

behatnotneeded - this is more a UI thing

Change-Id: I33d5fab50767b1adc753dee9a0124a04f0c087b3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Mahara's usage of transactions has been causing
major deadlock issues in MySQL with InnoDB.
The immediate fix is to disable them.

behatnotneeded: Covered by existing tests

Change-Id: I2c7e6424e2d58502acd26fdd5d05c797e4ee5eac

1) Group member search results pagination
2) Blog index page (when user has multiple blogs turned on)
3) Collection index page didn't have json pagination when it should
for consistency
4) My views block on index page

Was looking for certain ID to replace results table but could not find
it

behatnotneeded

Change-Id: I7f55717fd4375d5c6bd1a4977a834a32dd172338
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Added the .tpls back in and also adjusted them to do pagination better

Change-Id: Iba2a5174434e0876e9a9c9f7c786a452f7353477
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Iffe40a00d119efca936a40500b762a625e5f348a

I thought it was only for the combination 'exact search' + 'search email'
that was broken before but it turns out it was just for 'email' option
regardless of 'exact search' or not.

behatnotneeded

Change-Id: I44a2fcd032a3a00deffd2959a01e727c3e396c8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ibc067c8f06fcd87a9aa38d129fc3acc0bbe68bb1

behatnotneeded: styling only

Change-Id: I5169ce5cd8e8ab70064d4008e7580e03beda7ce0

behatnotneeded

Change-Id: I70e95b188cdb61de01db6d1b8c5ee852647ebcd7

Some of these files aren't loaded on any pages, some (ie. debug.js)
are no longer necessary with modern debugging tools, and some have
been replaced by Bootstrap functionality

behatnotneeded: should be functionally identical

Change-Id: I6d1b3874de5d42ccc00a8c0d2bb0e8bc162747d4

behatnotneeded: Requires an upgrade to generate the warning

Change-Id: Ic412e92a7d1ed35765ed41f3ee8772e63f1bb3e5

behatnotneeded - Styling only

Change-Id: I2baac867faac11194d06c4cdb534e96d6bb30672

Change-Id: Ic8cb9115654106f669b544f5f8b060d443a0a9f0
behatnotneeded: Can't yet test MNet methods in Behat.

Need to pass the correct number of prepare statement values for the
sql string.

Change-Id: Ib3071b420e739292f089cd029fb9c7219a83bb3e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: it deals with whether an image shows or not

Change-Id: I3625f9d9948fd3c67f60657fbd3bc67644ae76e7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Will be handled by existing test

Change-Id: I476a3cc7ff1e791bc24a60986841ad92f57d7bb6

So it can be passed to 'edit access' page from the 'edit page' page
on the 'Share page' link

Change-Id: I1968d205b12840cd3dcfbd80a6ffdd26a498361d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

In MySQL, the default "text" column size is 65kB. Because this column
can hold the serialized text from several other columns, it needs to
be larger than that. Setting it to "big" generates a "longtext", which
is 4GB.

This change has no effect in Postgres. Postgres has only one text
size (unlimited). The XMLDB generator is smart enough that it
recognizes this and doesn't run any SQL in this case.

behatnotneeded

Change-Id: I0311bf9d25dba531ced72e6f74b8d5b2d317e745

On find friends page when doing search or pagination

Change-Id: I116ff4c07f44ebd08449e245d79ebc57c172cf22
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: can't test a select2 that loads data via ajax yet

Change-Id: Iae07e3d19b376acbbe4ca531bd8aebb555f6b377
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

I can't replicate but believe it's due to the .tpl file compiling
to a call to empty() with an expression as the parameter (which
is not supported by PHP prior to 5.5)

behatnotneeded: covered by existing tests

Change-Id: Ic44b89070de169790dbc5ab6d32a12484925c7e3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

These got dropped during the Bootstrap rework

Change-Id: I4a58aff25ebc9907ba4a635419557281fe4cc2b5