GitLab

This setting kills your Mahara session whenever you navigate
to Mahara from a link or redirect on another page. This totally
prevents SAML and other redirect-based auth methods from working,
makes it annoying to use links in email, and while it is mentioned
on the PHP manual's "Securing Sessions" page, it's only
recommended there if you also have "session.use_trans_id" enabled,
which we do not.

Change-Id: I8b3b14bae8043c5004cc8f36766f2db9422eac1c
behatnotneeded: Can't be tested by behat
(cherry picked from commit 91807920)

behatnotneeded

Change-Id: Iffe40a00d119efca936a40500b762a625e5f348a

Allowing the select button to appear on group/institution places

behatnotneeded

Change-Id: Ie58ff61b915753c2de5e9f60cf8d17b345b0b6e4

Bug 1566127

Change-Id: I8e249a93fbff7c3bf914099e53f1f29068a36a15
behatnotneeded: Covered by existing tests
(cherry picked from commit d5aef398)

Change-Id: I2bea376b7d403171a306c31fdc69e26a4aa1644b

When there is no 'replayall' footer link present

behatnotneeded

Change-Id: Ifa1f2a3487c8ab568a8465a48b87fd817c7e1a07
(cherry picked from commit 2a357b58)

behatnotneeded: Changes on database columns types only.

Change-Id: I0e80fe7b4ca7552c854f3496db6496e984bbdd53

see more at http://php.net/manual/en/session.security.php

behatnotneeded

Change-Id: I70b427daa1ee29c233339ba245f56a02c1a8b3a5
(cherry picked from commit 38bfb5cf)

* changes:
  Move WebService "markTestSkipped" to setup (Bug 1515473)
  Call parent::setUp() in WebServiceTestBase (Bug 1515473)

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

It got merged before I noticed the comment about needing a behat test

Change-Id: I1fd5bbdd88bc88cbde17992b9d7c9709f44b8e6f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d78df1b8)

behatnotneeded

Change-Id: Ie1b754da7d1cd1beaeadc0579890639e7d2623b7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d846632a)

Bug 1558361

behatnotneeded

Change-Id: Ic7186f35eb38cf79e76dcd8347df18178ccc5a32

behatnotneeded - should be covered by existing tests

Change-Id: Ia4592c9bd261c978dc911999e81f906fa0b13450

Also setting the note block's form change checker state to
"dirty" by default, so that users will get a warning before
navigating away to the other page.

Change-Id: I20f586781df63e942a7a1c82e5e74fd5214c233f

Bug 1558361

behatnotneed

Change-Id: Idc3f0a010fef76a0908f65ce88bf52ae870170d3

Bug 1558361: Deleting this because it has some target="_blank"
links in it, and we're not using it anyway.

Change-Id: I270e9b4928488715c6c3fff1728e8060a575379b

Bug 1558361

Change-Id: Ifb0dba0d91a0ea2ba2b2dfc2daeda39b679c0397

Bug 1558361

behatnotneeded

Change-Id: I4bebbcca92bd9cbd594ca7d8d83030f6f3e0388b

Bug 1558361

behatnotneeded

Change-Id: Idc139a671137cbde6958fdc8406bc56f8c395f08

Bug 1558361: TinyMCE will filter them out on the editing
side, and HTMLPurifier will filter them out on the display
side.

behatnotneeded: Would require non-trivial new Behat step to
check whether links have "target" attribute.

Change-Id: If27462b2ca1a382ceeaadb374aade1f795f261bd

Bug 1560730: In 15.10, where there are combined text
field & filter-dropdown fields, we use Bootstrap
magic to combine them into one succinct little thing

Change-Id: I8c9756194a60d4505ebb2840718e6b114dd8aaa5
behatnotneeded: Covered by existing tests
(cherry picked from commit b6c6044b)

Bug 1560739: As a temporary workaround to our apparent
incompatibility with gulp-bless 3.1.0 and/or bless
4.0, pinning gulp-bless to 3.0.1 fixes the problem.

Comprises two fixes:
1. Icon in profile sidebar next to the Moodle instance's
name
2. Mentioning of the Moodle instance in the "Online users"
sidebar

behatnotneeded

Change-Id: I3c1c09df9156834dc79313b8c30e5264dda2e6ad

... so that we don't bother doing setup just to get
to testRun() and realize we're skipping this test

behatnotneeded: phpunit, not behat

Change-Id: I0c96e364129435f9eca3f0cb3bb44beaf9db4701

behatnotneeded: This is phpunit, not behat. ;)

Change-Id: I906089c82c6e5ca521007359006b49381c537f2b
(cherry picked from commit b8957909)

Change-Id: I71c3afc2b3a4e07f4bbba1bb356d86911ab4b332

Sometimes the object holding the user data is a StdClass rather than a
User object

behatnotneeded

Change-Id: I39f1333eac08876653a427488280859db1022a90
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8177e874)

behatnotneeded: Visual change only

Change-Id: I19bf094ed0ec134d75af7a548920b34ceb1020ee
(cherry picked from commit 892c33e3)

behatnotneeded: error appears in error log

Change-Id: Ic816248ee56bcae7daa1f13c768afdab92c95b23
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>