- 29 Sep, 2019 1 commit
-
-
Robert Lyon authored
Otherwise there is brokenness in upgrade behatnotneeded Change-Id: I1523ec044a9caecd52f5baa2a86308460ba6c284 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 20 Sep, 2019 2 commits
-
-
Robert Lyon authored
Without needing to include the lib/ddl.php file, and create the xmldb table objects We do this by trying to query the table to return one value and capture the SQLException if it doesn't exist The places changed are where we don't manipulate the table - so have left upgrade places the same as we will need to do things the ddl.php way anyway behatnotneeded Change-Id: Ic38cee95a221a22e644370b308356cf687a1e831 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
Robert Lyon authored
Without needing to create the xmldb table / field objects We do this by trying to query the column and capture the SQLException if it doesn't exist behatnotneeded Change-Id: I0a15dd4d1d4e47e6650576c084ee9e1d36b4ae62 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 30 Aug, 2018 1 commit
-
-
Yaju Mahida authored
behatnotneeded Author: Yaju Mahida <mahida@usq.edu.au> Change-Id: I4a2c51a4a7af0842cc37ba710cdaec6c2d053d75
-
- 01 Jul, 2018 1 commit
-
-
Robert Lyon authored
behatnotneeded Change-Id: Ib599bee80bec0f8fe5f6b61125e792f7f9f1a132 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 31 May, 2018 1 commit
-
-
Mark Webster authored
Adds timezone dropdown the site settings. If no timezone selected it uses site settings country to determine correct timezone and sets that in the database. PHP and DB session timezones will then assume this setting for all times. This makes setting $cfg->dbtimezone obsolete - there is a warning to admins to update their timezone setting on admin dashboard. Limitations: - A timezone or country MUST be selected in site options. - Will not correct existing incorrect times, as no timezone info was stored in the DB for dates/times, so it's impossible to determine what timezone was used when saving. - Changing the timezone will not adjust the display of existing times, for the same reason. behatnotneeded Change-Id: I34c64cd51ece6758e76dd8c37007dcb316005845
-
- 05 Mar, 2018 1 commit
-
-
Robert Lyon authored
Because MariaDB does not have JSON cast type but does have a higher version number than 5.7 behatnotneeded Change-Id: I5a66ddb8c382a68fde189b420088bb29ef06893c Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 14 Dec, 2017 1 commit
-
-
Robert Lyon authored
The changes should allow ithe install of either a utf8 or utf8mb4 site behatnotneeded Change-Id: I23479c50f2dc2ac197f244cf723a60e79f88c561 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 04 Dec, 2017 1 commit
-
-
Ghada El-Zoghbi authored
Several issues resolved: 1. The event_log.time column has been removed and replaced by ctime. The handl_event() call is using the new column even though the new column has not been created yet in the upgrade script. Therefore, include both columns in the event handling. 2. The 'deleteartefacts' event stores multiple artefact IDs in the one event_log record. Therefore, there is not a one-to-one relationship when converting the record to the new format. Ignore the record when setting the resourceid and resourcetype. 3. In the 'saveartefact' and 'deleteartefact' events, not all of the event_log records have 'id' and 'artefact'. Ignore setting the resourceid and resourcetype fields when the data is not available. 4. For newer versions of Postgres and MySql, utilise the json dattype to convert the data held in the event_log.data column. This will speed up the processing of the table for sites with large data in the event_log table. Sponsored by Australian National University behatnotneeded Change-Id: If068dac825b9cef6301cd970f0a368124a67b3f1
-
- 09 Sep, 2017 1 commit
-
-
Robert Lyon authored
By supplying $primarykey and $returnpk parameters to the update_record function behatnotneeded Change-Id: Ib2078384cf2d48e4cea1b08f804ea01dc8e9b1d4 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 03 Sep, 2017 1 commit
-
-
Robert Lyon authored
If we are trying to fetch only 1 field then we can't use the $rs->GetAssoc() function as that expects 2 fields minimum. We can get around this in lib/dml.php by creating our own assoc return object. behatnotneeded Change-Id: I6a4a9beadc4abeebc5d73bac6128d56f46ce4676 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 24 Nov, 2016 1 commit
-
-
Robert Lyon authored
If no actual 'COUNT()' in string and the sql query return no rows behatnotneeded Change-Id: I8d86cd0dda889c564d89e494c586a98e9425fc3e Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 23 Aug, 2016 1 commit
-
-
Aaron Wells authored
Bug 1525736: Also doing a general cleanup of this very old and very messy function. behatnotneeded: Covered by existing tests Change-Id: I4b2feba22764fd290a69dc4b6ab1d734abd08a1c
-
- 14 Dec, 2015 1 commit
-
-
Aaron Wells authored
Change-Id: Ib3aab13c03cb7486072384da518b27ec0f4a2f0a
-
- 25 Nov, 2015 1 commit
-
-
Aaron Wells authored
Bug 1515929: Usually when we use get_record(), we're querying against a record that has a uniqueness constraint guaranteeing that it is unique, in which case the PHP code that dies on non-uniqueness is redundant. In the remaining cases, we're dealing with records that for some reason can't have a uniqueness constraint, and the dying just causes the site to entirely stop working, when it would be more useful to have it continue to work but throw a warning message to the logs. behatnotneeded: Covered by existing test cases Change-Id: I264f72e3a8904293d78909410f68b29f2c78db3c
-
- 16 Nov, 2015 1 commit
-
-
Aaron Wells authored
Mahara's usage of transactions has been causing major deadlock issues in MySQL with InnoDB. The immediate fix is to disable them. behatnotneeded: Covered by existing tests Change-Id: I2c7e6424e2d58502acd26fdd5d05c797e4ee5eac
-
- 20 Oct, 2015 1 commit
-
-
Gary Leydon authored
behatnotneeded: error appears in error log Change-Id: Ic816248ee56bcae7daa1f13c768afdab92c95b23 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 23 Sep, 2015 1 commit
-
-
Russell Boyatt authored
behatnotneeded: Testing requires multiple simultaneous users Change-Id: Icfac83b0ac9ed6ab0c304658550dd0260bd5d7eb
-
- 26 Mar, 2015 1 commit
-
-
Aaron Wells authored
Bug 1430111. When the table structure changes, automatically clear the cache for that table in insert_record(). Change-Id: I0612755bd5fa6646a26ff51d1d2844df211be61d
-
- 22 Mar, 2015 1 commit
-
-
Son Nguyen authored
and add a new flag 'runfresh' to the script in order to run behat tests on a new fresh database Change-Id: Ia29e3d33aa994e06aef1dc26a6bf7d5afa118837 Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
- 02 Mar, 2015 1 commit
-
-
Robert Lyon authored
Bug #1427046 to reduce query overhead Change-Id: I4eb6d2531aee54ed1cb4d5f471b3d0032f259379 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 29 Jan, 2015 1 commit
-
-
Yuliya Bozhko authored
Change-Id: I8ac41fc9915e5ceb7be4b452164d5749b14470a0 Signed-off-by:
Yuliya Bozhko <yuliya.bozhko@totaralms.com>
-
- 27 Jan, 2015 1 commit
-
-
Robert Lyon authored
Change-Id: Ib3006eb459c0f5ce72909f59c10517b3668c3e3d Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 21 Jan, 2015 1 commit
-
-
Son Nguyen authored
Bug 1406372 After upgrade ADOdb, the SQL query which uses keywords as field name causes the syntax error. Change-Id: I072e9fd35d9415246f755186e7481a9686ce431f Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
- 09 Jan, 2015 1 commit
-
-
Aaron Wells authored
Bug 1401324: Since both these methods pass through to get_recordset_sql(), which accepts a null $value, we should allow these to accept a null $value as well Change-Id: Ic1abf516f9a03e05f848d395e7635d458802ba9c
-
- 10 Dec, 2014 1 commit
-
-
Aaron Wells authored
Bug 1400975 Change-Id: I0b7145a6febdb9a5e7c32da9e5ae6cc138840f9b
-
- 04 Dec, 2014 2 commits
-
-
Aaron Wells authored
Bug #1384473 Change-Id: I7a74dc86cb3794b8442084e30f2d13a89b80a7bd
-
Robert Lyon authored
On install an error was being thrown: In Postgres: Failed to get a recordset: postgres7 error: [-1: ERROR: bind message supplies 1 parameters, but prepared statement "" requires 0] in adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN ('profileinfo','myviews','mygroups','myfriends','wall'), Array) In Mysql: Failed to get a recordset: mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NULL' at line 1] in adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN ('profileinfo','myviews','mygroups','myfriends','wall')NULL, ) Change-Id: Ifd74ccfce5c8352db2fdc55378f9eede236354c7 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz>
-
- 11 Nov, 2014 1 commit
-
-
Yuliya Bozhko authored
Change-Id: I827851a16eba74d474234c21dd6b6afc2d06470c Signed-off-by:
Yuliya Bozhko <yuliya.bozhko@totaralms.com>
-
- 04 Jun, 2014 2 commits
-
-
Aaron Wells authored
As vetted in the May 2014 dev meeting http://meetbot.mahara.org/mahara-dev/2014/mahara-dev.2014-05-01-08.01.log.html Change-Id: I353ed74d69a5346fbe4e8e521e5c349dbe8dcbac
-
Nathan Lewis authored
Change-Id: I44bb7b53dda86fd25b799c90645c6bfadf05ce2b Signed-off-by:
Nathan Lewis <nathan.lewis@totaralms.com>
-
- 09 May, 2014 1 commit
-
-
Yuliya Bozhko authored
Fixes in this patch: - Moved artefact.php to artefacts directory to separate it from pages. - Fixed reference to a wrong 'artefactonlyviewableinview' string. - Removed add_to_render_path() and its calls which have no purpose at all. - Removed 'artefact_parent_cache' table. - Removed cron jobs related to 'artefact_parent_cache' from DB. - Added 'path' column in 'artefact' table to easier calculate hierarchy. - Added ArtefactTest.php for artefacts unit tests Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c Signed-off-by:
Yuliya Bozhko <yuliya.bozhko@totaralms.com>
-
- 11 Mar, 2014 1 commit
-
-
Nathan Lewis authored
- uninstall does not remove triggers that are added by notification/internal module, causing errors when trying to re-run testing (when testing, all database objects are deleted then recreated, but the triggers already exist). - assertType is no longer available and should use assertInternalType instead (for int value). - there is a typo in lib/ddl.php find_key_name function which causes problems when creating and removing the test db tables. - there is a logic problem in lib/ddl.php uninstall_from_xmldb_file. array_multisort is being used incorrectly and sometimes causes the primary key to be removed before foreign keys which results in a database error. - the function removecolumn in lib/view.php has changed and the test is no longer valid. Change-Id: Ibee48e557912e09cf6533132ba771bfb2c44749f Signed-off-by:
Nathan Lewis <nathan.lewis@totaralms.com>
-
- 22 Jan, 2014 1 commit
-
-
Craig Miskell authored
Bug#1187212 Change-Id: If268ee5144eed83f8ec6ce3610b7488bb1dc9edd Signed-off-by:
Aaron Wells <aaronw@catalyst.net.nz>
-
- 16 Dec, 2013 1 commit
-
-
Aaron Wells authored
Bug 1070046: MySQL has an optional server config option, "MAX_JOIN_SIZE", which throws an error if you try to run a SQL query that MySQL's strategizer thinks will require it to evaluate more than MAX_JOIN_SIZE rows. This is intended to prevent the user from accidentally running giant queries that will never finish, but some Mahara queries (which are large but will finish) can trip it. Adding SQL_BIG_SELECTS=1 tels it that our queries are *not* accidentally large. Change-Id: I6db4699ea765d3213d13eb93b8de098914db24e0
-
- 14 Oct, 2013 1 commit
-
-
Robert Lyon authored
- have updated copyright for the pages that had existing copyright notices (except for the lib/pieforms/ section as i'm not too sure if that needs changing as it is a different Catalyst IT product) Change-Id: I11c65ad26cb9cd856cf16b1dccbd4223ba086645 Signed-off-by:
Robert Lyon <robertl@catalyst.net.nz> Signed-off-by:
Aaron Wells <aaronw@catalyst.net.nz>
-
- 02 Sep, 2013 1 commit
-
-
Aaron Wells authored
Bug 1184450. I don't know why this works but it does. When attempting to connect to a UTF16 MySQL DB, if you first set the connection's character set to UTF8 and then try to set the SQL_MODE to POSTGRES, it errors out on trying to set the SQL_MODE. But if you try to set the SQL_MODE first, and *then* set the character set to UTF8, it works fine. Change-Id: I3528a92662708c081b15a111c625f0559fbd1c04
-
- 24 Feb, 2013 1 commit
-
-
Aaron Wells authored
Functions created by create_function() don't ever get deallocated, which contributes to scripts running out of memory. Change-Id: Ifd78bf05bab67a9b1593a7d9722dd2433e7ad7ca Signed-off-by:
Aaron Wells <aaronw@catalyst.net.nz>
-
- 17 Aug, 2012 1 commit
-
-
Kristina Hoeppner authored
Spelling corrected only for strings that appear in Mahara code. Third-party code has not been touched. Change-Id: Ic3556fb19aa14a231f30a91d810134ed0e4e2889 Signed-off-by:
Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
-
- 28 Jun, 2012 1 commit
-
-
Richard Mansfield authored
The upgrade to convert textboxes to artefacts tries to insert 5000 rows at a time into the artefact table. This is too much data for MySQL's default max_allowed_packet setting. Reducing the number of rows inserted per query to 100 (or a bit larger, depending on max_allowed_packet) fixes the upgrade problem. See https://mahara.org/interaction/forum/topic.php?id=4474#post20477 Change-Id: I8335323e247abb570a434cd105d4590cad103018 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-