Skip to content

GitLab

Switch branch/tag
  1. 29 Sep, 2019 1 commit
  3. 20 Sep, 2019 2 commits
  5. 30 Aug, 2018 1 commit
  7. 01 Jul, 2018 1 commit
  9. 31 May, 2018 1 commit
    • Mark Webster's avatar
      Bug 1771362: Fix timezone issues. · bc25beec
      Mark Webster authored 
      Adds timezone dropdown the site settings. If no timezone selected
it uses site settings country to determine correct timezone and sets
that in the database.
PHP and DB session timezones will then assume this setting for all times.

This makes setting $cfg->dbtimezone obsolete - there is a warning to
admins to update their timezone setting on admin dashboard.

Limitations:
- A timezone or country MUST be selected in site options.

- Will not correct existing incorrect times, as no timezone info was
stored in the DB for dates/times, so it's impossible to determine what timezone
was used when saving.

- Changing the timezone will not adjust the display of existing times, for the
same reason.

behatnotneeded

Change-Id: I34c64cd51ece6758e76dd8c37007dcb316005845
      bc25beec
  11. 05 Mar, 2018 1 commit
  13. 14 Dec, 2017 1 commit
  15. 04 Dec, 2017 1 commit
    • Ghada El-Zoghbi's avatar
      Bug#1735072: Upgrade error with event_log updated columns · a7acb6a5
      Ghada El-Zoghbi authored 
      Several issues resolved:
1. The event_log.time column has been removed
and replaced by ctime. The handl_event() call is using
the new column even though the new column has
not been created yet in the upgrade script.
Therefore, include both columns in the event handling.

2. The 'deleteartefacts' event stores multiple
artefact IDs in the one event_log record. Therefore,
there is not a one-to-one relationship when converting the
record to the new format. Ignore the record when setting
the resourceid and resourcetype.

3. In the 'saveartefact' and 'deleteartefact' events,
not all of the event_log records have 'id' and 'artefact'.
Ignore setting the resourceid and resourcetype fields
when the data is not available.

4. For newer versions of Postgres and MySql, utilise
the json dattype to convert the data held in the
event_log.data column. This will speed up the
processing of the table for sites with large data
in the event_log table.

Sponsored by Australian National University

behatnotneeded

Change-Id: If068dac825b9cef6301cd970f0a368124a67b3f1
      a7acb6a5
  17. 09 Sep, 2017 1 commit
  19. 03 Sep, 2017 1 commit
  21. 24 Nov, 2016 1 commit
  23. 23 Aug, 2016 1 commit
  25. 14 Dec, 2015 1 commit
  27. 25 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Make get_record warn instead of dying, by default · bc354483
      Aaron Wells authored 
      Bug 1515929: Usually when we use get_record(), we're
querying against a record that has a uniqueness constraint
guaranteeing that it is unique, in which case the PHP
code that dies on non-uniqueness is redundant.

In the remaining cases, we're dealing with records
that for some reason can't have a uniqueness constraint,
and the dying just causes the site to entirely stop
working, when it would be more useful to have it continue
to work but throw a warning message to the logs.

behatnotneeded: Covered by existing test cases

Change-Id: I264f72e3a8904293d78909410f68b29f2c78db3c
      bc354483
  29. 16 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Disable transactions in MySQL (Bug 1514608) · e52be8a3
      Aaron Wells authored 
      Mahara's usage of transactions has been causing
major deadlock issues in MySQL with InnoDB.
The immediate fix is to disable them.

behatnotneeded: Covered by existing tests

Change-Id: I2c7e6424e2d58502acd26fdd5d05c797e4ee5eac
      e52be8a3
  31. 20 Oct, 2015 1 commit
  33. 23 Sep, 2015 1 commit
  35. 26 Mar, 2015 1 commit
  37. 22 Mar, 2015 1 commit
  39. 02 Mar, 2015 1 commit
  41. 29 Jan, 2015 1 commit
  43. 27 Jan, 2015 1 commit
  45. 21 Jan, 2015 1 commit
  47. 09 Jan, 2015 1 commit
    • Aaron Wells's avatar
      Allow default null $value in get_records_* methods · f0973c63
      Aaron Wells authored 
      Bug 1401324: Since both these methods pass through to
get_recordset_sql(), which accepts a null $value, we should
allow these to accept a null $value as well

Change-Id: Ic1abf516f9a03e05f848d395e7635d458802ba9c
      f0973c63
  49. 10 Dec, 2014 1 commit
  51. 04 Dec, 2014 2 commits
    • Aaron Wells's avatar
      Enforce array (or NULL) sql param for get_recordset_sql() · cc98e393
      Aaron Wells authored 
      Bug #1384473

Change-Id: I7a74dc86cb3794b8442084e30f2d13a89b80a7bd
      cc98e393
    • Robert Lyon's avatar
      Adjusting get_column_sql() default value to false (Bug #1384473) · 40991843
      Robert Lyon authored 
      On install an error was being thrown:

In Postgres:
Failed to get a recordset: postgres7 error: [-1: ERROR: bind message
supplies 1 parameters, but prepared statement "" requires 0] in
adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN
('profileinfo','myviews','mygroups','myfriends','wall'), Array)

In Mysql:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near 'NULL' at line 1] in
adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN
('profileinfo','myviews','mygroups','myfriends','wall')NULL, )

Change-Id: Ifd74ccfce5c8352db2fdc55378f9eede236354c7
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      40991843
  53. 11 Nov, 2014 1 commit
  55. 04 Jun, 2014 2 commits
  57. 09 May, 2014 1 commit
    • Yuliya Bozhko's avatar
      Some artefact refactoring (Bug #1298646) · 3ba72d71
      Yuliya Bozhko authored 
      Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: default avatarYuliya Bozhko <yuliya.bozhko@totaralms.com>
      3ba72d71
  59. 11 Mar, 2014 1 commit
    • Nathan Lewis's avatar
      Fix phpunit testing framework (Bug #1288439) · 774a884c
      Nathan Lewis authored 
      - uninstall does not remove triggers that are added by
notification/internal module, causing errors when trying to re-run
testing (when testing, all database objects are deleted then recreated,
but the triggers already exist).

- assertType is no longer available and should use assertInternalType
instead (for int value).

- there is a typo in lib/ddl.php find_key_name function which causes
problems when creating and removing the test db tables.

- there is a logic problem in lib/ddl.php uninstall_from_xmldb_file.
array_multisort is being used incorrectly and sometimes causes the
primary key to be removed before foreign keys which results in a
database error.

- the function removecolumn in lib/view.php has changed and the test is
no longer valid.

Change-Id: Ibee48e557912e09cf6533132ba771bfb2c44749f
Signed-off-by: default avatarNathan Lewis <nathan.lewis@totaralms.com>
      774a884c
  61. 22 Jan, 2014 1 commit
  63. 16 Dec, 2013 1 commit
    • Aaron Wells's avatar
      Override MySQL's check for accidental large queries · 03f4ecd3
      Aaron Wells authored 
      Bug 1070046: MySQL has an optional server config option, "MAX_JOIN_SIZE",
which throws an error if you try to run a SQL query that MySQL's strategizer
thinks will require it to evaluate more than MAX_JOIN_SIZE rows. This is
intended to prevent the user from accidentally running giant queries that
will never finish, but some Mahara queries (which are large but will finish)
can trip it. Adding SQL_BIG_SELECTS=1 tels it that our queries are *not*
accidentally large.

Change-Id: I6db4699ea765d3213d13eb93b8de098914db24e0
      03f4ecd3
  65. 14 Oct, 2013 1 commit
  67. 02 Sep, 2013 1 commit
    • Aaron Wells's avatar
      Prevent non-helpful sql_mode error when trying to connect to a UTF16 DB · 034fe443
      Aaron Wells authored 
      Bug 1184450. I don't know why this works but it does. When attempting to
connect to a UTF16 MySQL DB, if you first set the connection's character set
to UTF8 and then try to set the SQL_MODE to POSTGRES, it errors out on trying
to set the SQL_MODE. But if you try to set the SQL_MODE first, and *then* set
the character set to UTF8, it works fine.

Change-Id: I3528a92662708c081b15a111c625f0559fbd1c04
      034fe443
  69. 24 Feb, 2013 1 commit
  71. 17 Aug, 2012 1 commit
  73. 28 Jun, 2012 1 commit