1. 04 May, 2012 1 commit
  2. 21 Feb, 2012 1 commit
  3. 17 Feb, 2012 1 commit
  4. 02 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Fix remote avatars broken by 'profileiconbyid' commit (bug #924777) · ab3b5a19
      Richard Mansfield authored
      Commit 011c5039 changed lot of thumb.php urls to use the
      type=profileiconbyid parameter (which takes an artefact id) rather
      than type=profileicon (which takes a user id, and which cannot be
      cached).
      
      Unfortunately, when a user has no locally stored profile icon, use of
      type=profileiconbyid stops their remote gravatar image from being
      displayed.
      
      This commit updates the thumb.php urls that were changed in commit
      011c5039 to use the profile_icon_url() function, which respects
      remote avatars when no local profileicon is available.
      
      In some cases this requires a new size of the no_userphoto.png image,
      so three new sizes are added in the raw theme.  The four no_userphoto
      images in the custom theme were duplicates of those in raw, and are
      removed.
      
      Finally, the type=profileiconbyid change from commit 011c5039
      
       in the
      viewacl.tpl template has been reverted back to type=profileicon.
      Because this url is constructed in javascript, it is not worth the
      trouble to use a profile_icon_url call here until the number of
      requests to thumb.php really becomes a problem.
      
      Change-Id: I7dce7090842999fe090dc2d8c481cb4aca7720d5
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      ab3b5a19
  5. 16 Jan, 2012 2 commits
    • Richard Mansfield's avatar
      Use type=profileiconbyid in more requests for thumb.php · 011c5039
      Richard Mansfield authored
      
      
      This can help to reduce the overall number of requests for thumb.php
      because the 'profileiconbyid' urls are cached for longer by the
      browser.
      
      (Where the profile_icon_url function can be used, we also avoid the
      need to generate additional requests for users without profileicons,
      when remote avatars are disabled.  But because profile_icon_url relies
      on the nouserphoto icon being available in the requested size, we
      can't use it everywhere until we either generate the nouserphoto icon
      in more sizes, or change all those pages to use standard sizes.)
      
      Change-Id: I81c5c5f4b7f9136bf9b6a6f711e55a4bceb6fa14
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      011c5039
    • Richard Mansfield's avatar
      Fix sql error in bulk user deletion (bug #916998) · 9bc9d15c
      Richard Mansfield authored
      
      
      When a user is deleted, deletion of notification_internal_activity
      records can fail with a foreign key error when another row in
      notification_internal_activity has a parent field pointing to one of
      the records we are trying to delete.  This is fixed by setting the
      parent fields to null before deletion.
      
      The handle_event('deleteuser') call in delete_user is also moved
      inside the transaction, to ensure that deleted users will have their
      notifications deleted correctly.  Other subscribers to the deleteuser
      event in core should be unaffected.
      
      Change-Id: Ibc0a695e986bb175a00441f02d3e40abf38cbcde
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      9bc9d15c
  6. 11 Jan, 2012 1 commit
    • Richard Mansfield's avatar
      Cache user records in calls to display_default_name · bb91e704
      Richard Mansfield authored
      Commit 0cdaaa1d
      
       introduced a lot of calls to display_default_name.
      Unfortunately this bypasses the user record caching that happens
      inside display_name, so it produced a lot of new queries, most notably
      on profile pages, where a single user's name gets displayed several
      times.
      
      This change moves the caching of user records into another function,
      so it can be shared by display_name, display_default_name, and
      profile_icon_url.
      
      The search_user function is also modified to fetch the admin status
      and profileicon id, to stop profile_icon_url producing more queries.
      
      Change-Id: Id1993decf164e7d0563a7d277444402fc6350b3a
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      bb91e704
  7. 10 Jan, 2012 4 commits
  8. 24 Nov, 2011 1 commit
    • Richard Mansfield's avatar
      Remove wwwroot from notification urls (bug #849716) · 4384e747
      Richard Mansfield authored
      
      
      Urls stored in the url field of notification_internal_activity contain
      the site's wwwroot.  This leads to broken links when the wwwroot is
      changed.  It also dangerously turns what should be local links into
      remote ones when for example a production database is copied into a
      test Mahara instance.
      
      This patch does three things:
      - Removes the wwwroot from urls passed to ActivityType constructors
      - Adds the wwwroot back on the url when sending email and emaildigest
        notifications, and when displaying them on the site.
      - Removes the wwwroot from the url in all existing rows of
        notification_internal_activity.
      
      Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      4384e747
  9. 30 Sep, 2011 1 commit
  10. 29 Sep, 2011 3 commits
  11. 28 Sep, 2011 1 commit
  12. 15 Sep, 2011 1 commit
  13. 13 Sep, 2011 1 commit
  14. 06 Sep, 2011 1 commit
    • Richard Mansfield's avatar
      Fix display_name group membership lookups · d8d579e3
      Richard Mansfield authored
      
      
      When dispay_name is called, a check is made to see if the logged-in
      user is a tutor in one of the displayed user's groups, and if so,
      the logged-in user is allowed to see the displayed user's real name.
      
      Recent group changes allowed the submission of views to be independent
      of the grouptype (which only defines the list of roles), and the tutor
      lookup was being performed even in groups that don't accept submissions.
      
      Change-Id: I8143a2a8c966f67da75230ff0c0b572437f05190
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      d8d579e3
  15. 02 Sep, 2011 1 commit
  16. 24 Aug, 2011 1 commit
  17. 09 Aug, 2011 2 commits
  18. 02 Aug, 2011 1 commit
    • Hugh Davenport's avatar
      Remove duplicate users when showing online users · f44a5159
      Hugh Davenport authored
      
      
      Happens when all the users institutions have selected at most
      Institution only for displaying online users. If a user was in
      more than one institution as another user, then the user was displayed
      twice (or multiple times)
      
      This patch adds a DISTINCT condition to the select statement, which only
      displays the users once
      
      Bug #794368
      
      Change-Id: I106072cf2063d889fc6451ff57ee1d2dd94ebb67
      Signed-off-by: default avatarHugh Davenport <hugh@catalyst.net.nz>
      f44a5159
  19. 27 Jul, 2011 1 commit
  20. 26 Jul, 2011 1 commit
  21. 20 Jul, 2011 2 commits
    • Piers Harding's avatar
      Enable multiple auth_remote_user connections · 34ebbfe4
      Piers Harding authored
      
      
      Bug #810302
      
      Enable links to multiple auth instances to be maintained so that
      users can have dual login eg: internal + auth/saml etc.
      
      Improve validation around switching auth_instance and
      changing the remoteuser at the same time.
      
      Add checks to ensure remoteuser does not get clobbered by update
      for another user.  Allow override for the CVS upload case (file == unit
      of update).
      
      Change-Id: I5321c0270aeaa93bd193e8e759b08ab7f8b50ded
      Signed-off-by: default avatarPiers Harding <piers@catalyst.net.nz>
      34ebbfe4
    • Eugene Venter's avatar
      Pagination changes · 634b54dc
      Eugene Venter authored
      
      
      Bug #812113
      
      Added 'jumplinks' and 'numbersincludeprevnext' options to some views.
      
      Change-Id: I7bf296a11c16191369d11983c75e1252df315709
      Signed-off-by: default avatarEugene Venter <eugene@catalyst.net.nz>
      634b54dc
  22. 19 Jul, 2011 1 commit
  23. 12 Jul, 2011 1 commit
  24. 07 Jul, 2011 1 commit
  25. 05 Jul, 2011 1 commit
  26. 20 Jun, 2011 2 commits
  27. 17 Jun, 2011 3 commits
  28. 16 Jun, 2011 2 commits