As they are set to TITLE we can just assign TITLE to PAGEHEADING in
the smarty function call.

We can later override the PAGEHRADING with
$smarty->assign('PAGEHEADING', string); if we need to.

Have also updated a few files where TITLE was not defined.

behatnotneeded - everything should work as before

Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Mar 07, 2016 and Robert Lyon committed Mar 21, 2016

Add behat tests

Change-Id: I905af729d2cda76d5c6ff31b29b9d21c3dc67505

To make this similar to PAGEHEADING / TITLE for consistency

This allows the for it to display when an AccessDeniedException is
thrown.

Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
the wrong order.

behatnotneeded - existing tests should be fine

Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Now that 'mahara' can have blog/blogpost artefacts we want to ignore
them from site menus options for logged in links

Change-Id: I8d1be32678ae97d93187181eb4aedcb331e543eb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Because if we have a latest pages block but no group pages listed then
the template will not initially compile as there has been no call to
require lib/group.php

Actually we should avoid having non basic function calls in the template
so I'll move all instances of group_homepage_url() in templates out
to the php that generates the data.

behatnotneeded

Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Mar 16, 2016 and Robert Lyon committed Mar 19, 2016

Bug 1557896: When you first click in Select2, it fires off an
aqax request with no "q" value (because there's no query string
yet). We return a "required parameter missing" error message in
a JSON object, which causes a Javascript warning in the browser.

Better to just treat it like an empty q, instead of a missing q.

behatnotneeded - unable to test for issues in console

Change-Id: I81c4cfe77c51fce735cfd2628aaed1e40cc35940

behatnotneeded

Change-Id: I6c59b9bb13384f0a4cdf71d1ab82fb219a9137ee

This is an interim fix only until the functionality
can be corrected to not allow people to pick access
dates outside of the overriding start / end dates.

behatnotneeded: Just a lang string that doesn't
exist in a test yet.

Change-Id: Iff7841084a798e5e184a9842465ac947c62b000d

Liam Sharpe authored Mar 17, 2016 and Kristina Hoeppner committed Mar 18, 2016

behatnotneeded

Change-Id: Idcb92dda82a8f1eaafa20f258639b5e2d2b78113

When we upgrade from earlier versions views need to be saved that
expect the numcolumns field to exist before we get round to dropping
it. So the View class needs to be able to define a default value for
it.

behatnotneeded - unable to test upgrades

Change-Id: Ic70add18e814975289a7145e8e91454e3699a234
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1558393

behatnotneeded: API change only

Change-Id: Iaa88093a12603db177dc475790b0b0bda8bda163

Bug 1558387

With this, we don't have to remember to bump HTML.DefinitionRev in
html_clean(), or clear the htmlpurifier directory in dataroot.

behatnotneeded: API change only

Change-Id: I15cd291fd8e5d7d5c357f1595a89f34f44236e7d

It got merged before I noticed the comment about needing a behat test

Change-Id: I1fd5bbdd88bc88cbde17992b9d7c9709f44b8e6f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As there is already code to verify/submit group page comment
moderation I've added a bit of code to show the private pre-moderated
comments on group pages to group admins so they can moderate them.

Change-Id: Ia117ee00d26c7cf9050345488d65169caff16694
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded existing tests should be enough

Change-Id: I6316c6301c703353928c9e6210e02cdfc25151a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Since this blog post object wasn't committed after having its
description updated, it causes the destructor to try to save
the changes to the database, and that sometimes throws a fatal
error if PHP garbage-collects the global $db variable before it
calls this constructor.

behatnotneeded: Covered by existing "edit_journal.feature"

Change-Id: I5056ecce91b823b245cb5bd29f0676a35a6afd45

Robert Lyon authored Jan 27, 2016 and Aaron Wells committed Mar 16, 2016

As this is confusing debugging issues with view layout as the
view.numcolumns column is not actually used anymore for working
out the layout, but it's still being populated when a page is made.

behatnotneeded - existing tests will do

Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>