Jean-Philippe Gaudreau authored Jan 05, 2016 and Robert Lyon committed Feb 03, 2016

Table from plugin artefact.blog/blocktype:taggedposts wasn't deleted
because plugins inside an artefact were not retrieved in the uninstall
process.

behatnotneeded: Not related to the interface, only unit tests.

Change-Id: I82f5ca40f2e6b17869228aef0d81e21ba69ed675

Aaron Wells authored Feb 02, 2016 and Robert Lyon committed Feb 03, 2016

Bug 1540667: Prior to commit c4329032, we were loading htdocs/artefact/internal/lib.php
on *every* page load, via the login auth method's code that checked for missing
internal artefact files. This call meant that we also loaded artefact/lib.php on
every page load.

Removing that for performance reasons, caused some calls to embeddedimages.php to fail,
when they were on pages that aren't otherwise requiring artefact/lib.php.

behatnotneeded: Can't use the image embedder from Behat

Change-Id: Ibcdbd17d289f2b4614c28ad522173286acc9bc27

Liam Sharpe authored Jan 11, 2016 and Robert Lyon committed Feb 02, 2016

Comprises two fixes:
1. Icon in profile sidebar next to the Moodle instance's
name
2. Mentioning of the Moodle instance in the "Online users"
sidebar

behatnotneeded

Change-Id: I3c1c09df9156834dc79313b8c30e5264dda2e6ad

Liam Sharpe authored Jan 15, 2016 and Robert Lyon committed Feb 02, 2016

Uses a variable for the color for themes: raw & default

behatnotneeded

Change-Id: I9aa0210bb80ebd22b909e7494b1e612f71712f4c

Bug 1540181

Change-Id: I9365d725453a86581d31937d0bb6057c81926a03

Mason Warring authored Jan 22, 2016 and Robert Lyon committed Jan 27, 2016

Made the message of 'The uploaded file was too big' less ambigous by
supplying the maximum upload file size in the message.

behatnotneeded

Change-Id: I9bb96b01f71f8e785d84d9a2e2234e58a1c342d6

Son Nguyen authored Jan 22, 2016 and Robert Lyon committed Jan 26, 2016

when users belong to only one institution.

behatnotneeded

Change-Id: Iaf68c98efd582da3ed5a692f52168e38560bb352

behatnotneeded

Change-Id: I6fd204b5fae3bf37c3fd20bf7890ccf2e3915821

behatnotneeded

Change-Id: Ie93b1fedb74684d23b0cbcf1b20a16886f326f16

Walter Lowe authored Jan 20, 2016 and Robert Lyon committed Jan 21, 2016

behatnotneeded

changed the border radii on class btn-group-vertical so all corners have 4px
border radius

Change-Id: I23f26deaf739c311bfe0fcdb6e1da4cb44c160df

A stright drop in change - no local modifications

behatnotneeded - unable to test is mobile via jenkins

Change-Id: I1872a65115684ba2b11202a339e58623dbf2f424
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Loads faster and avoids using image files

behatnotneeded - srtaight dropingover existing version

Change-Id: Ic4414145d10b9821453de5aa68d359b849509aef
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To stop the text flowing out on smaller screens

behatnotneeded - design only change

Change-Id: I8b0a24ce339aa17f503ca9c84b68591bef05dae9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

On the:
- collection lists
- journal /journal entry lists
- plans/tasks lists

And tidying up the options so they are similar to view pagination
options

behatnotneeded

Change-Id: I64f00e075d0b2e6bb92d6f7d627880629ad5575e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Liam Sharpe authored Dec 07, 2015 and Robert Lyon committed Dec 16, 2015

behatnotneeded

Change-Id: I39faf88ac8932891a704868f5282a5794ae1387d

Liam Sharpe authored Oct 28, 2015 and Robert Lyon committed Dec 16, 2015

behatnotneeded

Change-Id: I536f7d4ab8bd96d653e0ae3bba635437f0d2c17c

Bug 1526076: I believe the initial intent was that
Mahara core, and/or each plugin, could add a value
to its version.php file indicating "disablelogin"
true or false. And in this way, an upgrade could
indicate whether it was a small enough upgrade that
users did not need to log out for it.

However, in practice this is not practical because
we don't know what version of Mahara the user is
upgrading from, and that is what determines whether
or not it's a "stable" upgrade.

Additionally, the core disablelogin has been set to true
for the past 7 years, and the plugin disablelogin
setting no longer has any effect.

Removing disablelogin should hopefully make our
maze of init.php auth_setup() login stuff a little
bit easier to follow.

behatnotneeded: Covered by existing tests

Change-Id: I5f8a2b4faa95b9225bb926de6a54a622ea1a9618

Change-Id: Ib3aab13c03cb7486072384da518b27ec0f4a2f0a

Bug 1526101: This should help make it clearer what's going
on in init.php and the related auth code, by making the
distinction between $CFG->siteclosed and $CFG->siteclosedbyadmin
clearer.

behatnotneeded: Covered by existing tests

Change-Id: I8bc728622ae965ce25b55ee4b55278771fc1eedc

When moving them downwards in a column from a non-first position to a
non-last position with a jump greater than one place

behatnotneeded

Change-Id: Ie9bacc4a1a4ef77efd4e481c9ab3713885821dc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1523499: Old wiki.mahara.org links without the "/wiki",
and HTTP links that should be HTTPS.

Also updated the installer release notes link to point to
the base "Release_Notes" page in the wiki, because we no
longer maintain separate wiki pages for each release.

behatnotneeded: Covered by existing tests

Change-Id: I02e80eb4d8df5adddee88e77156e8e103ca24c51

If we have special chars like " or > in a feedback message they get
saved to db as htmlspecialchars like " or $gt;

When we go to display them we turn the & part into a specialchar again
leading to bad display.

Change-Id: Ie66dd599029f0939938f0d1d829c4156b5db6d56
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded - existing tests should suffice

Change-Id: I69a59b5f70bc6e5e3379106faf975f9c99af07b0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When we are trying to fetch a page by urlid and there are duplicates
as the pages will not be the same

behatnotneeded

Change-Id: I82068aefc99e051a4ecd3aceb5655fc96631b0f5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Stopping 'The theme "" is missing' message

behatnotneeded - only an info alert when not in production mode

Change-Id: Iacff81b2fd3d6ed264ca608ab00d3dcbf325231b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ia5eaf6fcb7fabbd1182989cf8c518bcbb2c7b416
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Includes:
1) Group -> my groups
2) Group -> find groups
3) Admin -> Users -> Suspended ...
4) Admin -> Group
5) Content -> Journal -> entries list

This is also to standardize pagination

behatnotneeded

Change-Id: Iad9edc668b3f5f8e8c71408c842cbf28a69fa2f4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I9f2534a11a71f6c356ee836db1386a0c1bbebf8d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 6 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I70f77d04efa55a14680da5427acc1310b517ec3b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 3 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I4c563a83ee70b24fc0111fe200a3b2d4514b9590
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is 2 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I7741ae0d436d7e11fe248307936757d3d8027cc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Nov 18, 2015 and Aaron Wells committed Nov 25, 2015

Set the state of the libxml entity loader & use internal
errors settings, back to what they were before we called
them, as a workaround to https://bugs.php.net/bug.php?id=64938

,
which causes them to be shared by all threads in a single
process.

behatnotneeded

Change-Id: I0720146b1e91c24095a18636e09981830ef4ce8f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Problem is we need to do a type comparison when checking how to apply
the title as group/institution pages have owner as null

Change-Id: I0a9128e329f180f1a8fbacae7803e38159f6f88a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1515929: Usually when we use get_record(), we're
querying against a record that has a uniqueness constraint
guaranteeing that it is unique, in which case the PHP
code that dies on non-uniqueness is redundant.

In the remaining cases, we're dealing with records
that for some reason can't have a uniqueness constraint,
and the dying just causes the site to entirely stop
working, when it would be more useful to have it continue
to work but throw a warning message to the logs.

behatnotneeded: Covered by existing test cases

Change-Id: I264f72e3a8904293d78909410f68b29f2c78db3c

Robert Lyon authored Nov 16, 2015 and Aaron Wells committed Nov 24, 2015

Rewrite to use ensure_record_exists instead of re-inventing
the wheel.

behatnotneeded: Covered by existing tests

Change-Id: Id57be0e00f14ab65dd40b4ef13f696e72f608d46
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1518796

behatnotneeded: Covered by existing tests

Change-Id: I996e4562441140a6163dbf0b9dff4ee2894ffd83

To allow for better performance. Have taken what a user contributed
and tried to make it even more efficient still.

behatnotneeded - existing tests should take care of this

Change-Id: I91ff4e0b5e3e4e22ee437cce5e3da33bace1e736
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1517658

Change-Id: I531a1c95b94910e564e71e1f2dc26754eefa45d5
behatnotneeded: platform-specific bug

Because some systems may not have all the available data we should
check if the data exists before trying to display it.

To test:
Before patch change the line in lib/mahara.php
 if (function_exists('posix_times')) {
to
 if (!function_exists('posix_times')) {

and make sure the 'perf_to_log' config option is set to true

This will cause the errors we are trying to deal with to show up

behatnotneeded

Change-Id: If9610fa0eaf4c8bb036b21c1c75e10d828de7934
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Mahara's usage of transactions has been causing
major deadlock issues in MySQL with InnoDB.
The immediate fix is to disable them.

behatnotneeded: Covered by existing tests

Change-Id: I2c7e6424e2d58502acd26fdd5d05c797e4ee5eac