1. 23 Apr, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug785472) Remove unneeded raise_memory_limit calls · 039564a5
      Nigel Cunningham authored
      On the basis of my profiling and testing over the last week,
      all of the scripts affected by this patch don't need their
      raise_memory_limit calls. Ensure_sanity currently sets the
      memory limit to 128MB, which has been seen to be more than
      sufficient for each of these use cases.
      
      Tests have involved at least 1000 records being imported in
      each case, and sometimes as many as 20,000. I would have
      liked to have tested with some really full profiles (eg
      lots of pictures and content), but am satisfied that there's
      enough margin to cover those cases. In any case, such files
      are often handled using external apps and therefore won't
      be counted toward PHP's memory use anyway. Finally, the
      limit can easily be increased by the user if necessary for
      a particular case.
      
      Change-Id: Ifecc83fd47da51268bae6cbd6960735eb91f9403
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      039564a5
  2. 21 Nov, 2014 1 commit
    • Tobias Zeuch's avatar
      Make CSV-Import autodetect delimiter · 7be6438a
      Tobias Zeuch authored
      Bug 1393472: Automatically detect the delimiter used to store the fields in the
      csv field. The problem this should solve is that Microsoft Excel uses a
      semicolon instead of a comma if the language setting of Windows is set to
      German.
      The first line of the csv-file contains the header fields so we use that line
      to check, if it contains a comma or a semicolon since none of these appears in
      the header field names itself.
      
      Change-Id: I833041eb2169fc5ccc9557e0debf3f03c8daf7cc
      Signed-off-by: default avatarTobias Zeuch <tobias.zeuch@kit.edu>
      7be6438a
  3. 14 Oct, 2013 1 commit
  4. 24 Feb, 2012 1 commit
  5. 30 Jun, 2011 1 commit
  6. 13 May, 2011 1 commit
  7. 19 May, 2010 1 commit
  8. 15 Sep, 2009 1 commit
  9. 10 Aug, 2009 2 commits
  10. 26 Jun, 2009 1 commit
    • Elliot Pahl's avatar
      Add lib/csvfile.php and update admin/user/uploadcsv.php to use it. · c10d562d
      Elliot Pahl authored
      Add non-functional lib/csvfile.php.
      (cherry picked from commit 34b4960d5659fdff1d0043c09aa193f10f3e5b50)
      
      CsvFile will now parse a csv file and return an object with errors, headers, and data.
      (cherry picked from commit ac62b4a53265ded746e32dfb2f41943bf62c849a)
      
      Use mandatory fields correctly in csvfile.php.
      (cherry picked from commit e378fc7de6f127cd0c9bc3ab48912466f3d42351)
      
      Remove checking for an error that will never be reached.
      (cherry picked from commit 36f2a90218145f349763aada2c469fd5e6eade71)
      
      Replace references to headers with format.
      (cherry picked from commit 002a602cc016986df03752bca551832bbb3ffda9)
      
      Throw exception for no CSV header row if there are no other errors.
      (cherry picked from commit e09686075502c50506ebd0dc737021914d1ec03c)
      
      Update uploadcsv.php to use csvfile.php
      (cherry picked from commit 4070d03a0c7ff811361038781bd3194d5b98d4b0)
      
      Set an error on the upload users form and return if a duplicate email address is found.
      (cherry picked from commit f6dba540e90582b139d0748802f40e3cc1865c49)
      
      Also check profile for duplicate email addresses.
      (cherry picked from commit 4f5d8eb661c8abd8d9553e3c193d7f15397a91ee)
      
      Add checks to see if the filename exists.
      (cherry picked from commit ba5bdb0e9c9dbc77a422d48c3a0609258a2b0c15)
      
      Add a TODO for documenting csvfile.php.
      (cherry picked from commit a3ebd09be81f8908aa2cdd35a92798ea937cffc6)
      c10d562d