GitLab

* changes:
  Bug 1769546: A few more changes to update raw_old theme for backported patches
  Bug 1769546: Needing to update raw_old theme for backported patches

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7d9d1b29)

Cecilia Vela Gurovic authored Apr 30, 2018 and Robert Lyon committed May 11, 2018

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
 commit 2319c045

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2
(cherry picked from commit 790e51d1)

If the patches have template changes in them.

Commits for 17.10 missing raw_old changes
2f8ced49
014c7214
8a286245

Sponsored by The Australian National University

behatnotneeded

Change-Id: I3702d376138e2fe259f68c25c83584fb9543388a

If the patches have template changes in them.

Commits for 17.10 missing raw_old changes
da597048
2d55c32d
efd06c9a
12d0a411
76909b6f



Sponsored by The Australian National University

behatnotneeded

Change-Id: Ie444da9d81b2ed80873c5addb47dd19cba4ccd9e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Apr 27, 2018 and Robert Lyon committed May 03, 2018

When changing the code to create a anonymous function
the parameter for the can_delete_wallpost function
was wrongly left as the name of a variable inside a string
instead of the actual variable

behatnotneeded

Change-Id: I53d6f2154cce910efa655d8d244b3c56d9f9b990
(cherry picked from commit 7f45661d)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit cff11225)
(cherry picked from commit 8a8b21e4)

When there are no blogposts made

behatnotneeded

Change-Id: I7a3b2bed818c66fd4edef188ed7ba475e54c3a4c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 087cb93d)

Rather than update db directly - we need to update the USER object

behatnotneeded

Change-Id: I31f8c6759dd621439c90ddc0f0dc8a344359d5d9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 4adf4a01)
(cherry picked from commit 6905c539)

Cecilia Vela Gurovic authored Mar 26, 2018 and Robert Lyon committed Mar 28, 2018

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb
(cherry picked from commit 5ccfbdd3)
(cherry picked from commit c1b343d4)

Robert Lyon authored Mar 26, 2018 and Cecilia Vela Gurovic committed Mar 27, 2018

We do a bunch of iframe / js tricks to get the progress bar to work
and then rely on session for the file name to serve it at the end

This change just passes only the file name to the js redirect and then
rebuilds the full path on return. Because we use the user's id in full
path we can make sure only the valid logged in user can fetch the file

behatnotneeded

Change-Id: I6478df19465ad8e1075343cb40e6f5360061b56a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit ba36e509)

The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0465c54d)
(cherry picked from commit a4b81e7d)

Robert Lyon authored Mar 09, 2018 and Cecilia Vela Gurovic committed Mar 22, 2018

behatnotneeded

Change-Id: I83659cec81fbfdaaf37842be00cd83cc1e9185cc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8eb1878c)

Robert Lyon authored Mar 08, 2018 and Cecilia Vela Gurovic committed Mar 22, 2018

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 53914399)

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc
(cherry picked from commit 02cbb9ed)
(cherry picked from commit 1bbff559)

Cecilia Vela Gurovic authored Mar 20, 2018 and Robert Lyon committed Mar 21, 2018

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604)
(cherry picked from commit 08ff7cf6)

Cecilia Vela Gurovic authored Mar 15, 2018 and Robert Lyon committed Mar 19, 2018

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04)
(cherry picked from commit 2a65c6d7)

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0
(cherry picked from commit ec18759b)

Ghada El-Zoghbi authored Jan 24, 2018 and Robert Lyon committed Mar 08, 2018

When a user shares their socialprofile on their
profile page and another user searches
for that social profile (using elsaticsearch),
the icon attribute is never set.
Because social profiles are external to Mahara,
we can display the link to users.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I94282bed7904f9d37a50b8e0fd32c5f2d174c704
(cherry picked from commit 7f65b938)

Cecilia Vela Gurovic authored Mar 05, 2018 and Robert Lyon committed Mar 07, 2018

fixed for Dashboard page to show the skin

behatnotneeded

Change-Id: I8720025e854d60c03980f5857786ce8171fe7db1

Because MariaDB does not have JSON cast type but does have a higher
version number than 5.7

behatnotneeded

Change-Id: I5a66ddb8c382a68fde189b420088bb29ef06893c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit ca22b51f)

We were confusing user active with auth active values from db call
So changed the auth 'active' to 'authactive'

Also add warning message to top of admin/users/edit.php page to
indicate that user has expired (similar to when user is suspended)

behatnotneeded

Change-Id: I437665cffa6f2d372ef4c5c39fad7bec183e3a2d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6b8396d6)

Also show a help icon to a form that is not shown

behatnotneeded

Change-Id: I603f42a757bd6b9617e59c1214c3e86e2930d995
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit af02288f)

Robert Lyon authored Jan 11, 2018 and Cecilia Vela Gurovic committed Feb 22, 2018

for things like OS, database, PHP etc so user knows it might not workl
on too newer system

behatnotneeded

Change-Id: Ie3f70f74728718950954925d660f06357dbbc5e6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d20cba42)

Cecilia Vela Gurovic authored Feb 20, 2018 and Robert Lyon committed Feb 20, 2018

behatnotneeded
Change-Id: Ic6f9e5df4ee083b972ed32aad2ae2cf240040f24
(cherry picked from commit 9d9499ad)

Also fix mistake with column sort order

behatnotneeded

Change-Id: Ie48900efe23c114dfbed6a3a90ca09844385ce3c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This way we can make the elasticsearch safer so that only mahara site
admins can access the index in write mode.

Also adjust how we pass the $hosts configuration to the client builder

behatnotneeded

Change-Id: I30218473ee6b87346783462d30ab627dce985338
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit fa4b44ea)

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There is an add_to_queue_access() function that is meant to check what
pages have had their access changed since they were indexed. It was
designed to catch the pages which have a start/stop date.

But that is not quite sufficient.

See bug report for more info

behatnotneeded

Change-Id: I160d074fc709c7e94c9c4cacab8f2c5e6c7e9a86
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Jan 19, 2018 and Robert Lyon committed Jan 25, 2018

Stop the error:  [SimpleSAML_Error_UnserializableException]:
[ARRAY]: The option 'Format' is not a valid string value

And allow the js submit form for the redirect of the POST to IdP

behatnotneeded

Change-Id: Id617e51722d55c286e9b5340cdc3f5922f7320bc

Adjusting ssphp to copy the extlib www/resources/ files into sp/resources/

Change-Id: Ie347d43b64638b4b36a198c5904cee6128ea6f7f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0405658c)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

To take advantage of the new things plus the bug fixes

behatnotneeded

Change-Id: Id7033f4c1308ecbfbd38a76e018a1a4ca4327dda
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 85c0d8df)

behatnotneeded

Change-Id: Idad7f09bfc88042110262e997b8f72bf3a895d0d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>