Commits · d5d67ffe4f3ed1607623a0c2bcae8f79b325468b · mahara / mahara

23 Mar, 2018 2 commits

Bug 1756764: Alert user if shared with rules 2nd option empty · d5d67ffe

Robert Lyon authored Mar 22, 2018



This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 55c50c1c)

d5d67ffe

Bug 1757254: Target the datepicker styles more directly · 06678eff

Robert Lyon authored Mar 22, 2018



To avoid them overriding the same styles being used elsewhere

behatnotneeded

Change-Id: I092d841224a811b8a1f398b9fe2bf76e5e9a143d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 3927b696)

06678eff

22 Mar, 2018 13 commits

Bug 1422492: Make user enter current password if changing their username · cc3a7294

Robert Lyon authored Mar 08, 2018 and

Cecilia Vela Gurovic committed Mar 23, 2018



As the change username option only appears on account index page for
those users that have an auth method allowing it we should make the
user also supply their current password when changign username

We hide the confirm password box for username change until they try to
change it

behatnotneeded

Change-Id: Ic05d3c258d331305ae5c07b952ea2a561a8badf1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8ad4343d)

cc3a7294

Merge "Bug 1758139: Set password policy explicitly during install" into 18.04_STABLE · 8cbdd2c8
Robert Lyon authored Mar 23, 2018

8cbdd2c8
Merge "Bug 1758135: Avoid overflow when dragging block choice" into 18.04_STABLE · 20681005
Robert Lyon authored Mar 23, 2018

20681005

Bug 1758139: Set password policy explicitly during install · c81d02ab

Robert Lyon authored Mar 23, 2018 and

Cecilia Vela Gurovic committed Mar 23, 2018



behatnotneeded

Change-Id: I4e173da5a289ba0106c29fed3dff234d92dfb175
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 24a98bdc)

c81d02ab

Bug 1758135: Avoid overflow when dragging block choice · 4b86fb16

Robert Lyon authored Mar 22, 2018 and

Cecilia Vela Gurovic committed Mar 23, 2018



This happens for long named blocks, eg creative commons license

behatnotneeded

Change-Id: Ib980431e505857393acb5540e3b998893759eba7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7e85d7ff)

4b86fb16

Bug 1754207: Allowing the actual assessment title for screenreader text · 8d4c658d

Robert Lyon authored Mar 16, 2018 and

Cecilia Vela Gurovic committed Mar 23, 2018



That is supplied by the matrix file

behatnotneeded

Change-Id: Ie5ee81a4f71d89bb7c891d6e2a318b70e0047b3b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 69f086dc)

8d4c658d

Bug 1757283: Use more generic javascript syntax to help IE · a4b81e7d

Robert Lyon authored Mar 21, 2018



The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0465c54d)

a4b81e7d

Merge "Bug 1749402: Avoid trying to get extra view data on a collection id" into 18.04_STABLE · 877e6e4a
Robert Lyon authored Mar 22, 2018

877e6e4a
Merge "Bug 1756726: Apply password policy on upgrade" into 18.04_STABLE · 480dff56
Robert Lyon authored Mar 22, 2018

480dff56

Bug 1749402: Avoid trying to get extra view data on a collection id · 6452184a

Robert Lyon authored Mar 09, 2018 and

Cecilia Vela Gurovic committed Mar 22, 2018



behatnotneeded

Change-Id: I83659cec81fbfdaaf37842be00cd83cc1e9185cc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8eb1878c)

6452184a

Bug 1755611: Should not call non static function statically in framework module · ffa1f84f

Robert Lyon authored Mar 08, 2018 and

Cecilia Vela Gurovic committed Mar 22, 2018



Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 53914399)

ffa1f84f

Bug #1756154: Fix link color in Primary School and Ocean themes for "Notifications" · e1ba168c
Liam authored Mar 22, 2018 and Robert Lyon committed Mar 22, 2018
```
behatnotneeded

Change-Id: I674cb8242cc1c522195647da5be4002440beafb8
(cherry picked from commit 113faa35)
```
e1ba168c

Bug 1756726: Apply password policy on upgrade · bc109ad5

Robert Lyon authored Mar 19, 2018



Force all users on internal auth to reset their password on login
after upgrade

behatnotneeded

Change-Id: Ia988a0a7b939969bf0638eb410d17e1c88282c31
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

bc109ad5

21 Mar, 2018 4 commits
- Bug 1755682: Check page can be deleted · 9182e6f3
  Rebecca Blundell authored Mar 14, 2018 and Robert Lyon committed Mar 22, 2018
```
Change-Id: Ic808728d22f1260a4cfa5f6b29db64c39314a857
(cherry picked from commit 6d4794ce)
```
  9182e6f3
- Bug 1755669: Behat: Check resume elements can be deleted · ecdf3d65
  Rebecca Blundell authored Mar 14, 2018 and Robert Lyon committed Mar 22, 2018
```
Change-Id: I85fa1c6e61f1bde2eeb6904f6e3a52effd97e280
(cherry picked from commit 6f7f734c)
```
  ecdf3d65
- Bug 1752181: remove link from delete user in Forums · e804e228
  Cecilia Vela Gurovic authored Mar 13, 2018 and Robert Lyon committed Mar 22, 2018
```
behatnotneeded

Change-Id: Ia077724bf288cfaec7a6b102fa6d0eaf3061e19e
(cherry picked from commit c7b0db48)
```
  e804e228
- Bug 1749403: Code correction in function find_key_name of lib/ddl.php · dc8c7c30
  Alexander Del Ponte authored Mar 19, 2018 and Robert Lyon committed Mar 22, 2018
```
behatnotneeded

Change-Id: Iafa9250163ffea5e7d9902ad0e2a6c96f734c3b8
(cherry picked from commit 82bc31a7)
```
  dc8c7c30
20 Mar, 2018 6 commits

Bug 1749834: Users can now see usernames for other users in share page · 1bbff559
Robert Lyon authored Mar 19, 2018
```
behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc
(cherry picked from commit 02cbb9ed)
```
1bbff559

Bug 1708959: mahara_user_get_users() function to accept params · 16808ebd

Robert Lyon authored Aug 25, 2017



The params being offset limit sortdir

And return offset, limit, totalcount, and array of users

behatnotneeded

Change-Id: I08f7fbfa59c4c129fb8efcc380f69738f4da624d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 416d477a)

16808ebd

Bug 1756631: Create group with relevant default institution set · b78ce570

Robert Lyon authored Mar 19, 2018



If the user is in one or more true institutions they need the default
option set as that and not 'mahara'

behatnotneeded

Change-Id: If295f76c3dac0c1ae5d3dd1ec2346511b0645150
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit cdea3ba4)

b78ce570

Bug 1755508: group member remove/request add-deny with pagination · 08ff7cf6
Cecilia Vela Gurovic authored Mar 20, 2018 and Robert Lyon committed Mar 21, 2018
```
behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604)
```
08ff7cf6
Bug 1753911: Behat: Files to Download block · 9a5bb8a2
Rebecca Blundell authored Mar 07, 2018 and Robert Lyon committed Mar 20, 2018
```
Change-Id: I4710fb7af96856de94bc06bbc06688e8d51fc076
(cherry picked from commit 6addbdaf)
```
9a5bb8a2

Bug 1752497: Changing radios to switch or select · 0e42525b

Rebecca Blundell authored Mar 05, 2018 and

Robert Lyon committed Mar 20, 2018

Makes better sense with a switch and select boxes in the creative commons block
behatnotneeded

Change-Id: Id90e3db0e850e26ea8113ca4ab19461515f13868
(cherry picked from commit dd1a799f)

0e42525b

19 Mar, 2018 3 commits

Bug 1731330: edit/delete buttons to btn-group style · b38fd178

Cecilia Vela Gurovic authored Mar 16, 2018 and

Robert Lyon committed Mar 19, 2018

Institution list Edit/delete buttons to be button group
in /admin/users/institutions.php

behatnotneeded

Change-Id: I775becf5c406e0892a5827b38a7a552845efec5c
(cherry picked from commit 4db92780)

b38fd178

Bug 1594192: Setting the mtime to 'now' if not valid time string · 107fba4c

Robert Lyon authored Mar 08, 2018



for leap2a artefact import

behatnotneeded

Change-Id: Ib87c051c824c56a732d02ce83a5a6f0811e1df37
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8bdba9ff)

107fba4c

Bug 1753359: Artefacts - Force public comments to be moderated · 4dca7ac5
Cecilia Vela Gurovic authored Mar 14, 2018 and Robert Lyon committed Mar 19, 2018
```
behatnotneeded

Change-Id: If0758686d6bbfbabfb847b88a829f0c659a38360
(cherry picked from commit ceaa34cb)
```
4dca7ac5

18 Mar, 2018 3 commits

Bug 1755674: check tinyMCE is not used in anonymous comments · 2a65c6d7
Cecilia Vela Gurovic authored Mar 15, 2018 and Robert Lyon committed Mar 19, 2018
```
behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04)
```
2a65c6d7
Bug 1755630: Fix non-retractable creativecommons block · f88b2e04
Rebecca Blundell authored Mar 15, 2018 and Robert Lyon committed Mar 18, 2018
```
behatnotneeded

Change-Id: Ib00d9053946a99ab71c30881f6a766d86bb2c75b
(cherry picked from commit e99270c8)
```
f88b2e04

Bug 1752477: Behat test: image gallery block · 1da9e692

Rebecca Blundell authored Mar 01, 2018 and

Robert Lyon committed Mar 18, 2018

-could be combined with nested_folders_images
-adding step to click a css selector without having to specify text
inside it
-also adding a properties step to call the above without passing
locators directly in feature files

Change-Id: I2b72e8c4d4506bbf24a37c64a4d3d27b0aad2aa4
(cherry picked from commit 173e04dc)

1da9e692

17 Mar, 2018 7 commits

Bug 1753841: Behat: delete text/image blocks · 67700a0c

Rebecca Blundell authored Mar 07, 2018 and

Robert Lyon committed Mar 18, 2018

-add check for deleting text block
-add check for deleting image block
-rename files
-rewrite Feature descripton and Scenario summary

Change-Id: Ia61646857fe789e3d513ac335117e860ae56d7cc
(cherry picked from commit 846a4843)

67700a0c

Bug 1754239: Behat: adding embedded_media_block test · 8305e480

Rebecca Blundell authored Mar 08, 2018 and

Robert Lyon committed Mar 18, 2018

This replaces the existing add_video test
including test for mp3

Also adds a better step to access an extension -> plugin configuration page

Change-Id: I78f8592c9afde411a40f20c72f2ae2be6bc6ff70
(cherry picked from commit 658daadb)

8305e480

Bug 1753634: Behat test for recent forum posts block · 8477fafe
Rebecca Blundell authored Mar 06, 2018 and Robert Lyon committed Mar 18, 2018
```
Change-Id: I72806214fcb8de9422729c2a614d3ab773de6784
(cherry picked from commit 1d95e29c)
```
8477fafe

Bug 1677929: Behat test: Add test for displaying profile info · d921a01b

Rebecca Blundell authored Feb 27, 2018 and

Robert Lyon committed Mar 17, 2018

-Adds profile image
-Adds profile block to a page
-Selects profile information to display
-Confirms selected information is displayed
-include test for add/delete profile pic from edit_admin_profile
and delete that scenario

Change-Id: I5137befab88f1c2fca6bddbdfa54b5f45a592c44
(cherry picked from commit 16914120)

d921a01b

Bug 1753612: Behat test for navigation block · c5c0bb89
Rebecca Blundell authored Mar 06, 2018 and Robert Lyon committed Mar 17, 2018
```
Change-Id: I5094cd08d64e1c746b1c7a58305339f658d00c4e
(cherry picked from commit a244ffe4)
```
c5c0bb89

Fixing the problem with behat and edit_page · ae236cf1

Robert Lyon authored Mar 16, 2018



I forgot to enable skins before testing for them
It kept passing locally because I had skins enabled in my config

Change-Id: I82bb07c18888307d756d8249660a8da38296066c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d1bfef56)

ae236cf1

Bug 1722435: Don't bother running the saml cron if not needed · 874c0129

Robert Lyon authored Mar 16, 2018



behatnotneeded

Change-Id: I221b08af2015712163fcbfca6e0a3962e932615b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6f74c6b6)

874c0129

15 Mar, 2018 2 commits
- Bug #1756153: Fix collapse configurable theme menu on Esc / mouse click · 43fec5f1
  Jaque authored Mar 16, 2018 and Robert Lyon committed Mar 16, 2018
```
behatnotneeded

Change-Id: I8b59c68e379085c8188068bc73eca1e9824e3c4f
(cherry picked from commit c7626e36)
```
  43fec5f1
- Bug #1755431: Remove bold from "Tags" in file browser description in blocks · 298c17d7
  Jaque authored Mar 16, 2018 and Robert Lyon committed Mar 16, 2018
```
behatnotneeded

Change-Id: I949eaaea85c4804253167b21ebfb3ade7aceddbe
(cherry picked from commit 736c0e40)
```
  298c17d7