Skip to content
GitLab
Switch branch/tag
  1. 23 Mar, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1756764: Alert user if shared with rules 2nd option empty · d5d67ffe
      Robert Lyon authored 
      

This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 55c50c1c)
      d5d67ffe
  3. 08 Mar, 2018 1 commit
  5. 29 Jun, 2017 1 commit
  7. 12 Jun, 2017 1 commit
  9. 26 Mar, 2017 1 commit
  11. 12 Sep, 2016 1 commit
  13. 30 Aug, 2016 1 commit
  15. 02 Mar, 2016 1 commit
  17. 16 Dec, 2015 2 commits
  19. 06 Nov, 2015 1 commit
  21. 04 Nov, 2015 1 commit
  23. 23 Oct, 2015 2 commits
    • Aaron Wells's avatar
      Straightening out the language string situation in the JS calendar (bug 1455137) · 287b6794
      Aaron Wells authored 
      The main thing this fixes, is that it causes the JS calendar to use ONLY the
new lang strings pieform_calendar_dateformat & pieform_calendar_timeformat,
for its formatting. These strings are in strftime() format, and are converted
into the JQuery Datepicker/Timepicker format by PHP (if we change to a different
calendar plugin in the future, we can change the PHP conversion function).

This fixes the bug where translators could break the calendar by changing the
JS format strings so they no longer matched the PHP format strings.

As a side effect of this change, I've also made it so that the help strings
are derived from the format string, and are translatable.

behatnotneeded: Date field is already tested by resume_page.feature

Change-Id: I152962cc27f36f93b51ee0327ed942fb089f7f5b
      287b6794
    • Robert Lyon's avatar
      Bug 1201174: Correctly saving access rules for allowing comments · c541ba8c
      Robert Lyon authored 
      

When turning off allowcomments page-wise and adding them per 'Share
with' options

Change-Id: Ic367fa89a04fa91c655c3f42005685181b948f78
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      c541ba8c
  25. 19 Oct, 2015 1 commit
  27. 27 Sep, 2015 1 commit
  29. 13 Aug, 2015 1 commit
  31. 11 Aug, 2015 1 commit
  33. 30 Jul, 2015 1 commit
  35. 23 Jul, 2015 1 commit
  37. 15 Jun, 2015 6 commits
  39. 26 Mar, 2015 1 commit
  41. 05 Feb, 2015 1 commit
  43. 06 Oct, 2014 1 commit
  45. 16 Sep, 2014 1 commit
    • Robert Lyon's avatar
      Updating calendar pieform element to use datepicker/timepicker · 3340ef27
      Robert Lyon authored 
      

(Bug #1267239)

The datepicker is now keyboard accessible but not fully screenreader
accessible - but the folks at datepicker are working on that

The key bindings you need to know for datepicker:
PAGE UP: Move to the previous month.
PAGE DOWN: Move to the next month.
CTRL+PAGE UP: Move to the previous year.
CTRL+PAGE DOWN: Move to the next year.
CTRL+HOME: Move to the current month. Open the datepicker if closed.
CTRL+LEFT: Move to the previous day.
CTRL+RIGHT: Move to the next day.
CTRL+UP: Move to the previous week.
CTRL+DOWN: Move the next week.
ENTER: Select the focused date.
ESC: Close the datepicker

The key bindings added for timepicker:
(to avoid clashes with existing key bindings)
ALT+UP: Move hour slider up one step
ALT+DOWN: Move hour slider down one step
SHIFT+LEFT: Move minute slider down one step
SHIFT+RIGHT: Move minute slider up one step

Also added the prev/next year button options

Change-Id: Iff857ba9efb23fd123de6af8f78ceffee9c0ac79
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      3340ef27
  47. 26 Jun, 2014 1 commit
  49. 27 May, 2014 1 commit
  51. 12 May, 2014 1 commit
  53. 17 Feb, 2014 1 commit
  55. 04 Feb, 2014 2 commits
  57. 08 Jan, 2014 1 commit
  59. 28 Aug, 2013 1 commit
  61. 19 Jul, 2013 1 commit
  63. 16 Jun, 2013 1 commit