GitLab

It turns out I was relying on a nasty behaviour quirk of json_decode in PHP,
namely that it'll just pass strings through - in some cases. This is horribly
out of touch with the JSON specification, see these PHP bugs:

http://bugs.php.net/bug.php?id=38680 (where they broke it)
http://bugs.php.net/bug.php?id=46518

 (people complaining about it)

The solution is to wrap all configuration fields when exporting as LEAP in an
array and then json_encode that. json_decode will handle that properly in all
versions of PHP.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

It takes stdClass objects, not arrays.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This will prevent notices every request on PHP 5.1.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Revealed after we started exposing E_RECOVERABLE_ERRORs.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This makes diffing the resulting XML file (in the case of LEAP2A export) easier.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Remove use of tablerenderer for view/artefact feedback; create feedback list using templates; use artefactchooser paginator
Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Also retabbed one of the files, probably need to do this for the others.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Missing these meant we were missing a whole class of errors, most
notably, when type hints were being ignored.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

The only place this is called, only the view ID is available to us. It
doesn't seem that important to pass a View to this method anyway, as it
returns the same string in all circumstances at the moment.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Make LeapExportElement::assign_smarty_vars throw an exception if called without the artefact field being set.

It seems this class can be used in two ways. In one way, it represents
one artefact being converted to an entry. The other way is where
something that isn't an artefact is being converted (e.g. a resume
"psuedo artefact"). Which is a bit naff, but no time to fix right now.
Instead, make this method die horribly if it's called directly. All
current callers override this method without calling the parent anyway.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

(#3404) Flip function arguments order around for constructor of LeapExportElementResumeCompositeSibling.

This matches everwhere that it's called. The bug never manifested itself
because we were quashing the E_RECOVERABLE_ERRORs caused by passing
invalidly typed arguments. Though it probably would have died on PHP
5.1.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

On PHP 5.1, this was causing a fatal error when it was hit.

On PHP 5.2 or greater, this causes an E_RECOVERABLE_ERROR. Due to a bug
in Mahara's error handler, such errors were being squashed so we never
saw them. Whoops!
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Prevents Dwoo warnings as spotted as part of fixing #3404.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This makes the watchlist stuff (and potentially other stuff on this
page) work again.

Spotted by Sam Timofeev on the forums.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Strangely, this didn't appear to be broken in IE8 with IE7 compatibility
mode on.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This leads to improved user experience.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

This reverts commit 246bdfec.

This reverts commit 8824fa29.