Skip to content

GitLab

Switch branch/tag
  1. 16 May, 2016 1 commit
  3. 01 May, 2016 1 commit
  5. 17 Jan, 2016 2 commits
  7. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 2565f2d8
      Aaron Wells authored and Robert Lyon's avatar Robert Lyon committed 
      Bug 1510421

Defines a new static PluginBlocktype method, get_css_icon(), which
fetches the name of the CSS icon to use for this blocktype. It returns
false by default, which tells the theme to "fall back" to the old
thumbnail.png instead. 3rd-party plugins can override this to
specify a particular icon to use.

All the core blocktypes have been refactored to extend
MaharaCoreBlocktype, which uses the blocktype name as the name
of the CSS icon to use. I also deprecated the "SystemBlocktype"
class while I was at it.

PluginBlocktype::get_blocktypes_for_category() now returns both
the results of get_css_icon() and the thumbnail.png path, so that
themes can decide which they want to use. (And of course
thumbnail.png is served via thumbnail.php, so 3rd party themes
can provide their own custom image files if they wish.)

behatnotneeded: Requires installing third-party plugins to test

Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
(cherry picked from commit 4f849ed2)
      2565f2d8
  9. 19 Oct, 2015 1 commit
  11. 07 Oct, 2015 1 commit
  13. 22 Sep, 2015 1 commit
  15. 20 Sep, 2015 1 commit
  17. 07 Aug, 2015 1 commit
  19. 30 Jul, 2015 2 commits
  21. 15 Jun, 2015 4 commits
  23. 18 May, 2015 1 commit
  25. 14 Apr, 2015 1 commit
  27. 26 Mar, 2015 1 commit
  29. 21 Mar, 2015 1 commit
  31. 18 Mar, 2015 1 commit
  33. 17 Mar, 2015 2 commits
  35. 13 Mar, 2015 3 commits
    • Aaron Wells's avatar
      Don't show the "leave feedback" link to logged-out users · 7ab38a32
      Aaron Wells authored 
      Bug 1431661: Logged-out users can't leave feedback anyway.
When they submit the feedback form, they are prompted to log
in. So, we may as well hide the "leave feedback" link for
logged-out users.

Change-Id: I5441c05e7dab5c50bd4e2ff24b841dfc13b2a133
      7ab38a32
    • Aaron Wells's avatar
      Annotation feedback JS shouldn't rely on window's URL path. · 797df58e
      Aaron Wells authored 
      Bug 1431668: This logic doesn't work for sites that are using
cleanURLs, and sites in subdirectories. And anyway, the
annotation.js file only gets loaded on pages where the block
is in "view" mode, so the logic isn't even needed.

Change-Id: I3c2a6505bd95331ab376cde6d5784e3c7e8cd6e2
      797df58e
    • Ghada El-Zoghbi's avatar
      Annotation artefact: Bug 1397759 · 389df353
      Ghada El-Zoghbi authored 
      A new artefact similar to the comment artefact but with less
functionality (i.e. no attached files, etc).
It's an explenation of why a particular evidence meets a
particular standard.

If an annotation is created and added to a page, when the user
deletes it from the page, the instance is deleted along with the
annotation and its feedback.

TODO:

1. Imports seem to be working.
Can get all comments to import and display.
Needs some serious testing.

2. Made changes for broken images but another bug was reported and is
currently being worked on. So, may not need the fixes in here. Changes in:
- htdocs/artefact/file/download.php

To completely fix the broken images for all artefacts, changes are also required
in htdocs/lib/embeddedimage.php to delete based on resourceid instead of fileid.

Change-Id: Ibdb2e1c6500862645bac741bf61cff37e5a5b35c
      389df353