Improved the wording for the Upload CSV page, especially in the case of institutional admins. Fixes #2214.

Previously, Institutional Admins were given links to pages they couldn't edit.

Make usernames unique over their lowercase values, and put validation in everywhere so two users can't do this again.

Usernames _are_ meant to be case insensitive in the system. But at no point where users could be created (except for XMLRPC users), was this actually being enforced. So eventually someone actually did this, which caused login for both users to break.

Now, all entry points for new users are checked to make sure users can't claim names whose lowercase value is the same as another user. And on postgres, we now have a unique index over LOWER(username). This isn't possible in MySQL, so MySQL users miss out (yet again).

Instead, generate a list of users who we could not send e-mail to, and display this to the uploaded, with more detailed reasons in the server error log.

* Force password change: if checked, users are forced to change their password on next log in. This was mandatory before, now people uploading CSV files can choose.
* E-mail users about accounts: if checked, users are sent an e-mail about their new account. This was never an option before and never happened, now it is on by default.

We send a slightly different e-mail based on whether the user needs to change their password or not. This affects the Add User script a tiny bit.

The name is largely irrelevant as it's only the creator of the file.

Signed-off-by: Andrew McMillan

Now, table names (and other identifiers that could be confused with SQL kewords), should be put into SQL like this:

SELECT * FROM {artefact}

The braces are matched and expanded by DML now to include the prefix and be properly quoted, which means that tables like 'view' and 'group' don't need renaming (and nor should they, there's little reason why we should rename tables to get around such constraints).

This has removed a whole bunch of $prefix = ... and get_config('dbprefix') stuff, which makes things a little simpler yet again.

code

Turn on auto detected line endings so that mac line ending files can be uploaded. Disabled the error suppression on the File_CSV::readQuoted. Make sure to detect when we couldn't parse the CSV file (for some reason we're not sure of), and tell the user

on the first line, to prevent ambiguities that were causing it to be
broken before

subdirectory properly.

be better worded