GitLab

During an upgrade, the clean up should also remove records from
the oauth_server_config table.

behatnotneeded

Change-Id: Ia0ae61ddb7cf7b05241466ec0d6900d2025d662b
(cherry picked from commit 6b06c240)

So far:
1) Remove Zend library
2) Getting xmlrpc to work with testclient using token
3) Getting xmlrpc to work with testclient using user auth
2) Getting soap to work with testclient using token
3) Getting soap to work with testclient using user auth

behatnotneeded

Change-Id: I0fb9452a5ff21c270abf84f4793ca7b899a63d77

Rather than setting it to 'mahara' by default

behatnotneeded

Change-Id: I7dcd754febe0ab56488aeca941b76e6cce112409
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

By checking if extra args are expected

behatnotneeded

Change-Id: I64d4b0bc55323be71fcf11c4455e19190d511ea3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ic7d4ea2fb48228dcea5504cc8404bf0aa2474152
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If an LTI parameter is unknown and prefixed with 'custom_',
drop it from the data passed to the handler function.
Then if the site is in non-production mode,
also show this information.

behatnotneeded

Change-Id: I3fac19c27df2b9f072b8cdbcb8a2458c506c018e

Before checking that it is in database and is unique

behatnotneeded

Change-Id: I3c51b228361ad10c567f6af04148246a95fed096
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* Extends the existing webservice auth to support SSO via LTI
* Adds an LTI module to support SSO and future LTI features
* Adds per-oauth token config to enable/disable on-the-fly user creation

behatnotneeded

Change-Id: Id6488930f37bdfd8200b4e9261f5292f2b72fbc7

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Was not quite working before.

Things also fixed (or partially fixed)
1) The webservice logs page searching for function name to filter by
- before the ajax was wanting to paginate by 5 and select2 expected 10
results so the more search results was not working

2) The error returned on the testclient page when there was an error
with a field didn't display which field it was.

3) Display on testclient page a file upload filed if type is PARAM_FILE
- The actual testing of file upload is not working yet but it wasn't
working before either but this is a step in the right direction

4) The wsdocs page was displaying 'REQUIRED' for the VALUE_DEFAULT
fields rather than the VALUE_REQUIRED fields.

behatnotneeded

Change-Id: Ia00beeb6d48fa3019984f2e0f7605fbb097edffd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Covered by existing tests

Change-Id: Iec9939b02b7b38fbf0f3217d6be45d538e3a9760

behatnotneeded: Test to come later

Change-Id: I0c1b2b7ee9cc927a23c498293da0ddc1ec31f31e

This module will hold most of the code specifically needed
by the Mahara Mobile app (as opposed to normal webservices
functionality, which is mostly meant to be server-to-server)

behatnotneeded: Test to come later

Change-Id: I8dca163ba9dd4c1777564e305cf49768358be088

- Respect the "optional" and "default" flags for
object and array params (not just scalar params)

- Allow REST server to handle file upload params ($_FILES)

behatnotneeded: Tests to come later

Change-Id: I3a6a6ccf7c9de1711e2fd39aa5f130c245823721

These fields can be used to indicate which client app
registered and/or is using the token

behatnotneeded: Can't be tested in Behat

Change-Id: I939c844cc5474fc799ddfd002a1052bb4ca67d1b

Two of the server classes had their own implementations of this,
with slightly different logic. Moving it up into the parent class
in order to make sure everything works the same, all the time.

behatnotneeded: Can't test in Behat

Change-Id: I91c205822a18213c475bbef7c784247cebdbd649

Currently, a plugin has to list its component as e.g.
"module/mobileapi/webservice". This could just be "module/mobileapi".

Since we're using the component string as part of the automated token
request system, it's better to change this now to something more sensible.

behatnotneeded: Tests to come later

Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d

To help clients determine which version of a webservice
they might be connecting to.

behatnotneeded: Tests to come later

Change-Id: I90abd0d9470cba4ae42ee3a22a6c0629d325f8d2

- Adding "shortname" field to service groups
- Marking plugin-created service groups, as the ones that have
a "component" field. Make the function list for plugin-created
service groups not editable by users.
- Since users may have already edited the old "sample" service
groups, removing the "component" value from those.
- And, to avoid trouble going forward, preventing the install
of the sample service groups on new installations

behatnotneeded: Tests to be written later

Change-Id: I23c781d6f2bbf689c12de30a67882bf3f1f4aff9

JSON-encodes more information about the error or exception,
and adds an optional error number.

behatnotneeded: Can't test in Behat

Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

If the site doesn't yet have any plugins installed that define webservice
connections, then the institution connection manager screen can't be used.
In which case, we should hide the link to avoid confusing users.

Change-Id: Ia9351995485331ea5d6fc94fcdf69eafbfa18c01
behatnotneeded: Can't readily test in Behat

To keep it consistent with rest of Mahara

1) Moving the template files to the plugin/auth dir
2) Removing the old style submenu lines
3) Removing the bad window.open() calls
4) Fixing up menu placement / order
5) Fixing the add connection form's errors so they appear against
correct fields

behatnotneeded

Change-Id: Ic73526a2db2c6f8d7009b374a8ecc0977ba57330
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ica193fac3c4ee0d000c503f61205b226da344466

behatnotneeded

Change-Id: I224fcad3a4be6b54e4b48c07392a9415e22738b6

* added new client connection manager screens
* added client connection manager backend

behatnotneeded

Change-Id: Iac103616c7a9cd68cc94ea301a4cb808fe090669

Change-Id: I573e6f354a2077afbaed5a501d2d99106b736e1a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Allowing each of the 'classname' classes listed in external_functions
to be it's own function file to make it easier for developers.

Change-Id: I9c4e3dfc198abdf2c274c8a7d569fce5bf431471
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To be more in keeping with existing codebase.

Change-Id: Iaa850c7cfc609afee0dd014bef6d2a2673c7a25f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ib728376b9262bc0bcd45c3f72abba4903dede902
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I398479c34771df1978a98ac42b1b866afe4e7917
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Adding in the plugin from
https://github.com/piersharding/mahara-contrib-auth-webservice

Change-Id: Ib5dea8c908cb5fd225687ecd37e80dc211dbe5f2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>