GitLab

Now that we want to show multiple feedbacks on the view page we need
to switch the styles off the id and onto a class

Change-Id: I0e9c54909dbc37132606a01b4cb104612efbc827
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- Created 'objectionable' table
- Migrated existing objectionable records to a new table
- Added is_objectionable() method to View class
- Fixed can_view_view() and elasticsearch to use new table
- Fixed artefact.tpl style to match view page when displaying "Not objectionable" form
- Make forum reports use new 'objectionable' table

Change-Id: Ib3759e86c4003216ad57f3cf68911b13e50e9c67
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

- allow the feedback to display in a block.

Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.

2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message

3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.

4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.

This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.

Change-Id: I1edaa886c5a0df1f6feb24bcdd6d8878a833d673

Here are all the UI changes that were made by Evonne

Change-Id: I08d98d759a701deaf0a332af9e9392b7270704a5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug #1006634, part 3

The template can be simplified a bit by using View::display_title()
instead of generating titles and links for the view and its owner.

The owner_link function is called by display_title, and is updated
here to return clean urls.

Change-Id: Ia4653b2050be1f3b4443130165dcfcbe94a6121b
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I7feec0f61660f49a6bc517972baf6c7f8ddcc33c
Signed-off-by: Francois Marier <francois@catalyst.net.nz>
Reviewed-on: https://reviews.mahara.org/11Reviewed-by: Richard Mansfield <richardm@mahara.org>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

We will remove it in each template once we've added |escape or |safe to every variable.
Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

- use the mahara logo if the user has no profile icon set
- use the user's personal website as the author uri, if set
- add a generator to indicate that the feed was generated by Mahara
- set the icon element to use favicon.ico
- set feed rights based on presence or lack of CC block in view
- display feed icon in the view if the view is public

(partial implementation of Eduforge Feature Request #3357)
Signed-off-by: Evan Goldenberg <evang@catalyst.net.nz>
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Remove use of tablerenderer for view/artefact feedback; create feedback list using templates; use artefactchooser paginator
Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

The 'default' theme is to come back shortly.

* A more neutral colour scheme, appropriate for a default installation
* Forms are layed out with the title beside the inputs
* The profile page is in tabs
* Layout is cleaner and clearer
* Still will be some bugs, especially in IE!

Applied the same feedback improvements to viewing an artefact that were previously applied to viewing a view.

Also make it impossible to submit a file as an attachment when viewing an artefact. Digging around on production suggests this feature isn't used, and it's buggy because if the user chooses to upload a file, then the feedback is placed on the view rather than the artefact they were viewing.

Basic template for viewing an artefact. Follows the structure of how view/view.php worked for now, so CSS rules work.

Use the appropriate smarty variable for the heading, so that the title when creating a view is 'create view'

them more sensibly

yet. A few templates changed as the "full width" class is now called
column-full instead of column-left-full.